From 66687158c55cbe8a299a5e42285053d706ea55e5 Mon Sep 17 00:00:00 2001 From: Matthew Kennedy Date: Thu, 19 Nov 2020 17:51:30 -0800 Subject: [PATCH] no feed forward for wastegate (#1971) Co-authored-by: Matthew Kennedy --- firmware/controllers/actuators/electronic_throttle.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/firmware/controllers/actuators/electronic_throttle.cpp b/firmware/controllers/actuators/electronic_throttle.cpp index 690663e1a0..d34ed62a23 100644 --- a/firmware/controllers/actuators/electronic_throttle.cpp +++ b/firmware/controllers/actuators/electronic_throttle.cpp @@ -275,8 +275,16 @@ expected EtbController::getSetpointEtb() const { } expected EtbController::getOpenLoop(percent_t target) const { - float ff = interpolate2d("etbb", target, engineConfiguration->etbBiasBins, engineConfiguration->etbBiasValues); + float ff = 0; + + // Don't apply open loop for wastegate/idle valve, only real ETB + if (m_function != ETB_Wastegate + && m_function != ETB_IdleValve) { + ff = interpolate2d("etbb", target, engineConfiguration->etbBiasBins, engineConfiguration->etbBiasValues); + } + engine->engineState.etbFeedForward = ff; + return ff; }