From 6b3e028ba81c0f4ba0bd14e1ae211e4a93e58078 Mon Sep 17 00:00:00 2001
From: rusefillc <sdfsdfqsf2334234234>
Date: Sun, 15 May 2022 15:40:19 -0400
Subject: [PATCH] reduce flash footprint by smarter code generation #4163

---
 firmware/controllers/settings.cpp | 44 ++++++++++++++++++++++---------
 1 file changed, 31 insertions(+), 13 deletions(-)

diff --git a/firmware/controllers/settings.cpp b/firmware/controllers/settings.cpp
index f021692c4b..0c470e63e4 100644
--- a/firmware/controllers/settings.cpp
+++ b/firmware/controllers/settings.cpp
@@ -891,27 +891,45 @@ static plain_get_float_s getF_plain[] = {
 #endif /* EFI_UNIT_TEST */
 
 
+static plain_get_float_s * findFloat2(const char *name) {
+	plain_get_float_s *currentF = &getF_plain[0];
+	while (currentF < getF_plain + sizeof(getF_plain)/sizeof(getF_plain[0])) {
+		if (strEqualCaseInsensitive(name, currentF->token)) {
+			return currentF;
+		}
+		currentF++;
+	}
+	return nullptr;
+}
+
+static plain_get_integer_s *findInt(const char *name) {
+	plain_get_integer_s *currentI = &getI_plain[0];
+	while (currentI < getI_plain + sizeof(getI_plain)/sizeof(getI_plain[0])) {
+		if (strEqualCaseInsensitive(name, currentI->token)) {
+			return currentI;
+		}
+		currentI++;
+	}
+	return nullptr;
+}
+
 static void getValue(const char *paramStr) {
 #if ! EFI_UNIT_TEST
 	{
-		const plain_get_integer_s *currentI = &getI_plain[0];
-		while (currentI < getI_plain + sizeof(getI_plain)/sizeof(getI_plain[0])) {
-			if (strEqualCaseInsensitive(paramStr, currentI->token)) {
-				efiPrintf("%s value: %d", currentI->token, *currentI->value);
-				return;
-			}
-			currentI++;
+		plain_get_integer_s *known = findInt(paramStr);
+		if (known != nullptr) {
+			efiPrintf("%s value: %d", known->token, *known->value);
+			return;
 		}
 	}
 
-	const plain_get_float_s *currentF = &getF_plain[0];
-	while (currentF < getF_plain + sizeof(getF_plain)/sizeof(getF_plain[0])) {
-		if (strEqualCaseInsensitive(paramStr, currentF->token)) {
-			float value = *currentF->value;
-			efiPrintf("%s value: %.2f", currentF->token, value);
+	{
+		plain_get_float_s * known = findFloat2(paramStr);
+		if (known != nullptr) {
+			float value = *known->value;
+			efiPrintf("%s value: %.2f", known->token, value);
 			return;
 		}
-		currentF++;
 	}