rusefi
/
rusefi-1
mirror of https://github.com/rusefi/rusefi-1.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

warning cleanup (#4020)

This commit is contained in:
Matthew Kennedy 2022-03-22 13:53:24 -07:00 committed by GitHub
parent be283b96d2
commit 7d657106d7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 61 additions and 64 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
firmware/controllers/core/error_handling.h
View File

@ -44,10 +44,6 @@ const char* getWarningMessage(void);
// todo: better place for this shared declaration? // todo: better place for this shared declaration?
int getRusEfiVersion(void); int getRusEfiVersion(void);
/**
* @deprecated Global panic is inconvenient because it's hard to deliver the error message while whole instance
* is stopped. Please use firmwareWarning() instead
*/
#if EFI_ENABLE_ASSERTS #if EFI_ENABLE_ASSERTS
#define efiAssert(code, condition, message, result) { if (!(condition)) { firmwareError(code, message); return result; } } #define efiAssert(code, condition, message, result) { if (!(condition)) { firmwareError(code, message); return result; } }
#define efiAssertVoid(code, condition, message) { if (!(condition)) { firmwareError(code, message); return; } } #define efiAssertVoid(code, condition, message) { if (!(condition)) { firmwareError(code, message); return; } }

99
firmware/controllers/math/engine_math.cpp
View File

@ -107,58 +107,58 @@ floatms_t getSparkDwell(int rpm) {
#endif #endif
} }
static const int order_1[] = {1}; static const uint8_t order_1[] = {1};
static const int order_1_2[] = {1, 2}; static const uint8_t order_1_2[] = {1, 2};
static const int order_1_2_3[] = {1, 2, 3}; static const uint8_t order_1_2_3[] = {1, 2, 3};
static const int order_1_3_2[] = {1, 3, 2}; static const uint8_t order_1_3_2[] = {1, 3, 2};
// 4 cylinder // 4 cylinder
static const int order_1_THEN_3_THEN_4_THEN2[] = { 1, 3, 4, 2 }; static const uint8_t order_1_THEN_3_THEN_4_THEN2[] = { 1, 3, 4, 2 };
static const int order_1_THEN_2_THEN_4_THEN3[] = { 1, 2, 4, 3 }; static const uint8_t order_1_THEN_2_THEN_4_THEN3[] = { 1, 2, 4, 3 };
static const int order_1_THEN_3_THEN_2_THEN4[] = { 1, 3, 2, 4 }; static const uint8_t order_1_THEN_3_THEN_2_THEN4[] = { 1, 3, 2, 4 };
static const int order_1_THEN_4_THEN_3_THEN2[] = { 1, 4, 3, 2 }; static const uint8_t order_1_THEN_4_THEN_3_THEN2[] = { 1, 4, 3, 2 };
// 5 cylinder // 5 cylinder
static const int order_1_2_4_5_3[] = {1, 2, 4, 5, 3}; static const uint8_t order_1_2_4_5_3[] = {1, 2, 4, 5, 3};
// 6 cylinder // 6 cylinder
static const int order_1_THEN_5_THEN_3_THEN_6_THEN_2_THEN_4[] = { 1, 5, 3, 6, 2, 4 }; static const uint8_t order_1_THEN_5_THEN_3_THEN_6_THEN_2_THEN_4[] = { 1, 5, 3, 6, 2, 4 };
static const int order_1_THEN_4_THEN_2_THEN_5_THEN_3_THEN_6[] = { 1, 4, 2, 5, 3, 6 }; static const uint8_t order_1_THEN_4_THEN_2_THEN_5_THEN_3_THEN_6[] = { 1, 4, 2, 5, 3, 6 };
static const int order_1_THEN_2_THEN_3_THEN_4_THEN_5_THEN_6[] = { 1, 2, 3, 4, 5, 6 }; static const uint8_t order_1_THEN_2_THEN_3_THEN_4_THEN_5_THEN_6[] = { 1, 2, 3, 4, 5, 6 };
static const int order_1_6_3_2_5_4[] = {1, 6, 3, 2, 5, 4}; static const uint8_t order_1_6_3_2_5_4[] = {1, 6, 3, 2, 5, 4};
static const int order_1_4_3_6_2_5[] = {1, 4, 3, 6, 2, 5}; static const uint8_t order_1_4_3_6_2_5[] = {1, 4, 3, 6, 2, 5};
static const int order_1_6_2_4_3_5[] = {1, 6, 2, 4, 3, 5}; static const uint8_t order_1_6_2_4_3_5[] = {1, 6, 2, 4, 3, 5};
static const int order_1_6_5_4_3_2[] = {1, 6, 5, 4, 3, 2}; static const uint8_t order_1_6_5_4_3_2[] = {1, 6, 5, 4, 3, 2};
static const int order_1_4_5_2_3_6[] = {1, 4, 5, 2, 3, 6}; static const uint8_t order_1_4_5_2_3_6[] = {1, 4, 5, 2, 3, 6};
// 8 cylinder // 8 cylinder
static const int order_1_8_4_3_6_5_7_2[] = { 1, 8, 4, 3, 6, 5, 7, 2 }; static const uint8_t order_1_8_4_3_6_5_7_2[] = { 1, 8, 4, 3, 6, 5, 7, 2 };
static const int order_1_8_7_2_6_5_4_3[] = { 1, 8, 7, 2, 6, 5, 4, 3 }; static const uint8_t order_1_8_7_2_6_5_4_3[] = { 1, 8, 7, 2, 6, 5, 4, 3 };
static const int order_1_5_4_2_6_3_7_8[] = { 1, 5, 4, 2, 6, 3, 7, 8 }; static const uint8_t order_1_5_4_2_6_3_7_8[] = { 1, 5, 4, 2, 6, 3, 7, 8 };
static const int order_1_2_7_8_4_5_6_3[] = { 1, 2, 7, 8, 4, 5, 6, 3 }; static const uint8_t order_1_2_7_8_4_5_6_3[] = { 1, 2, 7, 8, 4, 5, 6, 3 };
static const int order_1_3_7_2_6_5_4_8[] = { 1, 3, 7, 2, 6, 5, 4, 8 }; static const uint8_t order_1_3_7_2_6_5_4_8[] = { 1, 3, 7, 2, 6, 5, 4, 8 };
static const int order_1_2_3_4_5_6_7_8[] = { 1, 2, 3, 4, 5, 6, 7, 8 }; static const uint8_t order_1_2_3_4_5_6_7_8[] = { 1, 2, 3, 4, 5, 6, 7, 8 };
static const int order_1_5_4_8_6_3_7_2[] = { 1, 5, 4, 8, 6, 3, 7, 2 }; static const uint8_t order_1_5_4_8_6_3_7_2[] = { 1, 5, 4, 8, 6, 3, 7, 2 };
static const int order_1_8_7_3_6_5_4_2[] = { 1, 8, 7, 3, 6, 5, 4, 2 }; static const uint8_t order_1_8_7_3_6_5_4_2[] = { 1, 8, 7, 3, 6, 5, 4, 2 };
// 9 cylinder // 9 cylinder
static const int order_1_2_3_4_5_6_7_8_9[] = { 1, 2, 3, 4, 5, 6, 7, 8, 9 }; static const uint8_t order_1_2_3_4_5_6_7_8_9[] = { 1, 2, 3, 4, 5, 6, 7, 8, 9 };
// 10 cylinder // 10 cylinder
static const int order_1_10_9_4_3_6_5_8_7_2[] = {1, 10, 9, 4, 3, 6, 5, 8, 7, 2}; static const uint8_t order_1_10_9_4_3_6_5_8_7_2[] = {1, 10, 9, 4, 3, 6, 5, 8, 7, 2};
// 12 cyliner // 12 cyliner
static const int order_1_7_5_11_3_9_6_12_2_8_4_10[] = {1, 7, 5, 11, 3, 9, 6, 12, 2, 8, 4, 10}; static const uint8_t order_1_7_5_11_3_9_6_12_2_8_4_10[] = {1, 7, 5, 11, 3, 9, 6, 12, 2, 8, 4, 10};
static const int order_1_7_4_10_2_8_6_12_3_9_5_11[] = {1, 7, 4, 10, 2, 8, 6, 12, 3, 9, 5, 11}; static const uint8_t order_1_7_4_10_2_8_6_12_3_9_5_11[] = {1, 7, 4, 10, 2, 8, 6, 12, 3, 9, 5, 11};
static const int order_1_12_5_8_3_10_6_7_2_11_4_9[] = {1, 12, 5, 8, 3, 10, 6, 7, 2, 11, 4, 9}; static const uint8_t order_1_12_5_8_3_10_6_7_2_11_4_9[] = {1, 12, 5, 8, 3, 10, 6, 7, 2, 11, 4, 9};
static const int order_1_2_3_4_5_6_7_8_9_10_11_12[] = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12}; static const uint8_t order_1_2_3_4_5_6_7_8_9_10_11_12[] = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12};
// no comments // no comments
static const int order_1_14_9_4_7_12_15_6_13_8_3_16_11_2_5_10[] = {1, 14, 9, 4, 7, 12, 15, 6, 13, 8, 3, 16, 11, 2, 5, 10}; static const uint8_t order_1_14_9_4_7_12_15_6_13_8_3_16_11_2_5_10[] = {1, 14, 9, 4, 7, 12, 15, 6, 13, 8, 3, 16, 11, 2, 5, 10};
static int getFiringOrderLength() { static size_t getFiringOrderLength() {
switch (engineConfiguration->specs.firingOrder) { switch (engineConfiguration->specs.firingOrder) {
case FO_1: case FO_1:
@ -226,7 +226,7 @@ static int getFiringOrderLength() {
return 1; return 1;
} }
static const int *getFiringOrderTable() static const uint8_t* getFiringOrderTable()
{ {
switch (engineConfiguration->specs.firingOrder) { switch (engineConfiguration->specs.firingOrder) {
case FO_1: case FO_1:
@ -323,9 +323,8 @@ static const int *getFiringOrderTable()
* @param index from zero to cylindersCount - 1 * @param index from zero to cylindersCount - 1
* @return cylinderId from one to cylindersCount * @return cylinderId from one to cylindersCount
*/ */
int getCylinderId(int index) { size_t getCylinderId(size_t index) {
const size_t firingOrderLength = getFiringOrderLength();
const int firingOrderLength = getFiringOrderLength();
if (firingOrderLength < 1 || firingOrderLength > MAX_CYLINDER_COUNT) { if (firingOrderLength < 1 || firingOrderLength > MAX_CYLINDER_COUNT) {
firmwareError(CUSTOM_FIRING_LENGTH, "fol %d", firingOrderLength); firmwareError(CUSTOM_FIRING_LENGTH, "fol %d", firingOrderLength);
@ -337,34 +336,36 @@ int getCylinderId(int index) {
return 1; return 1;
} }
if (index < 0 || index >= firingOrderLength) { if (index >= firingOrderLength) {
// May 2020 this somehow still happens with functional tests, maybe race condition? // May 2020 this somehow still happens with functional tests, maybe race condition?
warning(CUSTOM_ERR_6686, "firing order index %d", index); warning(CUSTOM_ERR_6686, "firing order index %d", index);
return 1; return 1;
} }
const int *firingOrderTable = getFiringOrderTable(); if (auto firingOrderTable = getFiringOrderTable()) {
if (firingOrderTable)
return firingOrderTable[index]; return firingOrderTable[index];
/* else } else {
error already reported */ // error already reported
return 1;
return 1; }
} }
/** /**
* @param prevCylinderId from one to cylindersCount * @param prevCylinderId from one to cylindersCount
* @return cylinderId from one to cylindersCount * @return cylinderId from one to cylindersCount
*/ */
int getNextFiringCylinderId(int prevCylinderId) { size_t getNextFiringCylinderId(size_t prevCylinderId) {
const int firingOrderLength = getFiringOrderLength(); const size_t firingOrderLength = getFiringOrderLength();
const int *firingOrderTable = getFiringOrderTable(); auto firingOrderTable = getFiringOrderTable();
if (firingOrderTable) { if (firingOrderTable) {
for (size_t i = 0; i < firingOrderLength; i++) for (size_t i = 0; i < firingOrderLength; i++) {
if (firingOrderTable[i] == prevCylinderId) if (firingOrderTable[i] == prevCylinderId) {
return firingOrderTable[(i + 1) % firingOrderLength]; return firingOrderTable[(i + 1) % firingOrderLength];
}
}
} }
return 1; return 1;
} }

4
firmware/controllers/math/engine_math.h
View File

@ -49,8 +49,8 @@ ignition_mode_e getCurrentIgnitionMode();
*/ */
void prepareIgnitionPinIndices(ignition_mode_e ignitionMode); void prepareIgnitionPinIndices(ignition_mode_e ignitionMode);
int getCylinderId(int index); size_t getCylinderId(size_t index);
int getNextFiringCylinderId(int prevCylinderId); size_t getNextFiringCylinderId(size_t prevCylinderId);
void setTimingRpmBin(float from, float to); void setTimingRpmBin(float from, float to);
void setTimingLoadBin(float from, float to); void setTimingLoadBin(float from, float to);

2
firmware/controllers/trigger/decoders/trigger_nissan.cpp
View File

@ -138,7 +138,7 @@ void makeNissanPattern(TriggerWaveform* s, size_t halfCylinderCount, size_t tota
auto toothCount = patternTeeth - missing; auto toothCount = patternTeeth - missing;
float currentAngle = missing * toothAngle; float currentAngle = missing * toothAngle;
for (int i = 0; i < toothCount; i++) { for (size_t i = 0; i < toothCount; i++) {
currentAngle += toothAngle; currentAngle += toothAngle;
s->addEventAngle(currentAngle - 5, T_PRIMARY, TV_RISE); s->addEventAngle(currentAngle - 5, T_PRIMARY, TV_RISE);
s->addEventAngle(currentAngle, T_PRIMARY, TV_FALL); s->addEventAngle(currentAngle, T_PRIMARY, TV_FALL);

10
firmware/controllers/trigger/trigger_decoder.cpp
View File

@ -163,17 +163,17 @@ void prepareEventAngles(TriggerWaveform *shape,
int riseOnlyIndex = 0; int riseOnlyIndex = 0;
int length = shape->getLength(); size_t length = shape->getLength();
memset(details->eventAngles, 0, sizeof(details->eventAngles)); memset(details->eventAngles, 0, sizeof(details->eventAngles));
// this may be <length for some triggers like symmetrical crank Miata NB // this may be <length for some triggers like symmetrical crank Miata NB
int triggerShapeLength = shape->getSize(); size_t triggerShapeLength = shape->getSize();
assertAngleRange(shape->triggerShapeSynchPointIndex, "triggerShapeSynchPointIndex", CUSTOM_TRIGGER_SYNC_ANGLE2); assertAngleRange(shape->triggerShapeSynchPointIndex, "triggerShapeSynchPointIndex", CUSTOM_TRIGGER_SYNC_ANGLE2);
efiAssertVoid(CUSTOM_TRIGGER_CYCLE, engine->engineCycleEventCount != 0, "zero engineCycleEventCount"); efiAssertVoid(CUSTOM_TRIGGER_CYCLE, engine->engineCycleEventCount != 0, "zero engineCycleEventCount");
for (int eventIndex = 0; eventIndex < length; eventIndex++) { for (size_t eventIndex = 0; eventIndex < length; eventIndex++) {
if (eventIndex == 0) { if (eventIndex == 0) {
// explicit check for zero to avoid issues where logical zero is not exactly zero due to float nature // explicit check for zero to avoid issues where logical zero is not exactly zero due to float nature
details->eventAngles[0] = 0; details->eventAngles[0] = 0;
@ -259,7 +259,7 @@ float TriggerStateWithRunningStatistics::calculateInstantRpm(
/** /**
* todo: Martin has this fatal error while feeding external RPM and changing trigger mode from 4 stoke cam to 4 stroke symmetrical * todo: Martin has this fatal error while feeding external RPM and changing trigger mode from 4 stoke cam to 4 stroke symmetrical
*/ */
assertIsInBoundsWithResult((int)current_index, timeOfLastEvent, "calc timeOfLastEvent", 0); assertIsInBoundsWithResult(current_index, timeOfLastEvent, "calc timeOfLastEvent", 0);
// Record the time of this event so we can calculate RPM from it later // Record the time of this event so we can calculate RPM from it later
timeOfLastEvent[current_index] = nowNt; timeOfLastEvent[current_index] = nowNt;
@ -294,7 +294,7 @@ float TriggerStateWithRunningStatistics::calculateInstantRpm(
return prevInstantRpmValue; return prevInstantRpmValue;
float instantRpm = (60000000.0 / 360 * US_TO_NT_MULTIPLIER) * angleDiff / time; float instantRpm = (60000000.0 / 360 * US_TO_NT_MULTIPLIER) * angleDiff / time;
assertIsInBoundsWithResult((int)current_index, instantRpmValue, "instantRpmValue", 0); assertIsInBoundsWithResult(current_index, instantRpmValue, "instantRpmValue", 0);
instantRpmValue[current_index] = instantRpm; instantRpmValue[current_index] = instantRpm;
// This fixes early RPM instability based on incomplete data // This fixes early RPM instability based on incomplete data

2
firmware/hw_layer/pin_repository.cpp
View File

@ -189,7 +189,7 @@ void printSpiConfig(const char *msg, spi_device_e device) {
#endif // HAL_USE_SPI #endif // HAL_USE_SPI
} }
__attribute__((weak)) const char * getBoardSpecificPinName(brain_pin_e brainPin) { __attribute__((weak)) const char * getBoardSpecificPinName(brain_pin_e /*brainPin*/) {
return nullptr; return nullptr;
} }

4
firmware/util/efilib.h
View File

@ -133,9 +133,9 @@ constexpr void clear(T& obj) {
} }
} // namespace efi } // namespace efi
#define assertIsInBounds(length, array, msg) efiAssertVoid(OBD_PCM_Processor_Fault, (length) >= 0 && (length) < efi::size(array), msg) #define assertIsInBounds(length, array, msg) efiAssertVoid(OBD_PCM_Processor_Fault, std::is_unsigned_v<decltype(length)> && (length) < efi::size(array), msg)
#define assertIsInBoundsWithResult(length, array, msg, failedResult) efiAssert(OBD_PCM_Processor_Fault, (length) >= 0 && (length) < efi::size(array), msg, failedResult) #define assertIsInBoundsWithResult(length, array, msg, failedResult) efiAssert(OBD_PCM_Processor_Fault, std::is_unsigned_v<decltype(length)> && (length) < efi::size(array), msg, failedResult)
/** /**
* Copies an array from src to dest. The lengths of the arrays must match. * Copies an array from src to dest. The lengths of the arrays must match.