From 8739e192f5be202f34c7e1dd9e51eb685bf10168 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Sun, 6 Dec 2020 18:39:50 -0500 Subject: [PATCH] basic hw in the loop - pwm self validation #2028 --- .../controllers/actuators/alternator_controller.cpp | 10 ++++++++++ firmware/controllers/actuators/alternator_controller.h | 2 ++ firmware/controllers/actuators/boost_control.cpp | 2 ++ firmware/development/logic_analyzer.cpp | 8 ++++++++ firmware/development/logic_analyzer.h | 2 ++ java_console/autotest/src/com/rusefi/RealHwTest.java | 2 +- 6 files changed, 25 insertions(+), 1 deletion(-) diff --git a/firmware/controllers/actuators/alternator_controller.cpp b/firmware/controllers/actuators/alternator_controller.cpp index eba8f0a333..303512c2b9 100644 --- a/firmware/controllers/actuators/alternator_controller.cpp +++ b/firmware/controllers/actuators/alternator_controller.cpp @@ -171,4 +171,14 @@ void initAlternatorCtrl(Logging *sharedLogger DECLARE_ENGINE_PARAMETER_SUFFIX) { instance.Start(); } +// todo: start invoking this method like 'startAuxPins' +void startAlternatorPin(void) { + +} + +void stopAlternatorPin(void) { + // todo: implementation! +} + + #endif /* EFI_ALTERNATOR_CONTROL */ diff --git a/firmware/controllers/actuators/alternator_controller.h b/firmware/controllers/actuators/alternator_controller.h index 42f3a00c6c..9ae34b1827 100644 --- a/firmware/controllers/actuators/alternator_controller.h +++ b/firmware/controllers/actuators/alternator_controller.h @@ -12,6 +12,8 @@ #include "engine.h" void initAlternatorCtrl(Logging *sharedLogger); +void startAlternatorPin(void); +void stopAlternatorPin(void); void setAltPFactor(float p); void setAltIFactor(float p); void setAltDFactor(float p); diff --git a/firmware/controllers/actuators/boost_control.cpp b/firmware/controllers/actuators/boost_control.cpp index 95ac8b1e69..9aa80944e7 100644 --- a/firmware/controllers/actuators/boost_control.cpp +++ b/firmware/controllers/actuators/boost_control.cpp @@ -221,6 +221,8 @@ void onConfigurationChangeBoostCallback(engine_configuration_s *previousConfigur } void initBoostCtrl(Logging *sharedLogger DECLARE_ENGINE_PARAMETER_SUFFIX) { + // todo: why do we have 'isBoostControlEnabled' setting exactly? + // 'initAuxPid' is an example of a subsystem without explicit enable if (!CONFIG(isBoostControlEnabled)) { return; } diff --git a/firmware/development/logic_analyzer.cpp b/firmware/development/logic_analyzer.cpp index 92d3ece5d1..afe88cfbe8 100644 --- a/firmware/development/logic_analyzer.cpp +++ b/firmware/development/logic_analyzer.cpp @@ -230,4 +230,12 @@ void initWaveAnalyzer(Logging *sharedLogger) { } +void startLogicAnalyzerPins(void) { + +} + +void stopLogicAnalyzerPins(void) { + +} + #endif /* EFI_LOGIC_ANALYZER */ diff --git a/firmware/development/logic_analyzer.h b/firmware/development/logic_analyzer.h index 7dd1e5aab3..3495cfd2b8 100644 --- a/firmware/development/logic_analyzer.h +++ b/firmware/development/logic_analyzer.h @@ -51,6 +51,8 @@ public: }; void initWaveAnalyzer(Logging *sharedLogger); +void startLogicAnalyzerPins(void); +void stopLogicAnalyzerPins(void); void printWave(Logging *logging); void showWaveInfo(void); diff --git a/java_console/autotest/src/com/rusefi/RealHwTest.java b/java_console/autotest/src/com/rusefi/RealHwTest.java index ed9afa87df..8fabd927ac 100644 --- a/java_console/autotest/src/com/rusefi/RealHwTest.java +++ b/java_console/autotest/src/com/rusefi/RealHwTest.java @@ -14,7 +14,7 @@ import static com.devexperts.logging.Logging.getLogging; import static com.rusefi.Timeouts.SECOND; /** - * A few jumper wires are used to test some subsystems as realistically as possible: + * The following jumper wires are used to test some subsystems as realistically as possible: * PD1 <=> PC6 * PD2 <=> PA5 *