From 8859b18e3e7567893a42015d4797ec3c9c731e87 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Sun, 19 Dec 2021 15:57:19 -0500 Subject: [PATCH] fresh take on M73 defaults --- firmware/config/engines/bmw_m73.cpp | 10 +++++++--- firmware/config/engines/bmw_m73_mre.cpp | 15 +-------------- 2 files changed, 8 insertions(+), 17 deletions(-) diff --git a/firmware/config/engines/bmw_m73.cpp b/firmware/config/engines/bmw_m73.cpp index f67f0282cc..f096fc8fba 100644 --- a/firmware/config/engines/bmw_m73.cpp +++ b/firmware/config/engines/bmw_m73.cpp @@ -97,6 +97,7 @@ void m73engine() { engineConfiguration->specs.firingOrder = FO_1_7_5_11_3_9_6_12_2_8_4_10; engineConfiguration->isFasterEngineSpinUpEnabled = true; engineConfiguration->fuelAlgorithm = LM_ALPHA_N; + engineConfiguration->canNbcType = CAN_BUS_NBC_NONE; engineConfiguration->vvtMode[0] = VVT_FIRST_HALF; @@ -106,12 +107,15 @@ void m73engine() { engineConfiguration->trigger.type = TT_60_2_VW; // this large engine seems to crank at around only 150 RPM? And happily idle at 400RPM? - engineConfiguration->cranking.rpm = 280; + engineConfiguration->cranking.rpm = 350; engineConfiguration->ignitionMode = IM_TWO_COILS; - // set cranking_fuel 15 - engineConfiguration->cranking.baseFuel = 30; + // set cranking_fuel x + engineConfiguration->cranking.baseFuel = 40; + + engineConfiguration->crankingTimingAngle = 15; + setTable(config->veTable, 45); engineConfiguration->cylinderBore = 85.0; } diff --git a/firmware/config/engines/bmw_m73_mre.cpp b/firmware/config/engines/bmw_m73_mre.cpp index 91bb74fdf5..69110765fe 100644 --- a/firmware/config/engines/bmw_m73_mre.cpp +++ b/firmware/config/engines/bmw_m73_mre.cpp @@ -66,11 +66,10 @@ #include "fsio_impl.h" void setEngineBMW_M73_microRusEfi() { + m73engine(); // 13641435991 injector engineConfiguration->injector.flow = 180; // cc/min, who knows if this number is real - no good source of info - engineConfiguration->isFasterEngineSpinUpEnabled = true; - strcpy(engineConfiguration->vehicleName, "microRusEFIx2"); engineConfiguration->globalTriggerAngleOffset = 90; @@ -101,7 +100,6 @@ void setEngineBMW_M73_microRusEfi() { #endif /* BOARD_TLE8888_COUNT */ - engineConfiguration->canNbcType = CAN_BUS_NBC_NONE; // set_analog_input_pin pps PA7 // EFI_ADC_7: "31 - AN volt 3" - PA7 engineConfiguration->throttlePedalPositionAdcChannel = EFI_ADC_7; @@ -114,17 +112,6 @@ void setEngineBMW_M73_microRusEfi() { // do I have VR wires flipped? engineConfiguration->trigger.type = TT_60_2_VW; - // this large engine seems to crank at around only 150 RPM? And happily idle at 400RPM? - engineConfiguration->cranking.rpm = 280; - - engineConfiguration->crankingTimingAngle = 30; - - // I am too lazy to add MAP sensor - engineConfiguration->fuelAlgorithm = LM_ALPHA_N; - - // set cranking_fuel 15 - engineConfiguration->cranking.baseFuel = 15; - //set tps_min 891 engineConfiguration->tpsMin = 891; //set tps_max 177