From 905760e84ea1132290b7e406ded29a7ef131aba5 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Wed, 8 Dec 2021 23:18:31 -0500 Subject: [PATCH] docs --- .../main/java/com/rusefi/output/FieldIterator.java | 3 +++ .../src/main/java/com/rusefi/output/TsOutput.java | 12 ++++++++---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/java_tools/configuration_definition/src/main/java/com/rusefi/output/FieldIterator.java b/java_tools/configuration_definition/src/main/java/com/rusefi/output/FieldIterator.java index f433cc8fef..82470f72cf 100644 --- a/java_tools/configuration_definition/src/main/java/com/rusefi/output/FieldIterator.java +++ b/java_tools/configuration_definition/src/main/java/com/rusefi/output/FieldIterator.java @@ -5,6 +5,9 @@ import com.rusefi.ConfigField; import java.util.List; +/** + * custom iterator with references to previous and next elements + */ public class FieldIterator { private final List tsFields; BitState bitState = new BitState(); diff --git a/java_tools/configuration_definition/src/main/java/com/rusefi/output/TsOutput.java b/java_tools/configuration_definition/src/main/java/com/rusefi/output/TsOutput.java index 572832872f..6ea2b84bc3 100644 --- a/java_tools/configuration_definition/src/main/java/com/rusefi/output/TsOutput.java +++ b/java_tools/configuration_definition/src/main/java/com/rusefi/output/TsOutput.java @@ -10,14 +10,18 @@ import java.io.Writer; import static com.rusefi.ToolUtil.EOL; +/** + * Same code is used to generate [Constants] and [OutputChannels] bodies, with just one flag controlling the minor + * difference in behaviours + */ public class TsOutput { private final StringBuilder settingContextHelp = new StringBuilder(); private final ReaderState state; - private final boolean longForm; + private final boolean isConstantsSection; public TsOutput(ReaderState state, boolean longForm) { this.state = state; - this.longForm = longForm; + this.isConstantsSection = longForm; } public StringBuilder getSettingContextHelp() { @@ -49,7 +53,7 @@ public class TsOutput { tsHeader.write(" " + tsPosition + ", ["); tsHeader.write(bitIndex + ":" + bitIndex); tsHeader.write("]"); - if (longForm) + if (isConstantsSection) tsHeader.write(", \"" + configField.getFalseName() + "\", \"" + configField.getTrueName() + "\""); tsHeader.write(EOL); @@ -144,7 +148,7 @@ public class TsOutput { } } StringBuilder sb = new StringBuilder(); - if (!longForm) { + if (!isConstantsSection) { String[] subarray = new String[3]; System.arraycopy(fields, 0, subarray, 0, subarray.length); fields = subarray;