Launch control bug? "range" thing is confusing #4348

bug or dead code? at least making it a bit more obvious
This commit is contained in:
rusefillc 2022-07-20 18:30:20 -04:00
parent 15c81ca90c
commit a03d927638
2 changed files with 5 additions and 1 deletions

View File

@ -103,7 +103,11 @@ void LaunchControlBase::update() {
//and still recalculate in case user changed the values
retardThresholdRpm = engineConfiguration->launchRpm
/*
we never had UI for 'launchAdvanceRpmRange' so it was always zero. are we supposed to forget about this dead line
or it is supposed to be referencing 'launchTimingRpmRange'?
+ (engineConfiguration->enableLaunchRetard ? engineConfiguration->launchAdvanceRpmRange : 0)
*/
+ engineConfiguration->hardCutRpmRange;
if (!combinedConditions) {

View File

@ -959,7 +959,7 @@ bit verboseCan2,"Print all","Do not print";Print incoming and outgoing second bu
int launchFuelAdded;+Extra Fuel Added;"%", 1, 0, 0, 100, 0
int launchBoostDuty;+Duty Cycle for the Boost Solenoid;"%", 1, 0, 0, 100, 0
int hardCutRpmRange;Range from Launch RPM to activate Hard Cut;"RPM", 1, 0, 0, 3000, 0
int launchAdvanceRpmRange;;"rpm", 1, 0, 0, 20000, 0
int unused962
int launchTpsTreshold;;"", 1, 0, 0, 20000, 0
float launchActivateDelay;;"", 1, 0, 0, 20000, 0