From ac9faf66462275e329f687c22e08a4308eb1d90e Mon Sep 17 00:00:00 2001 From: rusefi Date: Sun, 10 May 2020 00:59:32 -0400 Subject: [PATCH] docs & clean-up --- firmware/controllers/algo/engine.cpp | 1 + unit_tests/main.cpp | 3 +-- unit_tests/test_basic_math/test_find_index.h | 10 ---------- unit_tests/tests/tests.mk | 10 +++++----- .../test_cam_vvt_input.cpp} | 2 +- .../tests/{ => trigger}/test_symmetrical_crank.cpp | 0 .../tests/{ => trigger}/test_trigger_decoder.cpp | 0 .../tests/{ => trigger}/test_trigger_multi_sync.cpp | 0 .../tests/{ => trigger}/test_trigger_noiseless.cpp | 0 9 files changed, 8 insertions(+), 18 deletions(-) delete mode 100644 unit_tests/test_basic_math/test_find_index.h rename unit_tests/tests/{test_cam_vtt_input.cpp => trigger/test_cam_vvt_input.cpp} (99%) rename unit_tests/tests/{ => trigger}/test_symmetrical_crank.cpp (100%) rename unit_tests/tests/{ => trigger}/test_trigger_decoder.cpp (100%) rename unit_tests/tests/{ => trigger}/test_trigger_multi_sync.cpp (100%) rename unit_tests/tests/{ => trigger}/test_trigger_noiseless.cpp (100%) diff --git a/firmware/controllers/algo/engine.cpp b/firmware/controllers/algo/engine.cpp index 19a3913f4b..2088044c31 100644 --- a/firmware/controllers/algo/engine.cpp +++ b/firmware/controllers/algo/engine.cpp @@ -251,6 +251,7 @@ void Engine::preCalculate(DECLARE_ENGINE_PARAMETER_SIGNATURE) { #if EFI_TUNER_STUDIO // we take 2 bytes of crc32, no idea if it's right to call it crc16 or not + // we have a hack here - we rely on the fact that engineMake is the first of three relevant fields tsOutputChannels.engineMakeCodeNameCrc16 = crc32(engineConfiguration->engineMake, 3 * VEHICLE_INFO_SIZE); #endif /* EFI_TUNER_STUDIO */ } diff --git a/unit_tests/main.cpp b/unit_tests/main.cpp index fbceeed41b..0f34293b30 100644 --- a/unit_tests/main.cpp +++ b/unit_tests/main.cpp @@ -9,7 +9,6 @@ #include #include "global.h" -#include "test_find_index.h" #include "engine_configuration.h" @@ -40,7 +39,7 @@ GTEST_API_ int main(int argc, char **argv) { // printTriggerDebug = true; // resizeMap(); - printf("Success 20200131\r\n"); + printf("Success 20200510\r\n"); printAllTriggers(); // printConvertedTable(); testing::InitGoogleTest(&argc, argv); diff --git a/unit_tests/test_basic_math/test_find_index.h b/unit_tests/test_basic_math/test_find_index.h deleted file mode 100644 index 850649e01c..0000000000 --- a/unit_tests/test_basic_math/test_find_index.h +++ /dev/null @@ -1,10 +0,0 @@ -/* - * test_find_index.h - * - * Created on: Oct 30, 2013 - * @author Andrey Belomutskiy, (c) 2012-2020 - */ - -#pragma once - -void testFindIndex(void); diff --git a/unit_tests/tests/tests.mk b/unit_tests/tests/tests.mk index 9927a08885..d7571c22e5 100644 --- a/unit_tests/tests/tests.mk +++ b/unit_tests/tests/tests.mk @@ -1,20 +1,21 @@ TESTS_SRC_CPP = \ + tests/trigger/test_symmetrical_crank.cpp \ + tests/trigger/test_trigger_decoder.cpp \ + tests/trigger/test_trigger_noiseless.cpp \ + tests/trigger/test_trigger_multi_sync.cpp \ + tests/trigger/test_cam_vvt_input.cpp \ tests/test_util.cpp \ tests/test_ion.cpp \ tests/test_aux_valves.cpp \ tests/test_on_demand_parameters.cpp \ tests/test_hip9011.cpp \ tests/test_cj125.cpp \ - tests/test_cam_vtt_input.cpp \ tests/test_engine_math.cpp \ tests/test_startOfCrankingPrimingPulse.cpp \ tests/test_miata_na6_real_cranking.cpp \ tests/test_fasterEngineSpinningUp.cpp \ tests/test_dwell_corner_case_issue_796.cpp \ - tests/test_symmetrical_crank.cpp \ tests/test_idle_controller.cpp \ - tests/test_trigger_decoder.cpp \ - tests/test_trigger_noiseless.cpp \ tests/test_issue_898.cpp \ tests/test_etb.cpp \ tests/test_ignition_scheduling.cpp \ @@ -23,7 +24,6 @@ TESTS_SRC_CPP = \ tests/test_one_cylinder_logic.cpp \ tests/test_maf2map.cpp \ tests/test_fuelCut.cpp \ - tests/test_trigger_multi_sync.cpp \ tests/test_pwm_generator.cpp \ tests/test_logic_expression.cpp \ tests/test_speed_density.cpp \ diff --git a/unit_tests/tests/test_cam_vtt_input.cpp b/unit_tests/tests/trigger/test_cam_vvt_input.cpp similarity index 99% rename from unit_tests/tests/test_cam_vtt_input.cpp rename to unit_tests/tests/trigger/test_cam_vvt_input.cpp index 1add03ace1..3e53065410 100644 --- a/unit_tests/tests/test_cam_vtt_input.cpp +++ b/unit_tests/tests/trigger/test_cam_vvt_input.cpp @@ -1,5 +1,5 @@ /* - * test_cam_vtt_input.cpp + * test_cam_vvt_input.cpp * * Created on: Jan 13, 2019 * @author Andrey Belomutskiy, (c) 2012-2020 diff --git a/unit_tests/tests/test_symmetrical_crank.cpp b/unit_tests/tests/trigger/test_symmetrical_crank.cpp similarity index 100% rename from unit_tests/tests/test_symmetrical_crank.cpp rename to unit_tests/tests/trigger/test_symmetrical_crank.cpp diff --git a/unit_tests/tests/test_trigger_decoder.cpp b/unit_tests/tests/trigger/test_trigger_decoder.cpp similarity index 100% rename from unit_tests/tests/test_trigger_decoder.cpp rename to unit_tests/tests/trigger/test_trigger_decoder.cpp diff --git a/unit_tests/tests/test_trigger_multi_sync.cpp b/unit_tests/tests/trigger/test_trigger_multi_sync.cpp similarity index 100% rename from unit_tests/tests/test_trigger_multi_sync.cpp rename to unit_tests/tests/trigger/test_trigger_multi_sync.cpp diff --git a/unit_tests/tests/test_trigger_noiseless.cpp b/unit_tests/tests/trigger/test_trigger_noiseless.cpp similarity index 100% rename from unit_tests/tests/test_trigger_noiseless.cpp rename to unit_tests/tests/trigger/test_trigger_noiseless.cpp