From b41ca74386e94aab4fd8d76b7d598cc5bf2c15a8 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Fri, 11 Dec 2020 12:50:10 -0500 Subject: [PATCH] clang warnings again #2055 --- firmware/controllers/algo/engine.h | 4 ++-- firmware/controllers/sensors/sensor.h | 2 +- firmware/util/os_util.c | 17 ----------------- firmware/util/os_util.h | 5 ----- 4 files changed, 3 insertions(+), 25 deletions(-) diff --git a/firmware/controllers/algo/engine.h b/firmware/controllers/algo/engine.h index fc361bd071..9e77022dd9 100644 --- a/firmware/controllers/algo/engine.h +++ b/firmware/controllers/algo/engine.h @@ -52,8 +52,8 @@ class AirmassModelBase; #define CYCLE_ALTERNATION 2 class IEtbController; -class IFuelComputer; -class IInjectorModel; +struct IFuelComputer; +struct IInjectorModel; class PrimaryTriggerConfiguration final : public TriggerConfiguration { public: diff --git a/firmware/controllers/sensors/sensor.h b/firmware/controllers/sensors/sensor.h index e21b4b08c7..5ee1d88bb6 100644 --- a/firmware/controllers/sensors/sensor.h +++ b/firmware/controllers/sensors/sensor.h @@ -55,7 +55,7 @@ using SensorResult = expected; // Fwd declare - nobody outside of Sensor.cpp needs to see inside this type -struct SensorRegistryEntry; +class SensorRegistryEntry; class Logging; class Sensor { diff --git a/firmware/util/os_util.c b/firmware/util/os_util.c index d533a6d4fe..3bbb39f0bf 100644 --- a/firmware/util/os_util.c +++ b/firmware/util/os_util.c @@ -41,20 +41,3 @@ void chVTSetAny(virtual_timer_t *vtp, systime_t time, vtfunc_t vtfunc, void *par } #endif /* EFI_UNIT_TEST */ - -/** - * See also getRemainingStack() - */ -int getMaxUsedStack(uint8_t *ptr, int size) { - /** - * maximum used stack size total stack buffer size minus position of first modified byte - */ -#if ! EFI_UNIT_TEST - for (int i = 0; i < size; i++) { - if (ptr[i] != CH_DBG_STACK_FILL_VALUE) { - return size - i; - } - } -#endif /* EFI_UNIT_TEST */ - return 0; -} diff --git a/firmware/util/os_util.h b/firmware/util/os_util.h index 3124dc599e..4d1d502016 100644 --- a/firmware/util/os_util.h +++ b/firmware/util/os_util.h @@ -10,11 +10,6 @@ #include "global.h" -/** - * @return for a given stack memory region returns how much stack was ever used - */ -int getMaxUsedStack(uint8_t *ptr, int size); - #if !EFI_UNIT_TEST #include "histogram.h"