From b99d90b006f4461f0537960e20454c8982bd806c Mon Sep 17 00:00:00 2001 From: Matthew Kennedy Date: Thu, 21 Jul 2022 12:17:32 -0700 Subject: [PATCH] Start -> start (#4366) --- firmware/console/binary/ts_can_channel.cpp | 2 +- .../console/binary/tunerstudio_io_serial_ports.cpp | 4 ++-- firmware/console/ethernet_console.cpp | 2 +- firmware/console/status_loop.cpp | 4 ++-- firmware/console/usb_console.cpp | 2 +- firmware/controllers/actuators/electronic_throttle.cpp | 2 +- firmware/controllers/actuators/vvt.cpp | 2 +- firmware/controllers/bench_test.cpp | 2 +- firmware/controllers/engine_controller.cpp | 6 +++--- firmware/controllers/gauges/malfunction_indicator.cpp | 2 +- firmware/controllers/lua/lua.cpp | 2 +- firmware/controllers/sensors/software_knock.cpp | 2 +- firmware/controllers/system/periodic_task.h | 2 +- firmware/controllers/system/thread_controller.h | 2 +- firmware/hw_layer/adc/adc_inputs.cpp | 2 +- firmware/hw_layer/drivers/can/can_hw.cpp | 10 +++++----- firmware/hw_layer/drivers/serial/serial_hw.cpp | 2 +- firmware/hw_layer/mass_storage/mass_storage_init.cpp | 2 +- .../hw_layer/microsecond_timer/microsecond_timer.cpp | 2 +- firmware/hw_layer/stepper.cpp | 2 +- firmware/util/loggingcentral.cpp | 2 +- misc/stm32f1_test_project/timer/microsecond_timer.cpp | 2 +- 22 files changed, 30 insertions(+), 30 deletions(-) diff --git a/firmware/console/binary/ts_can_channel.cpp b/firmware/console/binary/ts_can_channel.cpp index 278637d1d5..f3a357e06b 100644 --- a/firmware/console/binary/ts_can_channel.cpp +++ b/firmware/console/binary/ts_can_channel.cpp @@ -102,7 +102,7 @@ struct CanTsThread : public TunerstudioThread { static CanTsThread canTsThread; void startCanConsole() { - canTsThread.Start(); + canTsThread.start(); canStreamInit(); } diff --git a/firmware/console/binary/tunerstudio_io_serial_ports.cpp b/firmware/console/binary/tunerstudio_io_serial_ports.cpp index 35243dfbca..2245bc4d5d 100644 --- a/firmware/console/binary/tunerstudio_io_serial_ports.cpp +++ b/firmware/console/binary/tunerstudio_io_serial_ports.cpp @@ -93,12 +93,12 @@ void startSerialChannels() { #if HAS_PRIMARY // todo: invert setting one day? if (!engineConfiguration->disablePrimaryUart) { - primaryChannelThread.Start(); + primaryChannelThread.start(); } #endif #if HAS_SECONDARY - secondaryChannelThread.Start(); + secondaryChannelThread.start(); #endif } diff --git a/firmware/console/ethernet_console.cpp b/firmware/console/ethernet_console.cpp index 8c0957908c..f734a3f5de 100644 --- a/firmware/console/ethernet_console.cpp +++ b/firmware/console/ethernet_console.cpp @@ -98,7 +98,7 @@ void startEthernetConsole() { efiSetPadMode("ethernet", Gpio::G14, PAL_MODE_ALTERNATE(0xb)); #endif // STM32H7 - ethernetConsole.Start(); + ethernetConsole.start(); } #endif // EFI_ETHERNET diff --git a/firmware/console/status_loop.cpp b/firmware/console/status_loop.cpp index 3f81c8eaca..0df10ee4d1 100644 --- a/firmware/console/status_loop.cpp +++ b/firmware/console/status_loop.cpp @@ -934,10 +934,10 @@ void startStatusThreads(void) { // todo: refactoring needed, this file should probably be split into pieces #if EFI_PROD_CODE initStatusLeds(); - communicationsBlinkingTask.Start(); + communicationsBlinkingTask.start(); #endif /* EFI_PROD_CODE */ #if EFI_LCD - lcdInstance.Start(); + lcdInstance.start(); #endif /* EFI_LCD */ } diff --git a/firmware/console/usb_console.cpp b/firmware/console/usb_console.cpp index 7b6fa32d4e..cc57b85de4 100644 --- a/firmware/console/usb_console.cpp +++ b/firmware/console/usb_console.cpp @@ -51,7 +51,7 @@ struct UsbThread : public TunerstudioThread { static UsbThread usbConsole; void startUsbConsole() { - usbConsole.Start(); + usbConsole.start(); } #endif // EFI_USB_SERIAL diff --git a/firmware/controllers/actuators/electronic_throttle.cpp b/firmware/controllers/actuators/electronic_throttle.cpp index a7f3999598..2c10bd5a27 100644 --- a/firmware/controllers/actuators/electronic_throttle.cpp +++ b/firmware/controllers/actuators/electronic_throttle.cpp @@ -1008,7 +1008,7 @@ void doInitElectronicThrottle() { #endif /* EFI_UNIT_TEST */ #if !EFI_UNIT_TEST - etbThread.Start(); + etbThread.start(); #endif } diff --git a/firmware/controllers/actuators/vvt.cpp b/firmware/controllers/actuators/vvt.cpp index 95be6a7d7d..4ecd760e48 100644 --- a/firmware/controllers/actuators/vvt.cpp +++ b/firmware/controllers/actuators/vvt.cpp @@ -156,7 +156,7 @@ void initAuxPid() { startVvtControlPins(); for (int i = 0;i < CAM_INPUTS_COUNT;i++) { - instances[i].Start(); + instances[i].start(); } } diff --git a/firmware/controllers/bench_test.cpp b/firmware/controllers/bench_test.cpp index 91386814bc..43308e9409 100644 --- a/firmware/controllers/bench_test.cpp +++ b/firmware/controllers/bench_test.cpp @@ -574,7 +574,7 @@ void initBenchTest() { addConsoleActionFFFFF("luabench2", luaOutBench2); instance.setPeriod(200 /*ms*/); - instance.Start(); + instance.start(); onConfigurationChangeBenchTest(); } diff --git a/firmware/controllers/engine_controller.cpp b/firmware/controllers/engine_controller.cpp index 05a462c684..b89fcae5c6 100644 --- a/firmware/controllers/engine_controller.cpp +++ b/firmware/controllers/engine_controller.cpp @@ -237,8 +237,8 @@ static void doPeriodicSlowCallback() { } void initPeriodicEvents() { - slowController.Start(); - fastController.Start(); + slowController.start(); + fastController.start(); } char * getPinNameByAdcChannel(const char *msg, adc_channel_e hwChannel, char *buffer) { @@ -697,7 +697,7 @@ void initEngineContoller() { return; } - engineStateBlinkingTask.Start(); + engineStateBlinkingTask.start(); initVrPwm(); diff --git a/firmware/controllers/gauges/malfunction_indicator.cpp b/firmware/controllers/gauges/malfunction_indicator.cpp index fcf3fbacf2..572b5ecce7 100644 --- a/firmware/controllers/gauges/malfunction_indicator.cpp +++ b/firmware/controllers/gauges/malfunction_indicator.cpp @@ -122,7 +122,7 @@ void initMalfunctionIndicator(void) { return; } instance.setPeriod(10 /*ms*/); - instance.Start(); + instance.start(); #if TEST_MIL_CODE addConsoleAction("testmil", testMil); diff --git a/firmware/controllers/lua/lua.cpp b/firmware/controllers/lua/lua.cpp index 682ac2c157..b6c4ccab0e 100644 --- a/firmware/controllers/lua/lua.cpp +++ b/firmware/controllers/lua/lua.cpp @@ -352,7 +352,7 @@ void startLua() { initLuaCanRx(); #endif // EFI_CAN_SUPPORT - luaThread.Start(); + luaThread.start(); addConsoleActionS("lua", [](const char* str){ if (interactivePending) { diff --git a/firmware/controllers/sensors/software_knock.cpp b/firmware/controllers/sensors/software_knock.cpp index 315278eb88..52f0309c8b 100644 --- a/firmware/controllers/sensors/software_knock.cpp +++ b/firmware/controllers/sensors/software_knock.cpp @@ -150,7 +150,7 @@ void initSoftwareKnock() { #if KNOCK_HAS_CH2 efiSetPadMode("knock ch2", KNOCK_PIN_CH2, PAL_MODE_INPUT_ANALOG); #endif - kt.Start(); + kt.start(); } } diff --git a/firmware/controllers/system/periodic_task.h b/firmware/controllers/system/periodic_task.h index 56b7967fb1..e4701c3ff2 100644 --- a/firmware/controllers/system/periodic_task.h +++ b/firmware/controllers/system/periodic_task.h @@ -35,7 +35,7 @@ public: /** * This invokes PeriodicTask() immediately and starts the cycle of invocations and sleeps */ - virtual void Start() { + virtual void start() { #if !EFI_UNIT_TEST chVTObjectInit(&timer); #endif // EFI_UNIT_TEST diff --git a/firmware/controllers/system/thread_controller.h b/firmware/controllers/system/thread_controller.h index 09272c0cf6..a7325f23a5 100644 --- a/firmware/controllers/system/thread_controller.h +++ b/firmware/controllers/system/thread_controller.h @@ -55,7 +55,7 @@ public: /** * @brief Start the thread. */ - void Start() + void start() { if (m_isStarted) { warning(CUSTOM_OBD_6003, "Tried to start thread %s but it was already running", m_name); diff --git a/firmware/hw_layer/adc/adc_inputs.cpp b/firmware/hw_layer/adc/adc_inputs.cpp index 2f212d0c0b..27b045c734 100644 --- a/firmware/hw_layer/adc/adc_inputs.cpp +++ b/firmware/hw_layer/adc/adc_inputs.cpp @@ -460,7 +460,7 @@ void initAdcInputs() { portInitAdc(); // Start the slow ADC thread - slowAdcController.Start(); + slowAdcController.start(); #if EFI_USE_FAST_ADC fastAdc.init(); diff --git a/firmware/hw_layer/drivers/can/can_hw.cpp b/firmware/hw_layer/drivers/can/can_hw.cpp index 4e62a8178a..8a42763e6b 100644 --- a/firmware/hw_layer/drivers/can/can_hw.cpp +++ b/firmware/hw_layer/drivers/can/can_hw.cpp @@ -139,11 +139,11 @@ public: { } - void Start(CANDriver* device) { + void start(CANDriver* device) { m_device = device; if (device) { - ThreadController::Start(); + ThreadController::start(); } } @@ -318,12 +318,12 @@ void initCan() { // fire up threads, as necessary if (engineConfiguration->canWriteEnabled) { - canWrite.Start(); + canWrite.start(); } if (engineConfiguration->canReadEnabled) { - canRead1.Start(device1); - canRead2.Start(device2); + canRead1.start(device1); + canRead2.start(device2); } isCanEnabled = true; diff --git a/firmware/hw_layer/drivers/serial/serial_hw.cpp b/firmware/hw_layer/drivers/serial/serial_hw.cpp index b11723d386..1a2cc59238 100644 --- a/firmware/hw_layer/drivers/serial/serial_hw.cpp +++ b/firmware/hw_layer/drivers/serial/serial_hw.cpp @@ -85,7 +85,7 @@ void initAuxSerial(void) { startAuxSerialPins(); if (isSerialRXEnabled) - serialRead.Start(); + serialRead.start(); } #endif // EFI_AUX_SERIAL diff --git a/firmware/hw_layer/mass_storage/mass_storage_init.cpp b/firmware/hw_layer/mass_storage/mass_storage_init.cpp index e4f2668a65..04e0d411b5 100644 --- a/firmware/hw_layer/mass_storage/mass_storage_init.cpp +++ b/firmware/hw_layer/mass_storage/mass_storage_init.cpp @@ -117,7 +117,7 @@ void initUsbMsd() { msd.attachLun(1, (BaseBlockDevice*)&ND1, blkbuf1, &sdCardInquiry, nullptr); // start the mass storage thread - msd.Start(); + msd.start(); } #endif // HAL_USE_USB_MSD diff --git a/firmware/hw_layer/microsecond_timer/microsecond_timer.cpp b/firmware/hw_layer/microsecond_timer/microsecond_timer.cpp index aa95bdc315..caf879ce3c 100644 --- a/firmware/hw_layer/microsecond_timer/microsecond_timer.cpp +++ b/firmware/hw_layer/microsecond_timer/microsecond_timer.cpp @@ -177,7 +177,7 @@ void initMicrosecondTimer() { watchDogBuddyCallback(NULL); #if EFI_EMULATE_POSITION_SENSORS - watchdogControllerInstance.Start(); + watchdogControllerInstance.start(); #endif /* EFI_EMULATE_POSITION_SENSORS */ } diff --git a/firmware/hw_layer/stepper.cpp b/firmware/hw_layer/stepper.cpp index 1f149a7955..6c8661eeaa 100644 --- a/firmware/hw_layer/stepper.cpp +++ b/firmware/hw_layer/stepper.cpp @@ -209,7 +209,7 @@ bool StepDirectionStepper::step(bool positive) { void StepperMotor::initialize(StepperHw *hardware, int totalSteps) { StepperMotorBase::initialize(hardware, totalSteps); - Start(); + start(); } void StepDirectionStepper::initialize(brain_pin_e stepPin, brain_pin_e directionPin, pin_output_mode_e directionPinMode, float reactionTime, brain_pin_e enablePin, pin_output_mode_e enablePinMode) { diff --git a/firmware/util/loggingcentral.cpp b/firmware/util/loggingcentral.cpp index c8be4f937d..5a62952187 100644 --- a/firmware/util/loggingcentral.cpp +++ b/firmware/util/loggingcentral.cpp @@ -160,7 +160,7 @@ void startLoggingProcessor() { } // Start processing used buffers - lbf.Start(); + lbf.start(); } #endif // EFI_PROD_CODE diff --git a/misc/stm32f1_test_project/timer/microsecond_timer.cpp b/misc/stm32f1_test_project/timer/microsecond_timer.cpp index 157b72dde3..e7d9994a15 100644 --- a/misc/stm32f1_test_project/timer/microsecond_timer.cpp +++ b/misc/stm32f1_test_project/timer/microsecond_timer.cpp @@ -177,7 +177,7 @@ void initMicrosecondTimer() { watchDogBuddyCallback(NULL); #if EFI_EMULATE_POSITION_SENSORS - watchdogControllerInstance.Start(); + watchdogControllerInstance.start(); #endif /* EFI_EMULATE_POSITION_SENSORS */ }