From d47afe05242e10b1a54a6983f3147815d0902cdd Mon Sep 17 00:00:00 2001
From: rusefi <rusefillc@gmail.com>
Date: Fri, 11 Jan 2019 01:18:35 -0500
Subject: [PATCH] better field name

---
 unit_tests/tests/test_engine_math.cpp                 | 4 ++--
 unit_tests/tests/test_startOfCrankingPrimingPulse.cpp | 4 ++--
 unit_tests/tests/test_trigger_decoder.cpp             | 4 ++--
 unit_tests/tests/test_trigger_noiseless.cpp           | 3 ---
 4 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/unit_tests/tests/test_engine_math.cpp b/unit_tests/tests/test_engine_math.cpp
index 01aa904e2e..1e8b0d791a 100644
--- a/unit_tests/tests/test_engine_math.cpp
+++ b/unit_tests/tests/test_engine_math.cpp
@@ -102,8 +102,8 @@ void testMafLookup(void) {
 	assertEqualsM("@255", 738, engine->mafDecodingLookup[255]);
 }
 
-float unitTestValue = 0;
+float mockMapValue = 0;
 
 float getMap(void) {
-	return unitTestValue;
+	return mockMapValue;
 }
diff --git a/unit_tests/tests/test_startOfCrankingPrimingPulse.cpp b/unit_tests/tests/test_startOfCrankingPrimingPulse.cpp
index 4d0ac9fa4b..d2126f70ae 100644
--- a/unit_tests/tests/test_startOfCrankingPrimingPulse.cpp
+++ b/unit_tests/tests/test_startOfCrankingPrimingPulse.cpp
@@ -22,12 +22,12 @@ void testPlainCrankingWithoutAdvancedFeatures() {
 	setupSimpleTestEngineWithMafAndTT_ONE_trigger(&eth);
 	assertEqualsM("RPM=0", 0, engine->rpmCalculator.getRpm(PASS_ENGINE_PARAMETER_SIGNATURE));
 
-	eth.fireTriggerEventsWithDuration(200);
+	eth.fireTriggerEventsWithDuration(/* durationMs */ 200);
 	// still no RPM since need to cycles measure cycle duration
 	assertEqualsM("RPM#1", 0, engine->rpmCalculator.getRpm(PASS_ENGINE_PARAMETER_SIGNATURE));
 
 
-	eth.fireRise(200);
+	eth.fireRise(/* delayMs */ 200);
 	assertEqualsM("RPM#2", 300, engine->rpmCalculator.getRpm(PASS_ENGINE_PARAMETER_SIGNATURE));
 	// two simultaneous injections
 	assertEqualsM("plain#2", 4, engine->executor.size());
diff --git a/unit_tests/tests/test_trigger_decoder.cpp b/unit_tests/tests/test_trigger_decoder.cpp
index 7cc941b4e5..ae517cc4fb 100644
--- a/unit_tests/tests/test_trigger_decoder.cpp
+++ b/unit_tests/tests/test_trigger_decoder.cpp
@@ -32,7 +32,7 @@
 #include "trigger_universal.h"
 
 extern int timeNowUs;
-extern float unitTestValue;
+extern float mockMapValue;
 extern float testMafValue;
 extern int unitTestWarningCounter;
 extern bool printTriggerDebug;
@@ -984,7 +984,7 @@ void testFuelSchedulerBug299smallAndMedium(void) {
 
 	eth.executeActions();
 
-	unitTestValue = 0;
+	mockMapValue = 0;
 	testMafValue = 0;
 }
 
diff --git a/unit_tests/tests/test_trigger_noiseless.cpp b/unit_tests/tests/test_trigger_noiseless.cpp
index 3252a9dc2d..a62a150842 100644
--- a/unit_tests/tests/test_trigger_noiseless.cpp
+++ b/unit_tests/tests/test_trigger_noiseless.cpp
@@ -22,9 +22,6 @@
 #include "trigger_universal.h"
 
 extern int timeNowUs;
-extern float unitTestValue;
-extern float testMafValue;
-extern int unitTestWarningCounter;
 extern bool printTriggerDebug;
 extern float actualSynchGap;