From e29911114a9f03d295a7cac8e4b573022be77252 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Wed, 18 Nov 2020 20:01:02 -0500 Subject: [PATCH] Starter seems to be engaged forever #1965 --- firmware/controllers/actuators/idle_thread.cpp | 6 ------ unit_tests/tests/test_idle_controller.cpp | 4 ---- 2 files changed, 10 deletions(-) diff --git a/firmware/controllers/actuators/idle_thread.cpp b/firmware/controllers/actuators/idle_thread.cpp index 8af0120db2..94b81b97b0 100644 --- a/firmware/controllers/actuators/idle_thread.cpp +++ b/firmware/controllers/actuators/idle_thread.cpp @@ -50,10 +50,6 @@ static Logging *logger; EXTERN_ENGINE; -#if EFI_UNIT_TEST - Engine *unitTestEngine; -#endif - // todo: move all static vars to engine->engineState.idle? static bool shouldResetPid = false; @@ -74,7 +70,6 @@ class PidWithOverrides : public PidIndustrial { public: float getOffset() const override { #if EFI_UNIT_TEST - Engine *engine = unitTestEngine; EXPAND_Engine; #endif float result = parameters->offset; @@ -88,7 +83,6 @@ public: float getMinValue() const override { #if EFI_UNIT_TEST - Engine *engine = unitTestEngine; EXPAND_Engine; #endif float result = parameters->minValue; diff --git a/unit_tests/tests/test_idle_controller.cpp b/unit_tests/tests/test_idle_controller.cpp index 0ccdbc3366..2b189861cd 100644 --- a/unit_tests/tests/test_idle_controller.cpp +++ b/unit_tests/tests/test_idle_controller.cpp @@ -19,13 +19,9 @@ extern IdleController idleControllerInstance; extern int timeNowUs; -extern Engine *unitTestEngine; - TEST(idle, fsioPidParameters) { WITH_ENGINE_TEST_HELPER(MIATA_NA6_MAP); - unitTestEngine = engine; - engineConfiguration->idleRpmPid.offset = 40; engineConfiguration->acIdleExtraOffset = 10;