Stack usage is still all over the place #1662

firmware/console/eficonsole.cpp

@@ -21,7 +21,7 @@
  * If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "global.h"
+#include "globalaccess.h"
 #include "os_access.h"
 #include "eficonsole.h"
 #include "console_io.h"

firmware/controllers/global_shared.h

@@ -92,3 +92,11 @@
 #define EXPECTED_REMAINING_STACK 128
 
 #endif /* __cplusplus */
+
+/*
+ * Stack debugging
+ * See also getMaxUsedStack()
+ */
+EXTERNC int getRemainingStack(thread_t *otp);
+int CountFreeStackSpace(const void* wabase);
+void validateStack(const char*msg, obd_code_e code, int stackUnusedSize);

firmware/os_access.h

@@ -24,12 +24,4 @@ extern "C"
 
 #include "io_pins.h"
 
-/*
- * Stack debugging
- * See also getMaxUsedStack()
- */
-EXTERNC int getRemainingStack(thread_t *otp);
-int CountFreeStackSpace(const void* wabase);
-void validateStack(const char*msg, obd_code_e code, int stackUnusedSize);
-
 #define HAS_OS_ACCESS

firmware/util/datalogging.cpp

@@ -30,7 +30,7 @@
  *
  */
 
-#include "global.h"
+#include "globalaccess.h"
 
 #if ! EFI_UNIT_TEST
 #include "os_access.h"