From f5b0094ed31f15940c0b0c1d604fdec95a62c3bd Mon Sep 17 00:00:00 2001 From: rusefillc Date: Fri, 15 Apr 2022 22:56:23 -0400 Subject: [PATCH] docs --- firmware/controllers/core/engine_module.h | 2 +- firmware/integration/rusefi_config.txt | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/firmware/controllers/core/engine_module.h b/firmware/controllers/core/engine_module.h index 09aab74220..3444863ae0 100644 --- a/firmware/controllers/core/engine_module.h +++ b/firmware/controllers/core/engine_module.h @@ -2,7 +2,7 @@ class EngineModule { public: - // Called when the engine_configuration_s part of the tune has changed. + // Called when 'Burn' is invoked virtual void onConfigurationChange(engine_configuration_s const * /*previousConfig*/) { } // Called approx 20Hz diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt index 3c98089108..164778d289 100644 --- a/firmware/integration/rusefi_config.txt +++ b/firmware/integration/rusefi_config.txt @@ -49,6 +49,13 @@ ! type name;comment ! ! +! +! Q: what's the difference between 'engineConfiguration' and rest of the 'persistent_config_s'? +! A: 'engineConfiguration' portion has 'activeConfiguration' copy so that we can detect changes +! todo: move all curves and tables out of engineConfiguration that would make 'activeConfiguration' smaller and we might save a couple of K of ram +! +! +! ! Q: What is "@OFFSET@"? ! A: That's a template placeholder for field offset within the resulting data structure. !