a few unneeded properties

This commit is contained in:
rusefi 2020-06-13 22:46:10 -04:00
parent 1a645bda1a
commit fc5dd7d0c3
5 changed files with 7 additions and 14 deletions

View File

@ -228,6 +228,7 @@ static systime_t timeOfPreviousReport = (systime_t) -1;
* @brief Sends all pending data to rusEfi console
*
* This method is periodically invoked by the main loop
* todo: is this mostly dead code?
*/
void updateDevConsoleState(void) {
// todo: make SWO work
@ -443,7 +444,7 @@ public:
private:
void PeriodicTask(efitick_t nowNt) override {
UNUSED(nowNt);
setPeriod(NOT_TOO_OFTEN(10 /* ms */, engineConfiguration->lcdThreadPeriodMs));
setPeriod(NOT_TOO_OFTEN(10 /* ms */, 300));
if (engineConfiguration->useLcdScreen) {
#if EFI_HD44780_LCD
updateHD44780lcd();

View File

@ -1062,10 +1062,6 @@ static void setDefaultEngineConfiguration(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
engineConfiguration->mapErrorDetectionTooLow = 5;
engineConfiguration->mapErrorDetectionTooHigh = 250;
engineConfiguration->idleThreadPeriodMs = 100;
engineConfiguration->consoleLoopPeriodMs = 200;
engineConfiguration->lcdThreadPeriodMs = 300;
engineConfiguration->generalPeriodicThreadPeriodMs = 50;
engineConfiguration->useLcdScreen = true;
engineConfiguration->hip9011Gain = 1;

View File

@ -152,9 +152,8 @@ class PeriodicSlowController : public PeriodicTimerController {
}
int getPeriodMs() override {
// we need at least protection from zero value while resetting configuration
int periodMs = maxI(50, CONFIG(generalPeriodicThreadPeriodMs));
return periodMs;
// no reason to have this configurable, looks like everyone is happy with 20Hz
return 50;
}
};

View File

@ -669,11 +669,7 @@ custom adc_channel_mode_e 4 bits, U32, @OFFSET@, [0:7], "Off", "Slow", "Fas
pin_input_mode_e throttlePedalUpPinMode;
uint8_t unused711;
int idleThreadPeriodMs;
int consoleLoopPeriodMs;
int lcdThreadPeriodMs;
int generalPeriodicThreadPeriodMs;
int[4] unusedAt712;
uint32_t tunerStudioSerialSpeed;Secondary TTL channel baud rate;"BPs", 1, 0, 0,1000000, 0

View File

@ -244,10 +244,11 @@ void runRusEfi(void) {
#if EFI_CLI_SUPPORT && !EFI_UART_ECHO_TEST_MODE
// sensor state + all pending messages for our own rusEfi console
// todo: is this mostly dead code?
updateDevConsoleState();
#endif /* EFI_CLI_SUPPORT */
chThdSleepMilliseconds(CONFIG(consoleLoopPeriodMs));
chThdSleepMilliseconds(200);
}
}