89f92e1694
why so many channels are hidden in debug ? #3614
2021-11-29 11:54:55 -05:00
98040ad9af
Make the module API more concise. ( #3571 )
...
engineModules.get<FOO>(). becomes modules<FOO>()->
I believe the new API is more conducive to supporting arrays, by doing std::array<T, N> or
std::array<Mockable<T>, N>, with the support of a helper class.
2021-11-17 21:50:00 -05:00
69d36dad6e
Final cleanup of ENGINE macros ( #3567 )
...
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
988aacdd91
Create a base class EngineModule for that contains various useful callbacks. ( #3548 )
...
* Create a base class EngineModule for that contains various useful callbacks.
This cleans up the API by not requiring the notifiers to know about who wants callbacks. The only
place you need to update to add a module is in one place.
* Add mockability.
* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
8cdac4cac0
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
928c673695
refactoring launch
2021-11-15 20:09:03 -05:00
75a2b5ef02
Knock retard ( #3396 )
...
* output gauge
* knock controller
* don't need that
* inject engine ref
* test knock
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-01 23:33:59 -04:00
d917cc8cc2
[DRAFT] Fix cranking->idling taper phase for useSeparate*ForIdle tables ( #3168 )
...
* Rename Phase::CrankToRunTaper -> CrankToIdleTaper
* Change isIdling() to isIdlingOrTaper()
* test_idle_controller.cpp
* useSeparateIdleTablesForCrankingTaper setting
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2021-10-06 12:05:20 -04:00
b4884498cb
OBD error renames
2021-10-03 01:30:42 -04:00
063ab4af35
dead FSIO
2021-08-14 11:52:41 -04:00
b52d50bbf2
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
2ce7777865
don't require EXTERN_ENGINE in every file ( #2969 )
...
* move enginePins
* no more extern engine
* uses
* more
* extern config too
* put this where it belongs
* include correct header
* merge
2021-07-16 18:13:33 -04:00
e7f17b0365
move ign & cranking defaults ( #2791 )
...
* ignition defaults
* cranking
* s
2021-06-03 14:40:19 -04:00
3ef969d743
warnings & assorted cleanup ( #2793 )
...
* lua hook
* validateBuffer
* tables
* simplify fsio table
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-03 14:30:25 -04:00
ab214f974c
Bandaid for 2735 ( #2788 )
...
* bandaid
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-02 12:02:52 +03:00
790ac08a2e
Cranking defaults ( #2787 )
...
* defaults
* more
* cranking fuel
* cranking timing
* cranking time digits
* ugh these tests shouldn't depend on defaults
2021-06-02 08:21:36 +03:00
590f5e4f99
cranking timing not costant #2733
2021-05-23 13:54:49 -04:00
dd6105cfa3
shrink canned tables ( #2651 )
...
* helper
* use it miata
* do type safe copy
* miata vvt
* etb
* default iat correction
* magic is afoot here
* hunchback
* misc
* neon
* neon
* aspire
* citroen
* neon
* missed one
* dead
* festiva
* remove andreyism
* very dead
* no need for copy of that function
* cleanup
2021-05-09 14:37:16 -04:00
8b3aa6c40d
goodbye ignitionOffset ( #2503 )
...
* remove
* set the timing map to do what the offset used to do
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-28 08:00:09 -04:00
4a1d3de9a6
remove unused msg parameter ( #2360 )
...
* dead parameter
* last few
2021-02-16 09:32:16 -05:00
868f0d47ac
Enable idle timing/ve tables based on idle phase logic ( #2213 )
...
* add helper
* advance
* ve
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-11 00:54:37 -05:00
7a90692187
Idle timing uses phase logic, remove falloff ( #2169 )
...
* use phase computation
* move & simplify implementation
* test
* bad merge
* initialize
* wonderful changelog
* now unused parameter
* put back deadzone
* ui
* test deadzone
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-07 08:06:36 -05:00
46583b2a19
Revert "Idle timing PID uses phase logic ( #2156 )"
...
This reverts commit 9634a803
2020-12-31 12:22:54 -05:00
9634a803f1
Idle timing PID uses phase logic ( #2156 )
...
* use phase computation
* move & simplify implementation
* test
* bad merge
* initialize
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-29 23:50:56 -05:00
aeea50ada2
move target computation ( #2091 )
2020-12-17 17:46:51 -05:00
662eaea384
avoid float -> int64 conversion #1977
...
both cases have to be relatively small durations of time cherry picking...
2020-12-03 13:32:01 -05:00
0e3673e78c
remove idle thread; just call from periodicSlowCallback ( #1924 )
...
* remove thread
* remove ui
2020-11-11 21:47:19 -05:00
95798a5246
fix broken master, inject engine ptr to rpmcalculator ( #1759 )
...
* fix
* oops
2020-09-05 18:49:42 -04:00
1703152427
reducing code duplication?
2020-07-29 23:01:55 -04:00
0aa42762d9
remove
2020-07-21 00:08:41 -07:00
2c9cb4e291
remove "plain MAP" mode ( #1398 )
...
* consumers
* enums, input, config
* java
* default config cleanup
2020-05-05 15:04:55 -04:00
4d24fdd57d
Fuel/ign correctino on new temp sensors ( #1318 )
...
* corrections
* test
* adv map
* tests
* cleanup
* lcd
* fsio
* unneeded
* more math
* last consumer
* cleanup
* fix kinetis
2020-04-18 18:45:30 -04:00
9f75c0cea6
TPS consumers: idle and ignition and obd2 and lcd ( #1254 )
...
* advance_map
* tests
* unneeded
* idle
* use driver intent instead
* and obd and lcd
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-03 19:59:08 -04:00
f958047d14
only correct timing in dynamic mode ( #1247 )
...
* only correct in dynamic mode
* redundant check
2020-04-02 08:54:55 -04:00
8fd9842310
cleanup extern mess ( #1237 )
...
* cleanup
* move outside define
2020-03-29 19:06:03 -04:00
a5d4d06868
Multispark implementation ( #1192 )
...
* multispark prototype
* only multispark if not cut
* typo
* do some reasonableish math
* consume cfg
* todo
* bad merge
* move math out of engine2.cpp
* engine state config
* consume generated
* use new
* hand generate
* doc, debugging
* debug channel names
* don't depend on rpmcalc
* safer, fix math
* tests
* default multispark config
* remove todo
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-03-26 01:49:36 -04:00
2c809e4475
Remove old monitoring timestamps ( #1217 )
...
* remove monitoring timestamps
* adv map
* fuel calc
* map avg
* printing
* spark logic
* hip 9011
* new traces
* s
* missed a few
2020-03-24 20:19:19 -04:00
9e125ecbdf
launch control #203
2020-03-24 19:55:12 -04:00
397907a06f
Support disabling most/all features ( #1162 )
...
* this flag did nothing
* guard features properly
2020-02-26 18:16:35 -05:00
d49e253bff
Some initial work at Launch/ALS
...
(cherry picked from commit 07b3a0632f6673ad57db5b2d6b8ad21674cf3509)
2020-02-02 12:17:06 -05:00
b83a5310be
happy new year
2020-01-08 00:02:40 -05:00
af4f20551b
getting rid of boardConfiguration / binary compatible change
2019-12-11 17:48:55 -05:00
9ee8616cb0
Use templated array references ( #1027 )
...
* update defs
* consumers, use default params
* setArrayValues in tests
* floats
* test fixing
2019-11-22 23:27:24 -05:00
801b2eb70e
progress towards #961
2019-11-04 22:52:37 -05:00
62577c47da
preparation for #961
...
more unified access to pre-calculated value
2019-10-10 08:25:58 -04:00
29804cbc8a
move tsOutputChannels to header ( #970 )
2019-10-08 21:02:51 -04:00
e0db83e027
Template-ize bin/value length for interpolation ( #878 )
...
* update consumers
* tests
* whitespace
* format
2019-07-09 21:16:36 +03:00
cdac02429c
refactoring: better file name
2019-07-06 20:15:49 -04:00
ff39a72633
typo
2019-06-14 00:57:24 -04:00
rusefillc
Scott Smith
Matthew Kennedy
Andrey
Andreika
ola