rusefi
/
rusefi-1
mirror of https://github.com/rusefi/rusefi-1.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
18,555 Commits 1 Branch 0 Tags 1.2 GiB
Commit Graph

3758 Commits

Author SHA1 Message Date
GitHub build-firmware Action 1acccfd6a1 Auto-generated configs and docs 2022-02-21 14:33:40 +00:00
GitHub build-firmware Action 45c5082b88 Auto-generated configs and docs 2022-02-20 00:44:50 +00:00
GitHub build-firmware Action 0b8ce386f0 Auto-generated configs and docs 2022-02-19 01:12:42 +00:00
GitHub build-firmware Action af9d6e3bca Auto-generated configs and docs 2022-02-18 03:23:32 +00:00
rusefillc c01b5c0463
Migrate at least to jSerialComm v2.7.0 #3932 (#3941) 2022-02-17 22:10:55 -05:00
rusefillc 947f0a222e a step back 2022-02-16 01:20:02 -05:00
rusefillc 71e611d352 back to safe 2.5.3 2022-02-16 01:04:12 -05:00
rusefillc eb03c15252 a step back 2022-02-16 01:03:53 -05:00
Matthew Kennedy 1cd5421c20
serial disconnect event (#3939) 
* connector version bump (#3914)

Co-authored-by: rusefillc <sdfsdfqsf2334234234>

* be loud about disconnect events

Co-authored-by: rusefillc <48498823+rusefillc@users.noreply.github.com>
 2022-02-16 00:21:25 -05:00
rusefillc 2751a920f7 thank you Matt 2022-02-16 00:06:05 -05:00
rusefillc b898a6b810 logo_alphax.png 2022-02-16 00:04:25 -05:00
rusefillc c0aacc3921 fix console F7 flashing blinking fix #3852 2022-02-15 23:36:29 -05:00
rusefi ed162f83ba erase is a lengthy operation let's signal end 2022-02-15 23:07:51 -05:00
GitHub build-firmware Action 06791cf825 Auto-generated configs and docs 2022-02-16 03:50:05 +00:00
Matthew Kennedy 45acca32f7
fix connection deadlock, speed up reconnect (#3936) 2022-02-15 22:35:04 -05:00
GitHub build-firmware Action 2e89fd1f8d Auto-generated configs and docs 2022-02-15 22:14:03 +00:00
rusefillc 59f4262e0e we had changes recently 2022-02-14 12:38:53 -05:00
GitHub build-firmware Action c656fd8f9e Auto-generated configs and docs 2022-02-14 00:18:35 +00:00
GitHub build-firmware Action 8f11927cdf Auto-generated configs and docs 2022-02-13 05:15:18 +00:00
rusefillc aefbd4d43a Win7: console fails to auto-connect fix #3931 2022-02-12 17:33:59 -05:00
rusefillc f8f43529b6 Win7: console fails to auto-connect fix #3931 2022-02-12 17:26:11 -05:00
rusefillc 884463adda Win7: console fails to auto-connect #3931 2022-02-12 17:12:43 -05:00
rusefillc b124225c6d Console logging is a mess #3930 2022-02-12 16:46:08 -05:00
rusefillc 8677be4177 Console logging is a mess #3930 2022-02-12 16:20:38 -05:00
rusefillc f731a26391 Console logging is a mess #3930 2022-02-12 16:16:11 -05:00
rusefillc 1f97452359 Console logging is a mess #3930 2022-02-12 16:09:31 -05:00
rusefillc 83e879f6c1 minor stuff 2022-02-12 15:52:57 -05:00
rusefillc d5b962fe88 type. wow no one reads this 2022-02-12 15:32:21 -05:00
rusefillc 6b94feaead better message 2022-02-12 14:43:21 -05:00
rusefillc 6597679fab console does not send commands #3928 2022-02-12 11:54:34 -05:00
rusefillc 5310d022ce console updater does not work if folder name contains spaces fix #3927 2022-02-12 10:42:31 -05:00
rusefillc 34295e7108 console does not send commands fix #3928 2022-02-12 10:36:04 -05:00
rusefillc 8a8ade82c5 oh Andoid does it properly 2022-02-12 07:14:38 -05:00
Matthew Kennedy 60560c29d3
detect console disconnection faster (#3926) 
* optimize reads

* try to reconnect in 1 second

* print more

* inspection results

* put the timeout back

* note about race

* s
 2022-02-12 06:44:58 -05:00
rusefillc 837d228159 console connectivity on specific Win11 device #3923 
well nice call but no difference for our specific issue
 2022-02-11 23:10:14 -05:00
rusefillc 94e5957271 connector version bump #3914 
helping IDEA lib entry
 2022-02-11 23:09:04 -05:00
rusefillc 076960c419 console connectivity on specific Win11 device #3923 2022-02-11 22:59:53 -05:00
rusefi 857c653bc2 console connectivity on specific Win11 device #3923 2022-02-11 22:40:49 -05:00
GitHub build-firmware Action 9b9aacb848 Auto-generated configs and docs 2022-02-12 00:58:39 +00:00
rusefillc 58dddb61a1 H7 console scare #3923 2022-02-11 19:52:46 -05:00
Matthew Kennedy 2f1957cc0c
Chunk outputchannels (#3916) 
* executeCommand knows about opcodes

* kick

* remove allowLongResponse

* unused

* chunk output channel reads

* add api in firmware instead

* test size

* bad merge

* firmware missed a spot

* bad merge

* fix logic

* haha we have to disable it

* we can remove the TODO from #3917
 2022-02-11 17:24:08 -05:00
GitHub build-firmware Action 90a021e89a Auto-generated configs and docs 2022-02-11 21:18:53 +00:00
Matthew Kennedy 35c4c0bfba
move allowLongResponse option to ECU side (#3917) 
* executeCommand knows about opcodes

* kick

* remove allowLongResponse

* add api in firmware instead

* test size

* bad merge

* firmware missed a spot

* fix logic

* haha we have to disable it
 2022-02-11 16:03:20 -05:00
rusefillc 5e779208e7 this log message deserves a promotion! 2022-02-11 11:07:38 -05:00
rusefillc fd3bb9719f rusEFI console does not stay alive #3912 
test infrastructure progress
 2022-02-11 10:20:10 -05:00
rusefillc 1bdbad9ea6 rusEFI console does not stay alive #3912 
test infrastructure progress
 2022-02-11 10:19:30 -05:00
rusefillc cb9625b254 rusEFI console does not stay alive #3912 
test infrastructure progress
 2022-02-11 09:31:16 -05:00
rusefillc 6e047cce50 refactoring: extracting logging stuff 2022-02-11 09:18:59 -05:00
rusefillc d05a6d3362 rusEFI console does not stay alive #3912 
test infrastructure progress
 2022-02-11 09:15:32 -05:00
rusefillc a605d319ba serial sandbox 2022-02-11 08:50:53 -05:00
rusefillc 48e77b163d minor refactoring 2022-02-11 08:50:42 -05:00
rusefillc ad9cc4c219 refactoring: extracting logging stuff 2022-02-11 08:50:29 -05:00
Matthew Kennedy 5fc5bb40bd
executeCommand knows about opcodes (#3915) 
* executeCommand knows about opcodes

* kick

* extra line

* gross duplication

* ugh more
 2022-02-11 07:03:15 -05:00
rusefillc 6451638ab3
connector version bump (#3914) 
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
 2022-02-11 06:52:18 -05:00
rusefillc 06797c4fac docs 2022-02-10 23:17:42 -05:00
rusefillc 46d87f549f just refactoring 2022-02-10 22:45:35 -05:00
rusefillc 08774c4149 just refactoring 2022-02-10 22:45:30 -05:00
GitHub build-firmware Action 354ec0956b Auto-generated configs and docs 2022-02-11 02:07:17 +00:00
GitHub build-firmware Action 3c94106e19 Auto-generated configs and docs 2022-02-11 00:02:58 +00:00
Matthew Kennedy 15598605f4
more intellij inspection (#3910) 
* first part

* some more small ones

* more inspect
 2022-02-10 18:56:59 -05:00
GitHub build-firmware Action efc0f31c94 Auto-generated configs and docs 2022-02-10 15:29:24 +00:00
Matthew Kennedy 6b99f27d74
first part (#3907) 2022-02-10 01:51:48 -05:00
rusefillc 179f059671 Lua: 'read from ECU' does not read modified script fix #3906 
there is just no reason for that button
 2022-02-09 23:45:40 -05:00
GitHub build-firmware Action fcd11c91c8 Auto-generated configs and docs 2022-02-10 00:09:45 +00:00
Matthew Kennedy dbcf27a2e1
Engine sniffer refinements (#3905) 
* don't need 2 digits of angle

* engine sniffer panel clarity

* refactor UpDownImage

* start at +1

* leave space on left side

* every 20ms

* happy test happy developer
 2022-02-09 19:04:20 -05:00
GitHub build-firmware Action 41888da4ee Auto-generated configs and docs 2022-02-09 13:21:48 +00:00
GitHub build-firmware Action b4b746bc21 Auto-generated configs and docs 2022-02-09 11:59:07 +00:00
GitHub build-firmware Action c5a71ed66b Auto-generated configs and docs 2022-02-08 21:21:12 +00:00
GitHub build-firmware Action 98d910cc25 Auto-generated configs and docs 2022-02-08 15:50:25 +00:00
GitHub build-firmware Action 37532f600c Auto-generated configs and docs 2022-02-07 22:17:51 +00:00
GitHub build-firmware Action c3466df0c5 Auto-generated configs and docs 2022-02-07 00:04:39 +00:00
GitHub build-firmware Action 7f87cf17b3 Auto-generated configs and docs 2022-02-06 19:04:42 +00:00
GitHub build-firmware Action e747b3b681 Auto-generated configs and docs 2022-02-06 17:57:16 +00:00
GitHub build-firmware Action af3b66185a Auto-generated configs and docs 2022-02-06 14:53:31 +00:00
David Holdeman e310ef7943
continues -> continuous (#3895) 2022-02-05 15:29:09 -05:00
GitHub build-firmware Action 040c2c43b0 Auto-generated configs and docs 2022-02-05 00:14:04 +00:00
GitHub build-firmware Action a003db3507 Auto-generated configs and docs 2022-02-04 00:38:28 +00:00
Matthew Kennedy 88d51a0c25
tiny piece of mock adc remove (#3890) 
* tiny piece

* remove commands
 2022-02-03 19:32:56 -05:00
GitHub build-firmware Action ad271ea8cc Auto-generated configs and docs 2022-02-03 13:07:28 +00:00
GitHub build-firmware Action e98ab8433e Auto-generated configs and docs 2022-02-02 07:19:22 +00:00
GitHub build-firmware Action 924f175151 Auto-generated configs and docs 2022-02-02 06:04:12 +00:00
GitHub build-firmware Action 9b8de47b72 Auto-generated configs and docs 2022-02-02 04:22:53 +00:00
GitHub build-firmware Action ed0bb68b0c Auto-generated configs and docs 2022-02-02 03:59:01 +00:00
rusefillc b26ef2dcfa packing unused 2022-02-01 22:07:42 -05:00
GitHub build-firmware Action a4c473cbdf Auto-generated configs and docs 2022-02-02 02:45:00 +00:00
GitHub build-firmware Action 43df02b26f Auto-generated configs and docs 2022-02-02 00:24:37 +00:00
GitHub build-firmware Action be547d3717 Auto-generated configs and docs 2022-02-01 22:42:35 +00:00
rusefillc f8abb380bd Bells & whistles: board-specific image into console splash screen fix #3498 
done for now
 2022-02-01 17:06:13 -05:00
rusefillc ce334f0775 Console: Main "Pause" button not working? fix #3854 2022-02-01 17:00:38 -05:00
GitHub build-firmware Action eaa9642d8d Auto-generated configs and docs 2022-02-01 21:14:16 +00:00
rusefillc f3a2a9c6cb remove compile_fsio_file fix #3866 2022-02-01 11:13:33 -05:00
rusefillc 87930f540f remove compile_fsio_file fix #3866 2022-02-01 11:07:05 -05:00
GitHub build-firmware Action 11d6c5ddcc Auto-generated configs and docs 2022-02-01 00:28:37 +00:00
GitHub build-firmware Action 0bcfa4b1d2 Auto-generated configs and docs 2022-01-31 23:55:52 +00:00
GitHub build-firmware Action 10b18f086a Auto-generated configs and docs 2022-01-31 23:26:47 +00:00
GitHub build-firmware Action 7f39eff495 Auto-generated configs and docs 2022-01-31 04:52:52 +00:00
GitHub build-firmware Action 2cd4dede4f Auto-generated configs and docs 2022-01-30 14:01:11 +00:00
GitHub build-firmware Action e612423e48 Auto-generated configs and docs 2022-01-30 03:22:21 +00:00
rusefillc c92725d50a live data progress 2022-01-28 23:24:34 -05:00
GitHub build-firmware Action d20db70a28 Auto-generated configs and docs 2022-01-29 02:41:30 +00:00
rusefillc dca698720e perf trace button causes exception fix #3853 2022-01-28 21:07:56 -05:00
GitHub build-firmware Action 4c6e8e2776 Auto-generated configs and docs 2022-01-29 01:29:17 +00:00
GitHub build-firmware Action dc92552ad8 Auto-generated configs and docs 2022-01-29 00:57:50 +00:00
GitHub build-firmware Action 7311f25467 Auto-generated configs and docs 2022-01-28 06:04:57 +00:00
rusefillc e2a44063ec live data progress 2022-01-28 00:33:41 -05:00
rusefillc 4ad9d51c61 proper location for tests 2022-01-27 23:35:09 -05:00
rusefillc 5869e287c5 wow weird API but at least it clicks 2022-01-27 23:24:08 -05:00
rusefillc 1f6684fb8f sample tree 2022-01-27 22:55:03 -05:00
rusefillc 63600e33e7 horizontal fill 2022-01-27 22:43:17 -05:00
rusefillc caed05d4c2 dead ETB calibration UI 2022-01-27 20:24:28 -05:00
GitHub build-firmware Action 75d2e11b5a Auto-generated configs and docs 2022-01-28 01:16:52 +00:00
GitHub build-firmware Action deb6c03b21 Auto-generated configs and docs 2022-01-28 00:27:15 +00:00
GitHub build-firmware Action de947d2c64 Auto-generated configs and docs 2022-01-27 23:44:58 +00:00
GitHub build-firmware Action 1f664d8b5b Auto-generated configs and docs 2022-01-27 22:59:57 +00:00
GitHub build-firmware Action e5dec77869 Auto-generated configs and docs 2022-01-27 19:27:44 +00:00
rusefillc 173b60344f very strange very wrong imports 2022-01-27 12:54:23 -05:00
GitHub build-firmware Action 660337e952 Auto-generated configs and docs 2022-01-27 13:02:18 +00:00
GitHub build-firmware Action 516bfc746b Auto-generated configs and docs 2022-01-27 00:37:23 +00:00
GitHub build-firmware Action 20d5f24329 Auto-generated configs and docs 2022-01-26 04:02:08 +00:00
rusefillc e5427b8e65 Live Data progress 2022-01-24 21:38:03 -05:00
rusefillc 5c40e59d81 Live Data: dead code 2022-01-24 21:15:35 -05:00
rusefillc 217ea1f283 Live Data: removing .cpp from buttons 2022-01-24 21:10:46 -05:00
GitHub build-firmware Action c59cde8be1 Auto-generated configs and docs 2022-01-25 02:04:47 +00:00
rusefillc 11b8db910e console hex file scanner should not accept files with spaces in names fix #3836 2022-01-24 20:15:05 -05:00
GitHub build-firmware Action 0b954a9d4d Auto-generated configs and docs 2022-01-25 00:41:54 +00:00
rusefillc c08f9d2e14 console hex file scanner should not accept files with spaces in names fix #3836 2022-01-24 19:35:13 -05:00
GitHub build-firmware Action f4786271e8 Auto-generated configs and docs 2022-01-24 19:33:08 +00:00
GitHub build-firmware Action cb295b7603 Auto-generated configs and docs 2022-01-24 12:38:16 +00:00
GitHub build-firmware Action e584ef198c Auto-generated configs and docs 2022-01-24 02:55:57 +00:00
GitHub build-firmware Action ff27fda481 Auto-generated configs and docs 2022-01-23 20:42:35 +00:00
GitHub build-firmware Action 4116c32735 Auto-generated configs and docs 2022-01-23 02:55:04 +00:00
rusefillc 1e435ad2fb Restart attempts hangs up console fix #3826 2022-01-22 21:37:27 -05:00
GitHub build-firmware Action 7e1a1a3ba8 Auto-generated configs and docs 2022-01-22 21:56:51 +00:00
GitHub build-firmware Action 4e45e6cb6f Auto-generated configs and docs 2022-01-21 23:15:14 +00:00
GitHub build-firmware Action 7c85554ece Auto-generated configs and docs 2022-01-21 20:59:16 +00:00
rusefi 8d7b61fb9d new board automation 2022-01-21 15:23:02 -05:00
GitHub build-firmware Action 7c6a0e6b0d Auto-generated configs and docs 2022-01-21 18:16:00 +00:00
GitHub build-firmware Action a851b04fdb Auto-generated configs and docs 2022-01-21 01:45:43 +00:00
GitHub build-firmware Action 1ba5e052a1 Auto-generated configs and docs 2022-01-20 19:14:41 +00:00
GitHub build-firmware Action b36fa4d3a7 Auto-generated configs and docs 2022-01-20 02:14:16 +00:00
GitHub build-firmware Action bcfdb5ba55 Auto-generated configs and docs 2022-01-19 21:34:54 +00:00
GitHub build-firmware Action 5a816cc09a Auto-generated configs and docs 2022-01-19 12:39:51 +00:00
GitHub build-firmware Action c38f46bdc9 Auto-generated configs and docs 2022-01-19 05:56:03 +00:00
GitHub build-firmware Action 6987f6608b Auto-generated configs and docs 2022-01-19 02:12:52 +00:00
GitHub build-firmware Action 6b9986449c Auto-generated configs and docs 2022-01-19 00:31:52 +00:00
rusefillc c29a0b54a7 GDI Epic #1448 2022-01-18 12:31:12 -05:00
rusefillc 5a14b35799 console bug #3807 2022-01-18 12:00:37 -05:00
rusefillc c23c93a384 On m_event vs lobe vs scheduling #3804 2022-01-18 10:16:47 -05:00
GitHub build-firmware Action 16fbdfc81e Auto-generated configs and docs 2022-01-18 05:51:54 +00:00
GitHub build-firmware Action 6fed0c0c27 Auto-generated configs and docs 2022-01-18 05:43:17 +00:00
rusefillc 5e2ad39d91 GDI Epic #1448 2022-01-18 00:27:20 -05:00
GitHub build-firmware Action 726147da75 Auto-generated configs and docs 2022-01-18 05:10:57 +00:00
GitHub build-firmware Action 9b31f96f52 Auto-generated configs and docs 2022-01-18 01:29:33 +00:00
rusefi 9a2c9d7d67 UI thread is the thread to open dialogs 2022-01-17 16:46:36 -05:00
rusefillc 122728bc43 File Not Found better handling 2022-01-16 20:20:49 -05:00
GitHub build-firmware Action da2e9b9656 Auto-generated configs and docs 2022-01-17 01:02:11 +00:00
GitHub build-firmware Action 34205ce3fa Auto-generated configs and docs 2022-01-16 21:00:18 +00:00
GitHub build-firmware Action 0c495ae100 Auto-generated configs and docs 2022-01-16 17:59:26 +00:00
GitHub build-firmware Action 34510ab443 Auto-generated configs and docs 2022-01-16 01:12:10 +00:00
GitHub build-firmware Action 3be1a9a51b Auto-generated configs and docs 2022-01-15 23:09:54 +00:00
GitHub build-firmware Action 4360decabe Auto-generated configs and docs 2022-01-15 22:45:28 +00:00
GitHub build-firmware Action 96d0a623c0 Auto-generated configs and docs 2022-01-15 02:58:04 +00:00
GitHub build-firmware Action 598ce79b05 Auto-generated configs and docs 2022-01-15 01:22:25 +00:00
GitHub build-firmware Action cdab332a9d Auto-generated configs and docs 2022-01-14 03:39:21 +00:00
GitHub build-firmware Action 048b46c32d Auto-generated configs and docs 2022-01-13 03:04:47 +00:00
Matthew Kennedy c9350fc3cb
Revert "forced 4 byte thing is actually no longer needed so much" (#3785) 
* Revert "forced 4 byte thing is actually no longer needed so much"

This reverts commit 364783f658.

* bump flash version to force a re-write
 2022-01-12 21:59:21 -05:00
GitHub build-firmware Action 8c59828646 Auto-generated configs and docs 2022-01-13 02:44:46 +00:00
GitHub build-firmware Action 5fa54ed9ac Auto-generated configs and docs 2022-01-12 21:38:47 +00:00
rusefillc f9270f544f refactoring 2022-01-11 23:37:02 -05:00
rusefillc 22428230f6 rusefi_Console: Too long re-connection time #3305 
clean-up
 2022-01-11 23:35:55 -05:00
alxrMironovHome fa63c99ed3
Java Console reconnection fixing (by issue #3305) (#3716) 
* ADD: Port closing & and reconnection attempt at restart event

* FIX: Syntax error

* Explicitly initialization of lastTriedPort

* Explicitly initialization of isStarted

* Revert "Explicitly initialization of isStarted"

This reverts commit 4acdd44d6cb7c46caa22f1dece4aef61798756fd.

* DEL: Dead code

Co-authored-by: alxrMironov <330OMcorporative>
 2022-01-11 23:33:05 -05:00
GitHub build-firmware Action 2914f53d0f Auto-generated configs and docs 2022-01-12 04:08:51 +00:00
rusefillc dcc7080ce1 logging of live data structs #3614 2022-01-11 22:54:57 -05:00
GitHub build-firmware Action 3a5c7bd85c Auto-generated configs and docs 2022-01-12 01:53:19 +00:00
rusefillc fb60c2f1c7
fresh antlr (#3774) 
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
 2022-01-11 16:33:59 -05:00
rusefillc 1bcb3e8033 live view is confused by conditional compilation fix #3773 2022-01-11 14:10:30 -05:00
rusefillc cbb7e83810 live data - maybe fixing mouse scrolling at least in some cases? 2022-01-11 14:04:58 -05:00
rusefillc 249dee3017 console crash #3772 2022-01-11 13:03:09 -05:00
rusefillc 93c9382c86 live data progress 2022-01-11 00:15:42 -05:00
rusefillc 742bbb372c live data progress 2022-01-10 23:39:27 -05:00
rusefillc cca765ebe6 RE usability: live data for idle controller 2022-01-10 21:56:27 -05:00
rusefillc 699a5ef302 RE usability: live data for idle controller 2022-01-10 21:55:52 -05:00
GitHub build-firmware Action 68fda494cb Auto-generated configs and docs 2022-01-11 01:57:47 +00:00
GitHub build-firmware Action e064beb840 Auto-generated configs and docs 2022-01-11 00:32:14 +00:00
GitHub build-firmware Action 54848b03cb Auto-generated configs and docs 2022-01-10 22:06:22 +00:00
GitHub build-firmware Action 2742aa2092 Auto-generated configs and docs 2022-01-10 02:22:57 +00:00
GitHub build-firmware Action 814890a230 Auto-generated configs and docs 2022-01-09 03:59:57 +00:00
GitHub build-firmware Action 30463135a7 Auto-generated configs and docs 2022-01-09 03:29:17 +00:00
GitHub build-firmware Action 7911e85db9 Auto-generated configs and docs 2022-01-09 01:40:32 +00:00
GitHub build-firmware Action a2482ab87e Auto-generated configs and docs 2022-01-09 01:22:51 +00:00
GitHub build-firmware Action 9e13d2b259 Auto-generated configs and docs 2022-01-09 00:55:02 +00:00
GitHub build-firmware Action 9bb315c8a0 Auto-generated configs and docs 2022-01-08 00:02:50 +00:00
GitHub build-firmware Action 02ec63334e Auto-generated configs and docs 2022-01-07 01:00:00 +00:00
GitHub build-firmware Action c458c47e75 Auto-generated configs and docs 2022-01-07 00:31:48 +00:00
rusefillc 25ca48c408 Live Data progress 2022-01-06 17:58:59 -05:00
Andrey 2730536fcd add 2022-01-06 05:17:37 -05:00
Andrey 5908d47a56 send_command 2022-01-06 05:17:09 -05:00
GitHub build-firmware Action 48d9235ff5 Auto-generated configs and docs 2022-01-06 01:32:44 +00:00
rusefillc ed59d225ca live data progress 2022-01-05 01:34:48 -05:00
rusefillc 364783f658 forced 4 byte thing is actually no longer needed so much 2022-01-05 00:24:17 -05:00