Commit Graph

1271 Commits

Author SHA1 Message Date
rusefillc 34df0862b6
Merge pull request #1634 from mck1117/refactor-inj
move injector logic in to its own file
2020-07-24 22:47:39 -04:00
Matthew Kennedy 626f55a08a refacto 2020-07-24 18:26:24 -07:00
Matthew Kennedy cad0d47443 improve test 2020-07-23 01:24:02 -07:00
Matthew Kennedy 5e7ddc9f24 start refactor 2020-07-22 13:11:07 -07:00
rusefillc c6d2a856dd
Merge pull request #1606 from mck1117/reset-overlap
reset overlap counter on fuel reschedule
2020-07-20 23:51:34 -04:00
Matthew Kennedy 27f346b0ff make private 2020-07-20 18:50:48 -07:00
Matthew Kennedy a6139c5c70 Merge remote-tracking branch 'upstream/master' into export-all-logicdata 2020-07-20 18:48:54 -07:00
Matthew Kennedy b66b8f8542 test with fix 2020-07-20 18:47:08 -07:00
Matthew Kennedy ea49647c1d compensate for bug 2020-07-20 13:21:15 -07:00
Matthew Kennedy 66b9c3ebea auto export all logicdata 2020-07-20 13:12:21 -07:00
Matthew Kennedy 1da7be3f67 impruv 2020-07-20 12:40:23 -07:00
rusefi a92a8ba262 Merge remote-tracking branch 'origin/master' 2020-07-20 14:25:47 -04:00
rusefi 1e8a9862f1 unit test framework improvements for smoother event execution 2020-07-20 14:25:32 -04:00
rusefillc d85e98d1f7
Merge pull request #1622 from mck1117/encapsulate-wwae
put wall wetting inside InjectionEvent
2020-07-20 14:19:57 -04:00
Matthew Kennedy 8dba21c702 Merge remote-tracking branch 'upstream/master' into test-1592 2020-07-20 10:54:18 -07:00
rusefi d52fb0b168 better unit test logging 2020-07-20 13:38:33 -04:00
rusefi 2a45c9cbe8 unit test framework improvements for smoother event execution 2020-07-20 12:45:26 -04:00
rusefi de66f4dc6e unit test framework improvements for smoother event execution 2020-07-20 11:16:51 -04:00
Matthew Kennedy 9c736a2c3d test 2020-07-20 03:29:43 -07:00
Matthew Kennedy 46b7567195 put wall wetting inside 2020-07-20 00:04:05 -07:00
rusefi b2edd3a4f4 logicdata into unit tests 2020-07-20 00:36:10 -04:00
rusefi 517761320e logicdata into unit tests 2020-07-19 22:41:34 -04:00
rusefi e7b86346e8 filename parameter 2020-07-19 21:30:49 -04:00
rusefi 52972cec99 OMG it works! 2020-07-19 21:27:28 -04:00
rusefi 35e69c1c99 first bugfixes 2020-07-19 20:47:58 -04:00
Matthew Kennedy d6464fffe7
fix (#1620) 2020-07-19 18:05:31 -04:00
rusefi b114142bb8 let's add .logicdata for unit tests 2020-07-19 17:42:11 -04:00
rusefi fee5203f5f let's add .logicdata for unit tests 2020-07-19 16:13:55 -04:00
rusefi 49e9e08c65 better unit test logging 2020-07-19 15:47:21 -04:00
rusefi dd3a080d88 better unit test logging 2020-07-19 14:26:28 -04:00
rusefi 46a1d361b5 unit tests: order of tests multispark/sensor tests should not matter #1616
TODO
2020-07-19 14:10:55 -04:00
rusefi f7a182c170 would this work? 2020-07-19 13:59:55 -04:00
rusefi dbd3eaf7a9 Injectors #1 and #5 stick open #1592
two bytes of progress
2020-07-19 13:54:47 -04:00
rusefi c755dea256 would this work? 2020-07-19 13:50:43 -04:00
rusefi 8bce289fac would this work? 2020-07-19 13:45:42 -04:00
rusefi b67e9c9df6 would this work? 2020-07-19 13:33:02 -04:00
rusefi ded219ba78 Injectors #1 and #5 stick open #1592
two bytes of progress
2020-07-19 13:32:17 -04:00
rusefi 33b21c8bcf one step backwards to help build? 2020-07-19 13:26:46 -04:00
rusefi fdb455a004 Injectors #1 and #5 stick open #1592
starting somewhere
2020-07-19 13:13:25 -04:00
rusefi f2fd9decdd better folder structure 2020-07-19 12:57:05 -04:00
Matthew Kennedy ee6cb2c97a
correct batch fuel cylinder pairing (#1595)
* correct batch fuel cylinder pairing

* param

* only change behavior on two wire batch

* Add tests for two wire batch & sequential

* improve testing a little bit

* comments

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-07-13 14:46:55 -04:00
rusefi 13aef2dd77 EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806 2020-07-12 18:25:48 -04:00
rusefi 7735758ec5 PidIndustrial does not limit iTerm fix #1599 2020-07-11 15:30:40 -04:00
rusefi 84ebfe301a PidIndustrial does not limit iTerm #1599
confirming issue with a unit test
2020-07-11 15:19:27 -04:00
David Holdeman 779029caed
Switch to Bash (#1585)
* switch firmware to bash

* switch unit_testts to bash

* switch jenkins to bash
2020-07-09 10:27:20 -04:00
David Holdeman 15e44ae9cc
Use github actions to build and upload bundles (#1583)
* add env var to skip upload

* remove checking from compile.bat

* working on push.yaml

* finish sorting

* progress

* rename push to builds

* rename push to builds

* Add skip upload env var

* fix pull_request name

* fixed typo and changed name

* fixed indentation and runs-on

* try different env var setup

* add nucleos and switch to underscore

* add quotes

* remove boards that were commented

* remove boards that were commented

* fix project board name

* fixed variable name

* add ini-file and console-settings

* try installing gcc-multilib first

* Install g++-multilib as well

* remove unnecessary export

* fixed exit numbers

* change to different env setup

* add simulator and console compilation to board bundles

* changed OS and added linux simulator build

* add checkout and missing colon

* add gcc-multilib installes

* Install mingw

* fixed install

* remove mingw from linux sim and call compile directly

* change directory

* moved envs to command

* debug ls

* debug ls

* set ftp vars

* add makefile debug info

* removed batchecks

* redirect stdout to easier see orrs

* change name

* remove redirect, add file inpection

* Add conditional project name

* Try software upgrade

* missing char

* update ine files

* try quotes

* add escapes

* add quotes

* add escapes and quotes

* remove quotes and escapes

* remove software upgrade

* ignore test 2

* update apt

* like this then

* forgot import

* fix case

* remove RUSEFI_SKIP_UPLOAD and check RUSEFI_FTP_SERVER instead

* break workflow back apart

* upload simulator artifact

* fixed operator

* update apt

* change paths

* Update build-firmware.yaml

* move update bundle to artifacts

* fix var name

* Install ncftp

* set env vars conditionally

* remove check so zips are created

* try things the github way and copy to primary

* re-enable test

* missing space
2020-07-08 11:10:24 -04:00
rusefi 720ade2319 migrate amazing idle from FSIO to less opaque TS #1581 2020-07-08 01:12:08 -04:00
rusefi 23e6ea5475 idle_min through FSIO not working as intended #1553 2020-07-04 22:01:12 -04:00
rusefi bea9022f73 FATAL error: lsize mismatch 336/3342 #884 2020-07-04 09:39:16 -04:00
rusefi aa124130bd FATAL error: lsize mismatch 336/3342 #884 2020-07-03 21:38:56 -04:00
andreika-git 1e8bebd5b3
Gen config refactor 2 (#1560)
* gen_config refactor, part II

* short board defines

* oops

* comment & undef

* define QUOTE

Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2020-07-02 12:33:31 -04:00
rusefi a83cef6934 idle_min through FSIO not working as intended #1553 2020-07-01 20:45:37 -04:00
David Holdeman b4807708c8
Convert jenkins build_extra_bundles scripts to sh (#1554)
* Add checkout

* remove empty with statement

* Actually we do need push depth

* convert build_working_folder

* convert prepare_bundle

* fixed extension

* fixed closing bracket

* fixed comparison and assignments

* no comment

* convert compile_and_upload and clean

* convert build_simulator

* Finish converting build_working_folder

* convert build_java_console

* Add hashbangs

* remove findcyg instruction

* changed paths

* remove call

* add path

* fixed script names

* add prams

* fix cd

* convert clean_env_variables

* convert common_make.sh

* Added linux hex2dfu binary

* add file extension to linux hex2dfu

* add file extension to linux hex2dfu

* remove spurious paren

* fixed board name

* convert compile-frankenso-na6

* convert compile-frankenso-pal

* add hashbang

* convert compile-kinetis

* convert compile-mre-f4

* convert compile-mre-f4-hardware-QC-special-build

* convert compile-mre-f4-slave

* convert compile-mre-f7

* convert compile-mre-f7-test

* switch to underscores

* converting boards to sh

* convert prometheus

* convert proteus

* fixed path

* switch to underscores

* chmod and add extension

* add quotes

* Add check for Windows

* Add chmod

* fix script name

* fix error checking

* quote vars

* remove checking from batch shims

* fix typo

* change error checking to support nix style error codes

* switch to 1 retval

* cd back to firmware

* Add escapes

* change from cd to rel path

* add p flags to mkdir

Co-authored-by: David Holdeman <David Holdeman>
2020-07-01 14:09:01 -04:00
rusefi 7637a7a767 Merge remote-tracking branch 'origin/master' 2020-06-18 23:14:47 -04:00
David Holdeman 1898a21380
convert unit_tests/compile (#1517) 2020-06-18 23:14:05 -04:00
rusefi 31f01bf26b 1 byte issue in TuneReadWriteTest #1512 2020-06-18 22:51:07 -04:00
David Holdeman a923b876f9
Remove run_gcov (#1513)
* remove run_gcov and call ci_gcov from run_clean_gcov

* explicitly call bash
2020-06-18 17:44:57 -04:00
Matthew Kennedy c8fb6993ac
simplify cranking corrections (#1510) 2020-06-18 08:54:02 -04:00
Matthew Kennedy a34201d1d1
fuel math simplifications (#1485)
* simplify

* fix

* tweak

* cleaning

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-06-17 17:15:04 -04:00
rusefi fb5756fe3e nope, unit tests did not just fix themselves 2020-06-17 08:42:37 -04:00
Matthew Kennedy 65625deb32
only setup etb if primary sensor configured instead of proxy (#1489)
* only setup etb if primary sensor configured instead of proxy

* fix test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-06-16 21:38:09 -04:00
David Holdeman 6d8f765b56
Moved secrets check to before running coverage (#1501) 2020-06-16 18:55:18 -04:00
rusefi 3247df5657 docs 2020-06-16 18:25:41 -04:00
David Holdeman 1aa51c25f2
Move gcov to Github Actions (#1500)
* Add gcov generation

* Install missing software

* Change working directory

* typo

* Added echo statements

* Enquote args

* add test for args

* add error message

* replace return with exit

* added extra line returns
2020-06-16 17:39:50 -04:00
rusefi 9016df654c Trigger decoding issues (60-2) #1488
unit test refactoring
2020-06-15 00:11:02 -04:00
Matthew Kennedy b906d12268
Fix gppwm properly (#1487)
* directly control output in onoff mode

* test fixing
2020-06-11 20:43:26 -04:00
Matthew Kennedy 76745412c6
Factor out airmass logic (#1483)
* refactor

* extract more airmass

* rename, fix tests
2020-06-06 07:25:19 -04:00
Matthew Kennedy 2bdd8128db
refactor (#1481) 2020-06-03 21:12:12 -04:00
Matthew Kennedy 105460dada
Remove old thermistor implementation (#1458)
* remove test clt/iat

* remove warning since this code is nearly dead

* remove old therm impl

* tests & live doc

* not quite right
2020-05-28 17:51:33 -04:00
Matthew Kennedy bef53d8ba5
remove maf2map mode (#1474)
* remove

* remove fully

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-28 14:06:18 -04:00
rusefi c39d135e94 Makefile clean-up 2020-05-25 13:42:55 -04:00
Matthew Kennedy 0290a268ab
Redundant accelerator pedal (#1470)
* add second boudns

* init logic

* test changes

* reconfigure correctly

* rams
2020-05-23 19:48:32 -04:00
Matthew Kennedy b11c5cd8c8
switch some firmware warnings to errors (#1465)
* warnings as errors

* throw instead of exit

* test massaging

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-23 10:46:28 -04:00
rusefi 3ffc51f495 Clean-up analog channels in "unit" tests #1456 2020-05-20 03:54:40 -04:00
rusefi f2cf1358c1 Clean-up analog channels in "unit" tests #1456 2020-05-20 03:49:56 -04:00
rusefi f32e7c19f4 Clean-up analog channels in "unit" tests #1456 2020-05-20 03:42:09 -04:00
rusefi 695c8ddb03 Clean-up analog channels in "unit" tests #1456 2020-05-20 03:38:55 -04:00
rusefi 5dee5bcd6b Merge remote-tracking branch 'origin/master' 2020-05-20 03:17:13 -04:00
Matthew Kennedy 44e2a1c970
remove test clt/iat (#1457)
* remove test clt/iat

* remove warning since this code is nearly dead
2020-05-20 03:16:01 -04:00
rusefi 6584ebe2d8 docs 2020-05-20 03:12:23 -04:00
Matthew Kennedy 9dda1a21bc
Redundant tps (#1427)
* add redundant sensor

* add tests

* add configure, info printing

* tests

* tests

* partial hookup

* fix

* fix

* bad makefile merge

* use second TPS config

* update test

* update test

* sensor names

* set second pin by default

* fix auto cal

* auto cal both sensors

* add reconfigure of secondary sensors

* gobblin' up your ram

* slow down write a little bit

* put split in debug gauge

* s

Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-18 14:32:00 -04:00
Matthew Kennedy 94e63e7c43
binary logging (#1443)
* field support

* tests

* makefiles

* test data too

* missing include dir

* write correct thing

* fix one test

* fix test

* omnomnomnom ram

* format

* use defined names

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-17 15:56:37 -04:00
rusefi afc763f068 better VVT progress 2020-05-15 21:33:25 -04:00
rusefi da4c7e1a2a VVT_INACTIVE 2020-05-14 23:31:01 -04:00
Matthew Kennedy e46d9f0c99
Fix 100% duty injection (#1431)
* skip turn-off for high duty

* mock executor injection

* test

* switch to hard cut

* test no longer relevant
2020-05-14 07:44:32 -04:00
rusefi 1f692c4a9b 34-2 3 cam Toyota wheel progress 2020-05-10 18:03:11 -04:00
rusefi 3f7ca92241 removing some unneeded flexibility 2020-05-10 02:06:15 -04:00
rusefi 32ba492b48 34-2 3 cam Toyota wheel progress 2020-05-10 01:21:54 -04:00
rusefi ac9faf6646 docs & clean-up 2020-05-10 00:59:32 -04:00
Matthew Kennedy e2974cfeda
short term fuel trim: part 2 (#1405)
* add tooltip

* add other direction to deadband

* add impl

* test partitioning

* makefile

* wrong comment

* fix include
2020-05-07 08:52:32 -04:00
Matthew Kennedy aa3bf51723
short term fuel trim: part 1 (#1402)
* add cell

* add stft cell tests

* add bit

* minimally generate

* config defaults
2020-05-06 21:00:40 -04:00
Matthew Kennedy 74d13c391f
Rewrite boost control in new closed loop framework (#1342)
* rewrite boost

* test

* fix build

* tests

* open loop test

* test closed loop

* fix names

* typo

* tests

* mock boost setOutput

* needs more virtual

* fix boost logic

* switch to TPS based open loop

* fix test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-06 08:40:42 -04:00
Matthew Kennedy 745b0c04ac
pull out std air charge math (#1397) 2020-05-05 08:01:40 -04:00
rusefi c39662b5c6 better state messages 2020-05-01 18:52:06 -04:00
Matthew Kennedy ba6ec4ac51
TPS Auto Calibration with ETB (#1382)
* switch to thread

* actually use default frequency define

* crank ADC too

* make space in RAM

* remove TS field

* this should work for test

* auto cal

* wire up bench testing

* s

* fix

* rearrange a bit

* inject

* remove unused bit

* mock repair

* guard for ECUs without ETB
2020-04-28 19:31:41 -04:00
Matthew Kennedy d728b1ca48
Minor ETB improvements (#1381)
* fix pid reset and pedal failure

* pause control later

* test pauseEtbControl

* update tooltip + field name

* update test
2020-04-28 16:52:40 -04:00
Matthew Kennedy fe4b531aeb
Move ETB control to a thread (#1374)
* switch to thread

* actually use default frequency define

* crank ADC too

* make space in RAM

* remove TS field

* this should work for test

* fix dt

* re-resize ram
2020-04-28 07:22:31 -04:00
rusefi 6bd5cd1112 fixing build 2020-04-26 20:40:06 -04:00
Matthew Kennedy f128b33694
General purpose PWM: implementation & tests (#1366)
* config

* significant digits

* renumber enum, no need for a "none"

* ui

* impl base

* error handle MAP

* init & update

* don't need arg

* don't lie about sensor

* fix test build

* test stub

* initialize

* null check

* fix clamping

* test output

* types & enums

* don't need param

* test getOutput

* fix

* output pin instead of brain pin

* default config
2020-04-26 14:06:28 -04:00
Matthew Kennedy a444e09ff8
etb CL test (#1361) 2020-04-24 17:54:03 -04:00
Matthew Kennedy 99489cff67
Improve ETB idle control (#1319)
* compress idle pos

* fix tests for new behavior
2020-04-20 17:29:03 -04:00
Matthew Kennedy 1a5e0a42f8
Inject idle to ETB (#1335)
* inject idle position

* pointer

* etb idle tests

* extract mocks

* ops

* test negative case too

* don't convert for etb

* guard
2020-04-20 16:26:35 -04:00
Matthew Kennedy e04008610a
ETB: inject pedal map (#1334)
* add clampf

* more tests

* public

* missed a mock

* fix output duty clamping

* do it that way

* more

* ah ha!

* test negative too

* clamp pedal

* inject pedal map

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-20 14:34:45 -04:00
Matthew Kennedy 0619575716
ETB testing: output, position clamping (#1333)
* add clampf

* more tests

* public

* missed a mock

* fix output duty clamping

* do it that way

* more

* ah ha!

* test negative too

* clamp pedal

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-20 13:52:20 -04:00
Matthew Kennedy 8aac233a5f
rewrite etb tests with gmock (#1330) 2020-04-19 20:32:41 -04:00
Matthew Kennedy 75b009bbae
Closed loop controller base & ETB testing (#1322)
* closed loop controller base

* etb tps test

* closed loop controller tests

* test support

* update gtest

* fix for change

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 17:18:47 -04:00
rusefi 71e7fb7e50 TT_RENIX_66_2_2_2 2020-04-19 14:54:02 -04:00
rusefi b287b2f339 TT_HONDA_K_12_1 2020-04-19 14:23:01 -04:00
Matthew Kennedy 0d699bcfe9
Improve unexpected (#1323)
* use type instead of value

* fix remaining initializer-list users

* impruv

* last consumer?

* consumer

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 08:37:43 -04:00
Matthew Kennedy 7f60384c75
add expected helper class (#1321)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 01:53:04 -04:00
rusefi c5a0da2db7 consistency 2020-04-18 22:46:22 -04:00
rusefi be497685a0 Renix 44-2-2 2020-04-18 22:20:17 -04:00
Matthew Kennedy 4d24fdd57d
Fuel/ign correctino on new temp sensors (#1318)
* corrections

* test

* adv map

* tests

* cleanup

* lcd

* fsio

* unneeded

* more math

* last consumer

* cleanup

* fix kinetis
2020-04-18 18:45:30 -04:00
Matthew Kennedy bc15e0826d
CLT consumer: fsio (#1302)
* idle

* CLT test prep

* idle target

* header

* air interpolate

* ancient comment

* fuel cut

* fuel cut, idle tests

* cleanup

* fsio test help
2020-04-15 16:20:45 -04:00
Matthew Kennedy 044766ec70
New clt consumers part 1 (#1301)
* idle

* CLT test prep

* idle target

* header

* air interpolate

* ancient comment

* fuel cut

* fuel cut, idle tests

* cleanup
2020-04-15 09:48:17 -04:00
rusefi 697055bd9f fixing master 2020-04-14 12:55:39 -04:00
rusefi ced931c9b2 new attempt at better simulator 2020-04-13 13:12:55 -04:00
Matthew Kennedy e1301f3c47
fix maf (#1287) 2020-04-12 15:52:29 -04:00
Matthew Kennedy ff867b9301
fix warnings (#1282)
* warnings

* don't need to template those
2020-04-12 09:39:14 -04:00
Matthew Kennedy 8006c0a548
CLT/IAT/Aux in the new sensor world (#1269)
* hook up clt

* init test

* probably fix test

* aux temp

* relax checking

* more significant figures

* remove old aux temp

* hand generate

* claim RAM

* move to ccm

* subscribe

* info printing

* warnings

* raise high voltage failure threshold

* fix test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-07 16:07:09 -04:00
rusefi d3745c0f9e smart gpio clean-up 2020-04-06 14:13:29 -04:00
Matthew Kennedy 200bfe3f80
Deadband helper & tests (#1267)
* deadband

* header

* comment
2020-04-06 09:16:26 -04:00
Matthew Kennedy 595df15dfd
fix (#1268) 2020-04-06 09:00:26 -04:00
Matthew Kennedy 345bf61bd5
Goodbye, old TPS (#1266)
* clear out tps

* boost control

* aux valves

* launch, aux valves

* unused field
2020-04-05 19:33:33 -04:00
Matthew Kennedy 7d5df29fbd
yet more tps consumers (#1258)
* advance_map

* tests

* unneeded

* idle

* use driver intent instead

* and obd and lcd

* engine load

* ve lookup

* unused

* oops we needed that

* oops needed that too

* mocking

* test mocks

* oops

* helps to use the right sensor

* and cylinder cleanup

* fuel math

* typo

* old tests

* kill dead stuff

* cleanup

* more

* fix

* test

* s

* fix signature

* fix test

* comment

* priming pulse

* remove mock tps

* remove more dead

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-05 09:11:25 -04:00
Matthew Kennedy 3186741ddc
TPS Initialization Testing (#1264)
* test support

* stub for tests

* plumbing so we can test this

* add test

* comments
2020-04-05 09:10:08 -04:00
Matthew Kennedy bc3f0c6b27
More TPS consumers: VE lookup (#1256)
* advance_map

* tests

* unneeded

* idle

* use driver intent instead

* and obd and lcd

* engine load

* ve lookup

* unused

* oops we needed that

* oops needed that too

* mocking

* test mocks

* oops

* helps to use the right sensor

* and cylinder cleanup

* fuel math

* typo

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-04 08:41:09 -04:00
Matthew Kennedy 9f75c0cea6
TPS consumers: idle and ignition and obd2 and lcd (#1254)
* advance_map

* tests

* unneeded

* idle

* use driver intent instead

* and obd and lcd

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-03 19:59:08 -04:00
Matthew Kennedy b197c6ff07
run ETB on new TPS (#1248)
* run ETB on new TPS

* why did we include all those...?

* init tps for etb test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 21:33:49 -04:00
shadowm60 ea4cfa9046
E30 M3 Tach output solution #907 (#1203)
* Update tachometer.cpp

Initial implementation of E30 M3 Tach output solution #907, unit_test plus debugging next

* tacho unit tests

First successfull unit test for tachometer

* RAM adjustment so it would link

* refactoring tacho, broken!

* starting to make some progress...still fails after a few seconds

* Rework with SW PWM

* Update after code review

* unit_test update

* First working unit_test

* Update .gitignore

* Update engine_controller.cpp

* Update engine_controller.cpp

* Update tachometer.h

* Update test_tacho.cpp

Co-authored-by: rusefi <rusefi@users.noreply.github.com>
2020-04-02 15:20:04 -04:00
Matthew Kennedy b015ec5944
Add redundant sensor (#1249)
* add redundant sensor

* add tests

* add configure, info printing

* tests

* tests

* casing

Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 08:55:21 -04:00
Matthew Kennedy 22267e5479
Replace hasPedalPositionSensor (#1245)
* remove

* add Sensor::hasSensor

* consume in etb

* remove unused state

* don't use it there either

* format

* fix up tests

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 08:04:12 -04:00
rusefi a47dce4025 code style 2020-04-01 21:32:21 -04:00
Matthew Kennedy 50cd6549a2
Fully switch acc pedal to new sensors (#1212)
* proxy sensor

* header

* idle

* can

* settings

* remove old mocking

* remove old impl

* etb

* oops, gotta actually register it

* fix test

* structured bindings ftw!

* driver intent for stepper

* tear out old

* oops too much
2020-04-01 20:21:03 -04:00
Matthew Kennedy 483d4a2204
Debuggability in the new sensor world (#1238)
* rename to avoid conflict

* fix efilib

* add sensor printing

* makefile

* that check was already there

* const

* const

* fix tests

* formatting

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-03-30 18:29:42 -04:00
Matthew Kennedy 53679fab54
Finally rename injector_central to bench_test (#1229)
* bench test rename

* rename consumers

* good lord what are all of these externs doing

* fix tests
2020-03-26 08:03:55 -04:00
Matthew Kennedy a5d4d06868
Multispark implementation (#1192)
* multispark prototype

* only multispark if not cut

* typo

* do some reasonableish math

* consume cfg

* todo

* bad merge

* move math out of engine2.cpp

* engine state config

* consume generated

* use new

* hand generate

* doc, debugging

* debug channel names

* don't depend on rpmcalc

* safer, fix math

* tests

* default multispark config

* remove todo

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-03-26 01:49:36 -04:00
rusefi 1955af0b6c random code inspired by Ola 2020-03-24 19:50:04 -04:00
rusefi 5dce6e7104 launch control #203
somewhat questionable code
2020-03-23 23:20:54 -04:00
rusefi a32ae209d0 48 pin documentation 2020-03-21 10:41:25 -04:00
Matthew Kennedy d5600995e2
fix (#1202)
* fix test

* shrink memory
2020-03-19 20:02:49 -04:00
rusefi a33d479683 CLT stops working when using 2-0 custom trigger wheel #1171 2020-03-06 01:31:04 -05:00
Matthew Kennedy 40b0783205
Split out EtbHardware (#1168)
* start tear out motor

* fix

* nuke reconfig

* guard for test

* test fixing

* format, condense headers

* fix todos

* undo todo

* format
2020-03-03 17:56:50 -05:00
Matthew Kennedy 8647abd22b
Add single flag for omitting PnP configs (#1157)
* switch to single enable flag

* engine_configuration.cpp
2020-02-24 19:08:02 -05:00
rusefi 04a4e2bca3 ETB: expand automated testing #115 2020-02-22 23:18:02 -05:00
rusefi e9a3b218c4 miata vvt trigger decoding is broken #1145 2020-02-14 13:02:27 -05:00
rusefi a2c4b36edc Merge remote-tracking branch 'remotes/origin/2019.12.25_release_1.19.12_xmas' 2020-02-14 10:51:26 -05:00
rusefi ed2b7578a5 Merge remote-tracking branch 'remotes/origin/2019.12.25_release_1.19.12_xmas' 2020-02-14 10:50:50 -05:00
rusefi 243a532f84 miata vvt trigger decoding is broken #1145 2020-02-14 10:49:22 -05:00
rusefi 9790052596 miata vvt trigger decoding is broken #1145 2020-02-14 09:33:29 -05:00
rusefi 75d9417131 miata vvt trigger decoding is broken #1145 2020-02-14 00:37:36 -05:00
rusefi 0d1f45422e cam/vvt decoder 2020-02-05 01:49:33 -05:00
rusefi 4e8f9f0d30 cam/vvt decoder test progress 2020-02-05 01:08:39 -05:00
Matthew Kennedy c7dce2e38b
Rescale TPS (#1112)
* fake adc ticks

* consumers

* fix test 1

* fix tests
2020-02-01 16:41:07 -05:00
rusefi d63dae9301 this test is even better now! 2020-01-31 13:45:15 -05:00
rusefi f6e7e8871a VVT refactoring & assertions for VVT test 2020-01-31 01:49:10 -05:00
rusefi b6e0bc7ed1 date & VVT test progress 2020-01-31 01:23:01 -05:00
rusefi b6fe6555e0 lovely tiny bug which mostly affects NB2 with an impossible one tooth crank trigger wheel 2020-01-30 01:47:34 -05:00
rusefi d9b96fe509 extracting class & codes clean-up 2020-01-28 00:16:33 -05:00
rusefi 282cd8e1ac trigger refactoring 2020-01-26 14:20:55 -05:00
rusefi 51ab9f5b57 reducing code duplication 2020-01-26 06:28:33 -05:00
rusefi db2ab72d12 refactoring trigger 2020-01-26 03:33:45 -05:00
rusefi 9d0c5540d8 refactoring 2020-01-22 00:40:26 -05:00
rusefi bb217b01dd happy new year unification 2020-01-13 21:57:43 -05:00
rusefi 0bab01369a refactoring: no need to specify parameter manually 2020-01-12 10:43:02 -05:00
Matthew Kennedy d3d088676b Add timeout + raw value access for sensors (#1098)
* timeout

* inject stamp

* allow getting raw value

* plumb timeout

* fix tests
2020-01-12 03:25:23 -05:00
rusefi 645f51a038 better method names 2020-01-10 23:17:58 -05:00
Matthew Kennedy a6a1335adb Require tooth reference time for scheduleByAngle (#1091)
* injection

* injectors

* add edge timestamp to ShaftPositionListener

* scheduleByAngle require edgeTimestamp

* schedule with nt not us

* oops, these were missing from this branch
2020-01-09 23:45:13 +03:00
Matthew Kennedy 851c6041b1 Inject timestamps in to hwHandleShaftSignal (#1090)
* injection

* injectors
2020-01-09 21:19:11 +03:00
rusefi b83a5310be happy new year 2020-01-08 00:02:40 -05:00
Matthew Kennedy 95a7a9a8e1 Strongly typed action constructor (#1087)
* strong typing

* maybe we needed that one
2020-01-07 18:10:31 -05:00
Matthew Kennedy 5c85d53e16 Pass action_s instead of callback/param (#1084)
* change action

* consumers

* fix test

* didn't mean to add those

* simplify

* fix simulator

* fix sim for real

* oy

* maybe this time the simulator will actually be fixed, for real

* don't rely on undefined behavior
2020-01-07 00:41:18 -05:00
rusefi cb9fc19f92 that's not a worth a file 2019-12-24 00:03:53 -05:00
rusefi 595db366be dead code 2019-12-23 23:42:50 -05:00
rusefi c38b4545eb refactoring 2019-12-23 23:32:43 -05:00
rusefi 3494f6ff9f adding simplicity 2019-12-23 23:25:08 -05:00
rusefi 8ffbe768cd simplicity? 2019-12-23 22:50:04 -05:00
rusefi 1576a9f731 adding simplicity 2019-12-23 22:30:58 -05:00
Matthew Kennedy b9454790c7 Add new sensor function types (#1065)
* add functions

* add tests

* add chain tests

* float suffix
2019-12-17 09:06:29 -05:00
rusefi bd1bcccc19 this stuff is pretty dead 2019-12-15 21:59:25 -05:00
rusefi 5cf141065e fixing build is my most favourite time! 2019-12-13 18:37:11 -05:00
rusefi aa1b7e2c6b and finally a unit test, like it shoud be! 2019-12-13 14:55:20 -05:00
rusefi 236d952335 progress towards ETB controller mocking 2019-12-13 13:52:34 -05:00
rusefi af4f20551b getting rid of boardConfiguration / binary compatible change 2019-12-11 17:48:55 -05:00
rusefi 05ab778396 clean-up 2019-12-10 01:03:02 -05:00
rusEfi 1cc71ef8ec dual-ETB progress 2019-12-10 00:07:46 -05:00
rusefi c5cfd21a70 just a trivial massive rename: TriggerState > TriggerWaveform 2019-12-08 01:09:39 -05:00
rusefi d6471a84bc Refactor Trigger System #635
injecting callback via parameters instead of nasty "bool isInitializingTrigger" field
2019-12-06 01:57:11 -05:00
rusefi 717abd6b67 Refactor Trigger System #635
injecting callback via parameters via magic and potentially broken field manipulation
2019-12-06 01:05:19 -05:00
rusefi 813b6aa6ce The Big Refactoring of 2019: folder structure #723 2019-12-04 01:11:10 -05:00
rusefi de36f76882 The Big Refactoring of 2019: folder structure #723 2019-12-03 23:52:44 -05:00
rusefi 500315b042 refactoring - updating name according to new reality 2019-12-03 14:39:11 -05:00
rusefi eb305f0265 #490 2019-12-03 00:29:12 -05:00
rusefi bec88bf8c8 EngineTestHelper progress 2019-12-03 00:20:47 -05:00
Matthew Kennedy 3008e19110 missing override (#1039) 2019-12-02 23:52:35 -05:00
rusefi 3298283973 reducing complexity 2019-12-02 23:29:06 -05:00
rusefi 955b2b5c3f misc clean-up 2019-12-02 13:53:31 -05:00
rusefi df26a9fb16 shared GCC settings between projects 2019-12-02 13:53:08 -05:00
rusefi 4dafc65d69 misc clean-up 2019-12-02 10:18:13 -05:00
rusefi 0583fd0b6c misc clean-up 2019-12-02 10:03:50 -05:00
rusefi 0b4f624b2a cj125 unit test progress! 2019-12-02 01:52:54 -05:00
andreika-git 1808642af1 Starter relay + Hardcoded 'FSIO' + simulator fix (#1032)
* Starter Relay: gui + built-in FSIO impl.

* Hardcoded 'FSIO' replacement for RAM-limited boards

* fix simulator
2019-11-25 20:08:01 -05:00
rusefi 1cb2f92142 more correct variable names 2019-11-23 23:49:39 -05:00
rusefi 7ee657d238 aux valves unit test 2019-11-23 22:55:21 -05:00
rusefi ab744af14b header cleanup 2019-11-23 21:41:17 -05:00
rusefi af60a46229 making progres on angle-based scheduling 2019-11-23 20:36:40 -05:00
rusefi 7b7b46a2a2 refactoring 2019-11-23 18:38:16 -05:00
rusefi f0c4817e1b 'triggerEventAngle' not really needed 2019-11-23 17:44:44 -05:00
rusefi aa4967383a explicit list field to simplify code navigation 2019-11-23 17:04:51 -05:00
Matthew Kennedy 9ee8616cb0 Use templated array references (#1027)
* update defs

* consumers, use default params

* setArrayValues in tests

* floats

* test fixing
2019-11-22 23:27:24 -05:00
rusefi ad7e36c228 refactoring 2019-11-20 01:35:08 -05:00
rusefi d3da33517f making F4 and else happier with perf_trace, also maybe missing 'break'? 2019-11-19 20:36:47 -05:00
rusEfi 1991437f77 development into unit tests, makefile cleanup 2019-11-19 20:05:12 -05:00
rusefi 6c012ba0e4 v12 2019-11-18 23:54:08 -05:00
rusefi ebe6a4b981 v12 done right 2019-11-17 09:32:12 -05:00
rusefi fb7cba96b6 code formatting 2019-11-17 09:03:20 -05:00
rusEfi 81167d9945 #pragma once 2019-11-15 00:00:13 -05:00
rusefi 25298e2392 32 bit vs 64 bit compiler challenge for floats in unit tests 2019-11-10 13:57:27 -05:00
andreika-git b996190707 Industrial PID Controller (#1002)
* Implement Industrial PID controller

* Test-Use PidIndustrial in alternator

* Meaningful unit-tests for PidIndustrial
2019-11-10 13:04:27 -05:00
rusefi df291f4421 Missing dwell altogether in some corner cases fix #796 2019-11-06 00:31:24 -05:00
rusefi c9552f29bb Missing dwell altogether in some corner cases #796
getting closer!
2019-11-06 00:01:08 -05:00
andreika-git ee5ee1942c Kinetis & TLE8888 compatibility & fixes... (#991)
* TLE8888: More compatibility & postTunerStudioState

* activeConfiguration & EFI_ACTIVE_CONFIGURATION_IN_FLASH fix

* Kinetis: jump_to_bootloader() impl.

* Kinetis: UART baudrate safety check

* Kinetis: OMG!..
2019-10-31 16:06:34 -04:00
rusefi 88348ebd09 refactoring: reducing code duplication 2019-10-21 23:47:40 -04:00
Matthew Kennedy 10a6d6eb8b fix wwae (#980) 2019-10-17 00:06:54 -04:00
rusefi 88c8363f82 I guess we can simply change the magic number 2019-10-16 23:02:37 -04:00
rusefi 344136eea9 preparing for #973 2019-10-16 22:10:38 -04:00
rusefi f9fb4143a5 preparing for #973
wall wetting was not covered by any unit test?!
2019-10-16 16:46:34 -04:00
rusefi 96f432fb4c Coil duty cycle ignores dwell #977 2019-10-15 05:30:38 -04:00
rusefi 938d7739a6 Coil duty cycle ignores dwell #977
test-driven is the way to go
2019-10-15 05:16:30 -04:00
rusefi 6629b90a7f preparing for #974
code comments & refactoring
2019-10-14 18:32:16 -04:00
rusefi 5a4c7b38cd preparing for #974
code comments & refactoring
2019-10-14 16:04:28 -04:00
rusefi 7bb8bb7f14 preparing for #974
code comments & refactoring
2019-10-14 09:09:08 -04:00
rusefi 12137fc7cd preparing for #974
code comments & refactoring
2019-10-14 06:18:08 -04:00
rusefi 38db34fe58 sweet unit test hack 2019-10-13 09:59:43 -04:00
rusefi 5cb90d0e1b preparation for #961
more unified access to pre-calculated value
2019-10-13 09:59:06 -04:00
rusefi ca6e49dcbc preparation for #961
macro as a syntax sugar for method invocation
2019-10-10 07:28:52 -04:00
rusefi 4574aaccce I got carried away, but DEAD CODE?! 2019-10-08 03:14:21 -04:00
rusefi 2acdbf308b something is over-complicated here? looks like two classes should become one? 2019-10-08 02:56:19 -04:00
rusefi a65c8c9295 something is over-complicated here? looks like two classes should become one? 2019-10-08 02:35:21 -04:00
rusefi fbbf8995e4 wow, dead field 2019-10-08 02:17:32 -04:00
rusefi 2b59940161 really not clear what is the best place for these classes 2019-10-08 02:13:52 -04:00
rusefi 42dc9e3662 fancy C++ s/NULL/nullptr/ 2019-10-08 01:26:35 -04:00
rusefi 1ab488e4b4 refactoring: better field name(s) 2019-10-08 01:03:57 -04:00
rusefi ca67249522 refactoring: better field name 2019-10-08 00:54:19 -04:00
rusefi fdfd2244ce One cylinder, 4 stroke, only crank sensor needs special wasted_mode spark control #968
just a unit test for now
2019-10-07 23:12:29 -04:00
rusefi e6f5a6e3f4 refactoring: all events are now validated in relation to current timestamp 2019-10-07 23:02:47 -04:00
rusefi 0380d4d709 refactoring 2019-10-07 21:54:03 -04:00
rusefi 5e48109780 docs & refactoring 2019-10-07 21:23:38 -04:00
Matthew Kennedy d1da567b85 fix gm 24x decoder (#963)
* fix gm

* fix

* fix default config, tests
2019-10-05 08:27:30 -04:00
Matthew Kennedy faa2a481ea Simplify thermistor config (#962)
* simplify thermistor config

* fix test
2019-10-02 21:00:10 -04:00