rusefi
/
rusefi-full
mirror of https://github.com/rusefi/rusefi-full.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix dwell default, improve TS field names (#689) 

* improve message

* clarify cranking dwell settings

* change default

* fix unit test that made assumption
This commit is contained in:
Matthew Kennedy 2019-02-07 04:44:07 -08:00 committed by rusefi
parent c736716d1a
commit 17691227d5
5 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
firmware/controllers/algo/engine_configuration.cpp
View File

@ -700,7 +700,7 @@ void setDefaultConfiguration(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
* Use angle-based duration during cranking * Use angle-based duration during cranking
* this is equivalent to 'disable cranking_constant_dwell' console command * this is equivalent to 'disable cranking_constant_dwell' console command
*/ */
engineConfiguration->useConstantDwellDuringCranking = false; engineConfiguration->useConstantDwellDuringCranking = true;
engineConfiguration->ignitionDwellForCrankingMs = 6; engineConfiguration->ignitionDwellForCrankingMs = 6;
setFuelLoadBin(1.2, 4.4 PASS_CONFIG_PARAMETER_SUFFIX); setFuelLoadBin(1.2, 4.4 PASS_CONFIG_PARAMETER_SUFFIX);

2
firmware/integration/rusefi_config.txt
View File

@ -646,7 +646,7 @@ bit vvtDisplayInverted
bit fuelClosedLoopCorrectionEnabled bit fuelClosedLoopCorrectionEnabled
bit isVerboseIAC;+Print details into rusEfi console bit isVerboseIAC;+Print details into rusEfi console
bit isVerboseETB;enable verbose_etb bit isVerboseETB;enable verbose_etb
bit useConstantDwellDuringCranking;+Use angle-based duration or fixed absolute time dwell duration? bit useConstantDwellDuringCranking;+If set to true, will use the specified duration for cranking dwell. If set to false, will use the specified dwell angle. Unless you have a really good reason to, leave this set to true to use duration mode.
bit isEngineChartEnabled;This options enables data for 'engine sniffer' tab in console, which comes at some CPU price bit isEngineChartEnabled;This options enables data for 'engine sniffer' tab in console, which comes at some CPU price
bit silentTriggerError bit silentTriggerError
bit useLinearCltSensor bit useLinearCltSensor

10
firmware/tunerstudio/rusefi.ini
View File

@ -63,7 +63,7 @@ enable2ndByteCanID = false
; see PAGE_0_SIZE in C source code ; see PAGE_0_SIZE in C source code
; CONFIG_DEFINITION_START ; CONFIG_DEFINITION_START
; this section was generated automatically by ConfigDefinition.jar based on rusefi_config.txt Sat Feb 02 20:30:30 EST 2019 ; this section was generated automatically by ConfigDefinition.jar based on rusefi_config.txt Wed Feb 06 20:56:44 PST 2019
pageSize = 20000 pageSize = 20000
page = 1 page = 1
@ -903,7 +903,7 @@ page = 1
isFasterEngineSpinUpEnabled = "Smarter cranking logic.\nSee also startOfCrankingPrimingPulse" isFasterEngineSpinUpEnabled = "Smarter cranking logic.\nSee also startOfCrankingPrimingPulse"
sensorChartMode = "rusEfi console Sensor Sniffer mode" sensorChartMode = "rusEfi console Sensor Sniffer mode"
isVerboseIAC = "Print details into rusEfi console" isVerboseIAC = "Print details into rusEfi console"
useConstantDwellDuringCranking = "Use angle-based duration or fixed absolute time dwell duration?" useConstantDwellDuringCranking = "If set to true, will use the specified duration for cranking dwell. If set to false, will use the specified dwell angle. Unless you have a really good reason to, leave this set to true to use duration mode."
isInjectionEnabled = "enable injection" isInjectionEnabled = "enable injection"
isIgnitionEnabled = "enable ignition" isIgnitionEnabled = "enable ignition"
isCylinderCleanupEnabled = "If TPS above 95% no fuel would be injected during cranking\nenable cylinder_cleanup" isCylinderCleanupEnabled = "If TPS above 95% no fuel would be injected during cranking\nenable cylinder_cleanup"
@ -2910,9 +2910,9 @@ cmd_set_engine_type_Miata_NA2 = "w\x00\x30\x00\x2F"
field = "Advance", crankingTimingAngle, {useSeparateAdvanceForCranking == 0} field = "Advance", crankingTimingAngle, {useSeparateAdvanceForCranking == 0}
field = "Use separate Advance Table for cranking", useSeparateAdvanceForCranking field = "Use separate Advance Table for cranking", useSeparateAdvanceForCranking
field = "Use Advance Corrections for cranking", useAdvanceCorrectionsForCranking field = "Use Advance Corrections for cranking", useAdvanceCorrectionsForCranking
field = "Use fixed Dwell?", useConstantDwellDuringCranking field = "Use fixed cranking dwell", useConstantDwellDuringCranking
field = "Fixed Dwell", ignitionDwellForCrankingMs, {useConstantDwellDuringCranking == 1} field = "Fixed Cranking Dwell", ignitionDwellForCrankingMs, {useConstantDwellDuringCranking == 1}
field = "Charge Angle", crankingChargeAngle, {useConstantDwellDuringCranking == 0} field = "Cranking Dwell Angle", crankingChargeAngle, {useConstantDwellDuringCranking == 0}
dialog = postCrankingEnrichment, "Post-cranking short-time fuel enrichment" dialog = postCrankingEnrichment, "Post-cranking short-time fuel enrichment"
field = "Target temperature", postCrankingTargetClt field = "Target temperature", postCrankingTargetClt

6
firmware/tunerstudio/rusefi.input
View File

@ -2050,9 +2050,9 @@ cmd_set_engine_type_Miata_NA2 = "w\x00\x30\x00\x2F"
field = "Advance", crankingTimingAngle, {useSeparateAdvanceForCranking == 0} field = "Advance", crankingTimingAngle, {useSeparateAdvanceForCranking == 0}
field = "Use separate Advance Table for cranking", useSeparateAdvanceForCranking field = "Use separate Advance Table for cranking", useSeparateAdvanceForCranking
field = "Use Advance Corrections for cranking", useAdvanceCorrectionsForCranking field = "Use Advance Corrections for cranking", useAdvanceCorrectionsForCranking
field = "Use fixed Dwell?", useConstantDwellDuringCranking field = "Use fixed cranking dwell", useConstantDwellDuringCranking
field = "Fixed Dwell", ignitionDwellForCrankingMs, {useConstantDwellDuringCranking == 1} field = "Fixed Cranking Dwell", ignitionDwellForCrankingMs, {useConstantDwellDuringCranking == 1}
field = "Charge Angle", crankingChargeAngle, {useConstantDwellDuringCranking == 0} field = "Cranking Dwell Angle", crankingChargeAngle, {useConstantDwellDuringCranking == 0}
dialog = postCrankingEnrichment, "Post-cranking short-time fuel enrichment" dialog = postCrankingEnrichment, "Post-cranking short-time fuel enrichment"
field = "Target temperature", postCrankingTargetClt field = "Target temperature", postCrankingTargetClt

1
unit_tests/tests/test_trigger_decoder.cpp
View File

@ -202,6 +202,7 @@ TEST(misc, testFordAspire) {
engineConfiguration->crankingChargeAngle = 65; engineConfiguration->crankingChargeAngle = 65;
engineConfiguration->crankingTimingAngle = 31; engineConfiguration->crankingTimingAngle = 31;
engineConfiguration->useConstantDwellDuringCranking = false;
engine->rpmCalculator.setRpmValue(200 PASS_ENGINE_PARAMETER_SUFFIX); engine->rpmCalculator.setRpmValue(200 PASS_ENGINE_PARAMETER_SUFFIX);
assertEqualsM("cranking dwell", 54.166670, getSparkDwell(200 PASS_ENGINE_PARAMETER_SUFFIX)); assertEqualsM("cranking dwell", 54.166670, getSparkDwell(200 PASS_ENGINE_PARAMETER_SUFFIX));