rusefi
/
rusefi-full
mirror of https://github.com/rusefi/rusefi-full.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

#4 idle min/max

This commit is contained in:
rusefi 2017-05-28 13:44:26 -04:00
parent 05f69db77e
commit 38171cd2bd
3 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
firmware/controllers/algo/engine_configuration.cpp
View File

@ -166,6 +166,10 @@ void incrementGlobalConfigurationVersion(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
onConfigurationChangeElectronicThrottleCallback(&activeConfiguration); onConfigurationChangeElectronicThrottleCallback(&activeConfiguration);
#endif /* EFI_ELECTRONIC_THROTTLE_BODY */ #endif /* EFI_ELECTRONIC_THROTTLE_BODY */
#if EFI_IDLE_CONTROL || defined(__DOXYGEN__)
onConfigurationChangeIdleCallback(&activeConfiguration);
#endif /* EFI_IDLE_CONTROL */
rememberCurrentConfiguration(); rememberCurrentConfiguration();
} }
@ -657,6 +661,10 @@ void setDefaultConfiguration(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
engineConfiguration->cranking.baseFuel = 5; engineConfiguration->cranking.baseFuel = 5;
engineConfiguration->idleValvePidMin = 5;
engineConfiguration->idleValvePidMax = 95;
boardConfiguration->idlePidDeactivationTpsThreshold = 2;
engineConfiguration->analogInputDividerCoefficient = 2; engineConfiguration->analogInputDividerCoefficient = 2;
engineConfiguration->crankingChargeAngle = 70; engineConfiguration->crankingChargeAngle = 70;

13
firmware/controllers/idle_thread.cpp
View File

@ -43,6 +43,7 @@ extern TunerStudioOutputChannels tsOutputChannels;
EXTERN_ENGINE EXTERN_ENGINE
; ;
static bool shouldResetPid = false;
static Pid idlePid(&engineConfiguration->idleRpmPid, 1, 99); static Pid idlePid(&engineConfiguration->idleRpmPid, 1, 99);
@ -184,6 +185,14 @@ static msg_t ivThread(int param) {
// todo: in auto mode, speel should be taken from idleDTe // todo: in auto mode, speel should be taken from idleDTe
chThdSleepMilliseconds(boardConfiguration->idleThreadPeriod); chThdSleepMilliseconds(boardConfiguration->idleThreadPeriod);
if (shouldResetPid) {
idlePid.reset();
// alternatorPidResetCounter++;
shouldResetPid = false;
}
// this value is not used yet // this value is not used yet
if (boardConfiguration->clutchDownPin != GPIO_UNASSIGNED) { if (boardConfiguration->clutchDownPin != GPIO_UNASSIGNED) {
engine->clutchDownState = efiReadPin(boardConfiguration->clutchDownPin); engine->clutchDownState = efiReadPin(boardConfiguration->clutchDownPin);
@ -283,7 +292,9 @@ void setIdleDT(int value) {
} }
void onConfigurationChangeIdleCallback(engine_configuration_s *previousConfiguration) { void onConfigurationChangeIdleCallback(engine_configuration_s *previousConfiguration) {
shouldResetPid = !idlePid.isSame(&previousConfiguration->idleRpmPid);
idlePid.minResult = engineConfiguration->idleValvePidMin;
idlePid.maxResult = engineConfiguration->idleValvePidMax;
} }
void startIdleBench(void) { void startIdleBench(void) {

1
firmware/controllers/idle_thread.h
View File

@ -24,5 +24,6 @@ void setIdleDFactor(float value);
void setIdleMode(idle_mode_e value); void setIdleMode(idle_mode_e value);
void setTargetIdleRpm(int value); void setTargetIdleRpm(int value);
void setIdleDT(int value); void setIdleDT(int value);
void onConfigurationChangeIdleCallback(engine_configuration_s *previousConfiguration);
#endif /* IDLE_THREAD_H_ */ #endif /* IDLE_THREAD_H_ */