rusefi
/
rusefi-full
mirror of https://github.com/rusefi/rusefi-full.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Starter is engaged on start-up in pull-up configuration #1969 

usability & test improvement
This commit is contained in:
rusefillc 2020-11-19 17:15:28 -05:00
parent ee51da64ad
commit 68c8d8c6a2
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
firmware/controllers/engine_controller_misc.cpp
View File

@ -150,7 +150,9 @@ static void onStartStopButtonToggle(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
bool wasStarterEngaged = enginePins.starterControl.getAndSet(1); bool wasStarterEngaged = enginePins.starterControl.getAndSet(1);
if (!wasStarterEngaged) { if (!wasStarterEngaged) {
engine->startStopStateLastPushTime = getTimeNowNt(); engine->startStopStateLastPushTime = getTimeNowNt();
scheduleMsg(&sharedLogger, "Let's crank this engine for up to %dseconds!", CONFIG(startCrankingDuration)); scheduleMsg(&sharedLogger, "Let's crank this engine for up to %d seconds via %s!",
CONFIG(startCrankingDuration),
hwPortname(CONFIG(starterControlPin)));
} }
} else if (engine->rpmCalculator.isRunning()) { } else if (engine->rpmCalculator.isRunning()) {
scheduleMsg(&sharedLogger, "Let's stop this engine!"); scheduleMsg(&sharedLogger, "Let's stop this engine!");

6
unit_tests/tests/test_start_stop.cpp
View File

@ -20,6 +20,12 @@ TEST(start, startStop) {
slowStartStopButtonCallback(PASS_ENGINE_PARAMETER_SIGNATURE); slowStartStopButtonCallback(PASS_ENGINE_PARAMETER_SIGNATURE);
ASSERT_FALSE(efiReadPin(engineConfiguration->starterControlPin)); ASSERT_FALSE(efiReadPin(engineConfiguration->starterControlPin));
// startup 'timeout' duration of time is a special case so let's sleep a bit
eth.smartMoveTimeForwardSeconds(10);
slowStartStopButtonCallback(PASS_ENGINE_PARAMETER_SIGNATURE);
ASSERT_FALSE(efiReadPin(engineConfiguration->starterControlPin));
eth.smartMoveTimeForwardSeconds(10); eth.smartMoveTimeForwardSeconds(10);
// hit 'start' button! inverted since pull-up // hit 'start' button! inverted since pull-up