rusefi
/
rusefi-full
mirror of https://github.com/rusefi/rusefi-full.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tle8888 dead code (#4568)

This commit is contained in:
Andrey G 2022-09-13 01:54:29 +03:00 committed by GitHub
parent 8ff49301e5
commit 69d9716fa6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
firmware/controllers/algo/engine.cpp
View File

@ -260,11 +260,6 @@ void Engine::periodicSlowCallback() {
#endif // ANALOG_HW_CHECK_MODE
}
#if (BOARD_TLE8888_COUNT > 0)
extern float vBattForTle8888;
#endif /* BOARD_TLE8888_COUNT */
/**
* We are executing these heavy (logarithm) methods from outside the trigger callbacks for performance reasons.
* See also periodicFastCallback
@ -278,12 +273,6 @@ void Engine::updateSlowSensors() {
sensorChartMode = rpm < engineConfiguration->sensorSnifferRpmThreshold ? engineConfiguration->sensorChartMode : SC_OFF;
engineState.updateSlowSensors();
#if (BOARD_TLE8888_COUNT > 0)
// nasty value injection into C driver which would not be able to access Engine class
vBattForTle8888 = Sensor::get(SensorType::BatteryVoltage).value_or(VBAT_FALLBACK_VALUE);
#endif /* BOARD_TLE8888_COUNT */
#endif
}

22
firmware/hw_layer/drivers/gpio/tle8888.cpp
View File

@ -164,13 +164,6 @@ const uint8_t tle8888_fwd_responses[16][4] = {
/* Driver local variables and types. */
/*==========================================================================*/
// todo: much of state is currently global while technically it should be per-chip. but we
// are lazy and in reality it's usually one chip per board
static int lowVoltageResetCounter = 0;
float vBattForTle8888 = 0;
/* Driver private data */
struct Tle8888 : public GpioChip {
int init() override;
@ -299,7 +292,7 @@ void tle8888PostState() {
engine->outputChannels.debugIntField5 = chip->init_cnt;
engine->outputChannels.debugFloatField3 = chip->OpStat[1];
engine->outputChannels.debugFloatField4 = chip->por_cnt * 1000000 + chip->init_req_cnt * 10000 + lowVoltageResetCounter;
engine->outputChannels.debugFloatField4 = chip->por_cnt * 1000000 + chip->init_req_cnt * 10000;
engine->outputChannels.debugFloatField5 = 0;
engine->outputChannels.debugFloatField6 = 0;
}
@ -842,19 +835,6 @@ static THD_FUNCTION(tle8888_driver_thread, p) {
/* default polling interval */
poll_interval = TIME_MS2I(DIAG_PERIOD_MS);
#if 0
if (vBattForTle8888 < LOW_VBATT) {
// we assume TLE8888 is down and we should not bother with SPI communication
if (!needInitialSpi) {
needInitialSpi = true;
lowVoltageResetCounter++;
}
continue; // we should not bother communicating with TLE8888 until we have +12
}
#endif
// todo: super-lazy implementation with only first chip!
//watchdogLogic(&chips[0]);
if ((chip->cfg == NULL) ||
(chip->drv_state == TLE8888_DISABLED) ||
(chip->drv_state == TLE8888_FAILED))