From 75a77b06f461671bea9526760bf6061ec1535858 Mon Sep 17 00:00:00 2001 From: rusefi Date: Sat, 7 Nov 2020 00:35:56 -0500 Subject: [PATCH] debounce unintended auto-increment bug (was: Proteus TCU gear shift configuration) #1927 --- firmware/config/engines/bmw_m73.cpp | 7 ++++--- firmware/config/engines/mazda_miata_vvt.cpp | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/firmware/config/engines/bmw_m73.cpp b/firmware/config/engines/bmw_m73.cpp index 3109243c10..ba1a87edfb 100644 --- a/firmware/config/engines/bmw_m73.cpp +++ b/firmware/config/engines/bmw_m73.cpp @@ -297,6 +297,7 @@ void setEngineBMW_M73_Proteus(DECLARE_CONFIG_PARAMETER_SIGNATURE) { CONFIG(starterControlPin) = GPIOE_0; // GPIOE_12: "Digital 3" CONFIG(startStopButtonPin) = GPIOE_12; + CONFIG(startStopButtonMode) = PI_PULLUP; // EFI_ADC_12: "Analog Volt 3" @@ -308,9 +309,9 @@ void setEngineBMW_M73_Proteus(DECLARE_CONFIG_PARAMETER_SIGNATURE) { // EFI_ADC_1: "Analog Volt 6" engineConfiguration->throttlePedalPositionAdcChannel = EFI_ADC_1; engineConfiguration->throttlePedalUpVoltage = 0; - engineConfiguration->throttlePedalWOTVoltage = 4.4; - engineConfiguration->throttlePedalSecondaryUpVoltage = 0.5; - engineConfiguration->throttlePedalSecondaryWOTVoltage = 4.4; + engineConfiguration->throttlePedalWOTVoltage = 4.9; + engineConfiguration->throttlePedalSecondaryUpVoltage = 0.73; + engineConfiguration->throttlePedalSecondaryWOTVoltage = 4.9; // EFI_ADC_2: "Analog Volt 7" engineConfiguration->throttlePedalPositionSecondAdcChannel = EFI_ADC_2; diff --git a/firmware/config/engines/mazda_miata_vvt.cpp b/firmware/config/engines/mazda_miata_vvt.cpp index 99121efcfc..8f976572a9 100644 --- a/firmware/config/engines/mazda_miata_vvt.cpp +++ b/firmware/config/engines/mazda_miata_vvt.cpp @@ -722,8 +722,10 @@ void setMiataNB2_Proteus_TCU(DECLARE_CONFIG_PARAMETER_SIGNATURE) { // "Digital 1" green engineConfiguration->tcuUpshiftButtonPin = GPIOC_6; + CONFIG(tcuUpshiftButtonPinMode) = PI_PULLUP; // "Digital 6" white engineConfiguration->tcuDownshiftButtonPin = GPIOE_15; + CONFIG(tcuDownshiftButtonPinMode) = PI_PULLUP; // R config->tcuSolenoidTable[0][0] = 1;