From 7c2cb1d2acfdca2324f1923ee4c7bf7ba02abc78 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Wed, 18 Nov 2020 23:06:44 -0500 Subject: [PATCH] Starter seems to be engaged forever #1965 --- unit_tests/tests/test_start_stop.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/unit_tests/tests/test_start_stop.cpp b/unit_tests/tests/test_start_stop.cpp index d50a769c16..7b271e1d77 100644 --- a/unit_tests/tests/test_start_stop.cpp +++ b/unit_tests/tests/test_start_stop.cpp @@ -13,17 +13,17 @@ TEST(start, startStop) { // this is a pull-up, so 'true' on start-up setMockState(engineConfiguration->startStopButtonPin, true); - ASSERT_EQ(efiReadPin(engineConfiguration->starterControlPin), false); + ASSERT_FALSE(efiReadPin(engineConfiguration->starterControlPin)); slowStartStopButtonCallback(PASS_ENGINE_PARAMETER_SIGNATURE); - ASSERT_EQ(efiReadPin(engineConfiguration->starterControlPin), false); + ASSERT_FALSE(efiReadPin(engineConfiguration->starterControlPin)); eth.smartMoveTimeForwardSeconds(10); - // inverted since pull-up + // hit 'start' button! inverted since pull-up setMockState(engineConfiguration->startStopButtonPin, false); slowStartStopButtonCallback(PASS_ENGINE_PARAMETER_SIGNATURE); - ASSERT_EQ(efiReadPin(engineConfiguration->starterControlPin), true); + ASSERT_TRUE(efiReadPin(engineConfiguration->starterControlPin)); eth.smartMoveTimeForwardSeconds(5); slowStartStopButtonCallback(PASS_ENGINE_PARAMETER_SIGNATURE); @@ -34,7 +34,7 @@ TEST(start, startStop) { eth.smartMoveTimeForwardSeconds(5); slowStartStopButtonCallback(PASS_ENGINE_PARAMETER_SIGNATURE); // todo: FIX THIS, starter wire should go off on timeout! - ASSERT_EQ(efiReadPin(engineConfiguration->starterControlPin), true); + ASSERT_TRUE(efiReadPin(engineConfiguration->starterControlPin)); }