From 80cf7b5ecd2e2abfb0811181a02b7f60bf812c49 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Thu, 11 Nov 2021 17:54:31 -0500 Subject: [PATCH] Overflow in currentTimeMillis and getTimeNowSeconds #3531 --- firmware/controllers/engine_controller.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/firmware/controllers/engine_controller.cpp b/firmware/controllers/engine_controller.cpp index 35f8d8de16..37a4cc2737 100644 --- a/firmware/controllers/engine_controller.cpp +++ b/firmware/controllers/engine_controller.cpp @@ -171,9 +171,12 @@ efitimems_t currentTimeMillis(void) { return US2MS(getTimeNowUs()); } -// todo: this overflows pretty fast! +/** + * Integer number of seconds since ECU boot. + * 31,710 years - would not overflow during our life span. + */ efitimesec_t getTimeNowSeconds(void) { - return currentTimeMillis() / 1000; + return getTimeNowUs() / US_PER_SECOND; } static void resetAccel(void) {