rusefi
/
rusefi-full
mirror of https://github.com/rusefi/rusefi-full.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

pwm perf (#1858) 

* pwm perf

* this trace is now redundant
This commit is contained in:
Matthew Kennedy 2020-10-05 05:23:30 -07:00 committed by GitHub
parent 86b5edecbc
commit aad5d987a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
firmware/controllers/system/timer/pwm_generator_logic.cpp
View File

@ -21,7 +21,7 @@
* We need to limit the number of iterations in order to avoid precision loss while calculating * We need to limit the number of iterations in order to avoid precision loss while calculating
* next toggle time * next toggle time
*/ */
#define ITERATION_LIMIT 1000 #define ITERATION_LIMIT 100
// 1% duty cycle // 1% duty cycle
#define ZERO_PWM_THRESHOLD 0.01 #define ZERO_PWM_THRESHOLD 0.01
@ -123,7 +123,7 @@ static efitick_t getNextSwitchTimeNt(PwmConfig *state) {
* Once 'iteration' gets relatively high, we might lose calculation precision here. * Once 'iteration' gets relatively high, we might lose calculation precision here.
* This is addressed by ITERATION_LIMIT * This is addressed by ITERATION_LIMIT
*/ */
efitick_t timeToSwitchNt = (efitick_t) ((iteration + switchTime) * periodNt); uint32_t timeToSwitchNt = (uint32_t)((iteration + switchTime) * periodNt);
#if DEBUG_PWM #if DEBUG_PWM
scheduleMsg(&logger, "start=%d timeToSwitch=%d", state->safe.start, timeToSwitch); scheduleMsg(&logger, "start=%d timeToSwitch=%d", state->safe.start, timeToSwitch);
@ -175,8 +175,6 @@ void PwmConfig::handleCycleStart() {
* @return Next time for signal toggle * @return Next time for signal toggle
*/ */
efitick_t PwmConfig::togglePwmState() { efitick_t PwmConfig::togglePwmState() {
ScopePerf perf(PE::PwmConfigTogglePwmState);
if (isStopRequested) { if (isStopRequested) {
return 0; return 0;
} }
@ -224,20 +222,6 @@ efitick_t PwmConfig::togglePwmState() {
#if DEBUG_PWM #if DEBUG_PWM
scheduleMsg(&logger, "%s: nextSwitchTime %d", state->name, nextSwitchTime); scheduleMsg(&logger, "%s: nextSwitchTime %d", state->name, nextSwitchTime);
#endif /* DEBUG_PWM */ #endif /* DEBUG_PWM */
// signed value is needed here
// int64_t timeToSwitch = nextSwitchTimeUs - getTimeNowUs();
// if (timeToSwitch < 1) {
// /**
// * We are here if we are late for a state transition.
// * At 12000RPM=200Hz with a 60 toothed wheel we need to change state every
// * 1000000 / 200 / 120 = ~41 uS. We are kind of OK.
// *
// * We are also here after a flash write. Flash write freezes the whole chip for a couple of seconds,
// * so PWM generation and trigger simulation generation would have to recover from this time lag.
// */
// //todo: introduce error and test this error handling warning(OBD_PCM_Processor_Fault, "PWM: negative switch time");
// timeToSwitch = 10;
// }
safe.phaseIndex++; safe.phaseIndex++;
if (safe.phaseIndex == phaseCount || mode != PM_NORMAL) { if (safe.phaseIndex == phaseCount || mode != PM_NORMAL) {

2
firmware/development/perf_trace.h
View File

@ -51,7 +51,7 @@ enum class PE : uint8_t {
EventQueueExecuteCallback, EventQueueExecuteCallback,
PwmGeneratorCallback, PwmGeneratorCallback,
TunerStudioHandleCrcCommand, TunerStudioHandleCrcCommand,
PwmConfigTogglePwmState, Unused,
PwmConfigStateChangeCallback, PwmConfigStateChangeCallback,
Temporary1, Temporary1,
Temporary2, Temporary2,