rusefi
/
rusefi-full
mirror of https://github.com/rusefi/rusefi-full.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix closed loop fuel (#1797) 

* fix

* add a test

* signature
This commit is contained in:
Matthew Kennedy 2020-09-19 00:44:01 -07:00 committed by GitHub
parent d988bdca9f
commit c1699d91d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
firmware/controllers/math/closed_loop_fuel.cpp
View File

@ -66,13 +66,13 @@ static bool shouldCorrect(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
return true; return true;
} }
static bool shouldUpdateCorrection(DECLARE_ENGINE_PARAMETER_SIGNATURE) { bool shouldUpdateCorrection(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
const auto& cfg = CONFIG(stft); const auto& cfg = CONFIG(stft);
// Pause (but don't reset) correction if the AFR is off scale. // Pause (but don't reset) correction if the AFR is off scale.
// It's probably a transient and poorly tuned transient correction // It's probably a transient and poorly tuned transient correction
auto afr = Sensor::get(SensorType::Lambda); auto afr = Sensor::get(SensorType::Lambda).value_or(0) * 14.7f;
if (!afr || afr.value_or(0) < (cfg.minAfr * 0.1f) || afr.value_or(0) > (cfg.maxAfr * 0.1f)) { if (!afr || afr < (cfg.minAfr * 0.1f) || afr > (cfg.maxAfr * 0.1f)) {
return false; return false;
} }

1
firmware/controllers/math/closed_loop_fuel.h
View File

@ -5,3 +5,4 @@
float fuelClosedLoopCorrection(DECLARE_ENGINE_PARAMETER_SIGNATURE); float fuelClosedLoopCorrection(DECLARE_ENGINE_PARAMETER_SIGNATURE);
size_t computeStftBin(int rpm, float load, stft_s& cfg); size_t computeStftBin(int rpm, float load, stft_s& cfg);
bool shouldUpdateCorrection(DECLARE_ENGINE_PARAMETER_SIGNATURE);

17
unit_tests/tests/test_stft.cpp
View File

@ -1,4 +1,5 @@
#include "engine_test_helper.h"
#include "closed_loop_fuel_cell.h" #include "closed_loop_fuel_cell.h"
#include "closed_loop_fuel.h" #include "closed_loop_fuel.h"
@ -79,3 +80,19 @@ TEST(ClosedLoopFuel, CellSelection) {
EXPECT_EQ(3, computeStftBin(4000, 50, cfg)); EXPECT_EQ(3, computeStftBin(4000, 50, cfg));
EXPECT_EQ(3, computeStftBin(10000, 50, cfg)); EXPECT_EQ(3, computeStftBin(10000, 50, cfg));
} }
TEST(ClosedLoopFuel, afrLimits) {
WITH_ENGINE_TEST_HELPER(TEST_ENGINE);
engineConfiguration->stft.minAfr = 100; // 10.0 AFR
engineConfiguration->stft.maxAfr = 180; // 18.0 AFR
Sensor::setMockValue(SensorType::Lambda, 0.1f);
EXPECT_FALSE(shouldUpdateCorrection(PASS_ENGINE_PARAMETER_SIGNATURE));
Sensor::setMockValue(SensorType::Lambda, 1.0f);
EXPECT_TRUE(shouldUpdateCorrection(PASS_ENGINE_PARAMETER_SIGNATURE));
Sensor::setMockValue(SensorType::Lambda, 2.0f);
EXPECT_FALSE(shouldUpdateCorrection(PASS_ENGINE_PARAMETER_SIGNATURE));
}