diff --git a/firmware/config/engines/bmw_e34.cpp b/firmware/config/engines/bmw_e34.cpp index a4eee41ee0..888833c599 100644 --- a/firmware/config/engines/bmw_e34.cpp +++ b/firmware/config/engines/bmw_e34.cpp @@ -77,7 +77,6 @@ void setBmwE34(DECLARE_ENGINE_PARAMETER_SIGNATURE) { // Cranking engineConfiguration->cranking.rpm = 600; engineConfiguration->crankingInjectionMode = IM_BATCH; - engineConfiguration->cranking.baseFuel = 7; // enable constant_dwell engineConfiguration->useConstantDwellDuringCranking = true; engineConfiguration->ignitionDwellForCrankingMs = 6; diff --git a/firmware/config/engines/citroenBerlingoTU3JP.cpp b/firmware/config/engines/citroenBerlingoTU3JP.cpp index bdc2e7b4bb..2e6ae29129 100644 --- a/firmware/config/engines/citroenBerlingoTU3JP.cpp +++ b/firmware/config/engines/citroenBerlingoTU3JP.cpp @@ -89,12 +89,6 @@ void setCitroenBerlingoTU3JPConfiguration(DECLARE_ENGINE_PARAMETER_SIGNATURE) { // memcpy(config->ve2RpmBins, rpmSteps, sizeof(rpmSteps)); - /** - * Cranking fuel setting - * TODO: they recomend using something like -40C for low point and +80C for high point - */ - engineConfiguration->cranking.baseFuel = 15; - /** * Algorithm Alpha-N setting */ diff --git a/firmware/config/engines/dodge_neon.cpp b/firmware/config/engines/dodge_neon.cpp index 09d4d6b32a..48922485a6 100644 --- a/firmware/config/engines/dodge_neon.cpp +++ b/firmware/config/engines/dodge_neon.cpp @@ -167,8 +167,6 @@ void setDodgeNeon1995EngineConfiguration(DECLARE_CONFIG_PARAMETER_SIGNATURE) { // set_cranking_rpm 550 engineConfiguration->cranking.rpm = 550; - // set cranking_fuel 5 - engineConfiguration->cranking.baseFuel = 5; // engineConfiguration->useOnlyRisingEdgeForTrigger = true; @@ -274,13 +272,6 @@ void setDodgeNeonNGCEngineConfiguration(DECLARE_CONFIG_PARAMETER_SIGNATURE) { engineConfiguration->specs.displacement = 1.996; engineConfiguration->specs.cylindersCount = 4; - /** - * that's NGC config - * - * set_cranking_fuel 5 - */ - engineConfiguration->cranking.baseFuel = 5; - engineConfiguration->biQuad.a0 = 0.0000024635293743901; engineConfiguration->biQuad.a1 = 0.00000492705874878021; engineConfiguration->biQuad.a2 = 0.0000024635293743901; diff --git a/firmware/config/engines/dodge_ram.cpp b/firmware/config/engines/dodge_ram.cpp index 32236c32ba..3b85e74c79 100644 --- a/firmware/config/engines/dodge_ram.cpp +++ b/firmware/config/engines/dodge_ram.cpp @@ -60,8 +60,6 @@ void setDodgeRam1996(DECLARE_ENGINE_PARAMETER_SIGNATURE) { engineConfiguration->engineChartSize = 450; - // set cranking_fuel 7 - engineConfiguration->cranking.baseFuel = 7; // set global_trigger_offset_angle -50 engineConfiguration->globalTriggerAngleOffset = -50; diff --git a/firmware/config/engines/ford_aspire.cpp b/firmware/config/engines/ford_aspire.cpp index e5ac191060..27227fb014 100644 --- a/firmware/config/engines/ford_aspire.cpp +++ b/firmware/config/engines/ford_aspire.cpp @@ -92,8 +92,6 @@ void setFordAspireEngineConfiguration(DECLARE_ENGINE_PARAMETER_SIGNATURE) { setThermistorConfiguration(&engineConfiguration->clt, -20, 18000, 23.8889, 2100, 48.8889, 1000); engineConfiguration->clt.config.bias_resistor = 3300; // that's my custom resistor value! - engineConfiguration->cranking.baseFuel = 3; - // engineConfiguration->ignitionPinMode = OM_INVERTED; engineConfiguration->specs.cylindersCount = 4; diff --git a/firmware/config/engines/ford_festiva.cpp b/firmware/config/engines/ford_festiva.cpp index e04f7ec88c..039f7054c8 100644 --- a/firmware/config/engines/ford_festiva.cpp +++ b/firmware/config/engines/ford_festiva.cpp @@ -146,8 +146,6 @@ void setFordEscortGt(DECLARE_ENGINE_PARAMETER_SIGNATURE) { // set cranking_timing_angle 3 engineConfiguration->crankingTimingAngle = 3; engineConfiguration->crankingChargeAngle = 70; - // set cranking_fuel 9 - engineConfiguration->cranking.baseFuel = 9; setLinearCurve(config->ignitionLoadBins, IGN_LOAD_COUNT, 20, 105, 5); setWholeTimingTable_d(10 PASS_CONFIG_PARAMETER_SUFFIX); @@ -197,9 +195,6 @@ void setFordEscortGt(DECLARE_ENGINE_PARAMETER_SIGNATURE) { boardConfiguration->injectionPins[1] = GPIOE_2; - //setDefaultCrankingFuel(engineConfiguration); - engineConfiguration->cranking.baseFuel = 5; - // 40% idle is good default boardConfiguration->idle.solenoidFrequency = 300; boardConfiguration->idle.solenoidPin = GPIOB_9; diff --git a/firmware/config/engines/mazda_miata_1_6.cpp b/firmware/config/engines/mazda_miata_1_6.cpp index 5837b21dd9..8bed90d407 100644 --- a/firmware/config/engines/mazda_miata_1_6.cpp +++ b/firmware/config/engines/mazda_miata_1_6.cpp @@ -163,7 +163,6 @@ void setMiataNA6_MAP_Configuration(DECLARE_ENGINE_PARAMETER_SIGNATURE) { - // cold start works better with baseFuel = 8 // maybe adjust CLT correction? // set cranking_fuel 8 engineConfiguration->cranking.baseFuel = 1; diff --git a/firmware/config/engines/mitsubishi.cpp b/firmware/config/engines/mitsubishi.cpp index 5fbdc3fe23..aac308044c 100644 --- a/firmware/config/engines/mitsubishi.cpp +++ b/firmware/config/engines/mitsubishi.cpp @@ -41,9 +41,6 @@ void setMitsubishiConfiguration(DECLARE_ENGINE_PARAMETER_SIGNATURE) { // set_whole_fuel_map 3 setWholeFuelMap(3 PASS_CONFIG_PARAMETER_SUFFIX); - // set cranking_fuel 4 - engineConfiguration->cranking.baseFuel = 4; - // /** // * 29150 Ohm @ 40C // * 10160 Ohm @ 70C diff --git a/firmware/config/engines/vw.cpp b/firmware/config/engines/vw.cpp index 338cfb7f8d..30218ee2b6 100644 --- a/firmware/config/engines/vw.cpp +++ b/firmware/config/engines/vw.cpp @@ -19,7 +19,6 @@ void setVwAba(DECLARE_ENGINE_PARAMETER_SIGNATURE) { setCustomEngineConfiguration(PASS_ENGINE_PARAMETER_SIGNATURE); setWholeTimingTable_d(20 PASS_CONFIG_PARAMETER_SUFFIX); - engineConfiguration->cranking.baseFuel = 12; // set cranking_timing_angle 10 engineConfiguration->crankingTimingAngle = 10; diff --git a/firmware/controllers/algo/engine_configuration.cpp b/firmware/controllers/algo/engine_configuration.cpp index 612388351e..610fef3873 100644 --- a/firmware/controllers/algo/engine_configuration.cpp +++ b/firmware/controllers/algo/engine_configuration.cpp @@ -521,21 +521,22 @@ static void setDefaultCrankingSettings(DECLARE_ENGINE_PARAMETER_SIGNATURE) { setLinearCurve(engineConfiguration->crankingTpsCoef, CRANKING_CURVE_SIZE, 1, 1, 1); setLinearCurve(engineConfiguration->crankingTpsBins, CRANKING_CURVE_SIZE, 0, 100, 1); - config->crankingFuelCoef[0] = 5; // base cranking fuel adjustment coefficient + config->crankingFuelCoef[0] = 28; // base cranking fuel adjustment coefficient config->crankingFuelBins[0] = -20; // temperature in C - config->crankingFuelCoef[1] = 3.7; + config->crankingFuelCoef[1] = 22; config->crankingFuelBins[1] = -10; - config->crankingFuelCoef[2] = 2.6; + config->crankingFuelCoef[2] = 18; config->crankingFuelBins[2] = 5; - config->crankingFuelCoef[3] = 2.4; - config->crankingFuelBins[3] = 20; - config->crankingFuelCoef[4] = 2.1; + config->crankingFuelCoef[3] = 15; + config->crankingFuelBins[3] = 30; + + config->crankingFuelCoef[4] = 10; config->crankingFuelBins[4] = 35; - config->crankingFuelCoef[5] = 1.8; + config->crankingFuelCoef[5] = 10; config->crankingFuelBins[5] = 50; - config->crankingFuelCoef[6] = 1.1; + config->crankingFuelCoef[6] = 10; config->crankingFuelBins[6] = 65; - config->crankingFuelCoef[7] = 1; + config->crankingFuelCoef[7] = 10; config->crankingFuelBins[7] = 90; config->crankingCycleCoef[0] = 1.5; diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt index 4965e13e25..c782676573 100644 --- a/firmware/integration/rusefi_config.txt +++ b/firmware/integration/rusefi_config.txt @@ -1026,7 +1026,7 @@ float[IAT_CURVE_SIZE] iatFuelCorr;;"%", 1, 0, 0.0, 500.0, 2 float[CRANKING_CURVE_SIZE] crankingFuelBins;;"C", 1, 0, -80.0, 170.0, 2 float[CRANKING_CURVE_SIZE] crankingCycleCoef;;"%", 1, 0, 0.0, 500.0, 2 - float[CRANKING_CURVE_SIZE] crankingCycleBins;;"counter", 1, 0, -80.0, 170.0, 2 + float[CRANKING_CURVE_SIZE] crankingCycleBins;;"counter", 1, 0, -80.0, 170.0, 0 float[CLT_CURVE_SIZE] cltIdleCorrBins;CLT-based idle position multiplier for simple manual idle controller;"C", 1, 0, -100.0, 250.0, 2 float[CLT_CURVE_SIZE] cltIdleCorr; CLT-based idle position multiplier for simple manual idle controller;"%", 1, 0, 0.0, 1000.0, 2 diff --git a/firmware/tunerstudio/rusefi.ini b/firmware/tunerstudio/rusefi.ini index b164c2192c..e5a5e4789c 100644 --- a/firmware/tunerstudio/rusefi.ini +++ b/firmware/tunerstudio/rusefi.ini @@ -68,7 +68,7 @@ enable2ndByteCanID = false ; see PAGE_0_SIZE in C source code ; CONFIG_DEFINITION_START -; this section was generated automatically by ConfigDefinition.jar based on rusefi_config.txt Mon Apr 01 17:18:57 EDT 2019 +; this section was generated automatically by ConfigDefinition.jar based on rusefi_config.txt Thu Apr 04 08:24:40 EDT 2019 pageSize = 20000 page = 1 @@ -880,7 +880,7 @@ page = 1 crankingFuelCoef = array, F32, 10528, [8], "%", 1, 0, 0.0, 700.0, 2 crankingFuelBins = array, F32, 10560, [8], "C", 1, 0, -80.0, 170.0, 2 crankingCycleCoef = array, F32, 10592, [8], "%", 1, 0, 0.0, 500.0, 2 - crankingCycleBins = array, F32, 10624, [8], "counter", 1, 0, -80.0, 170.0, 2 + crankingCycleBins = array, F32, 10624, [8], "counter", 1, 0, -80.0, 170.0, 0 cltIdleCorrBins = array, F32, 10656, [16], "C", 1, 0, -100.0, 250.0, 2 cltIdleCorr = array, F32, 10720, [16], "%", 1, 0, 0.0, 1000.0, 2 mafDecoding = array, F32, 10784, [256], "kg/hour", 1, 0, -500.0, 4000.0, 2 @@ -3020,6 +3020,7 @@ cmd_set_engine_type_default = "w\x00\x31\x00\x00" dialog = crankingFuel, "Fuel" field = "Injection Mode", crankingInjectionMode + field = "!Value '1' is currently recommended" field = "Base Fuel Pulse Width", cranking_baseFuel dialog = crankingIAC, "IAC" diff --git a/firmware/tunerstudio/rusefi.input b/firmware/tunerstudio/rusefi.input index 91c4e6025e..8f38aa4d86 100644 --- a/firmware/tunerstudio/rusefi.input +++ b/firmware/tunerstudio/rusefi.input @@ -2112,6 +2112,7 @@ cmd_set_engine_type_default = "w\x00\x31\x00\x00" dialog = crankingFuel, "Fuel" field = "Injection Mode", crankingInjectionMode + field = "!Value '1' is currently recommended" field = "Base Fuel Pulse Width", cranking_baseFuel dialog = crankingIAC, "IAC"