refactoring
This commit is contained in:
parent
760e55e8d2
commit
ce402a7cae
|
@ -7,6 +7,7 @@ import com.rusefi.NamedThreadFactory;
|
|||
import com.rusefi.binaryprotocol.BinaryProtocol;
|
||||
import com.rusefi.binaryprotocol.BinaryProtocolState;
|
||||
import com.rusefi.core.EngineState;
|
||||
import com.rusefi.core.MessagesCentral;
|
||||
import com.rusefi.io.serial.StreamConnector;
|
||||
import com.rusefi.io.serial.SerialIoStreamJSerialComm;
|
||||
import com.rusefi.io.tcp.TcpConnector;
|
||||
|
@ -205,6 +206,7 @@ public class LinkManager implements Closeable {
|
|||
Callable<IoStream> streamFactory = new Callable<IoStream>() {
|
||||
@Override
|
||||
public IoStream call() {
|
||||
MessagesCentral.getInstance().postMessage(getClass(), "Opening port: " + port);
|
||||
Socket socket;
|
||||
try {
|
||||
int portPart = TcpConnector.getTcpPort(port);
|
||||
|
@ -220,12 +222,13 @@ public class LinkManager implements Closeable {
|
|||
}
|
||||
};
|
||||
|
||||
setConnector(new StreamConnector(this, port, streamFactory));
|
||||
setConnector(new StreamConnector(this, streamFactory));
|
||||
isSimulationMode = true;
|
||||
} else {
|
||||
Callable<IoStream> ioStreamCallable = new Callable<IoStream>() {
|
||||
@Override
|
||||
public IoStream call() {
|
||||
MessagesCentral.getInstance().postMessage(getClass(), "Opening port: " + port);
|
||||
IoStream stream = ((Callable<IoStream>) () -> SerialIoStreamJSerialComm.openPort(port)).call();
|
||||
if (stream == null) {
|
||||
// error already reported
|
||||
|
@ -234,7 +237,7 @@ public class LinkManager implements Closeable {
|
|||
return stream;
|
||||
}
|
||||
};
|
||||
setConnector(new StreamConnector(this, port, ioStreamCallable));
|
||||
setConnector(new StreamConnector(this, ioStreamCallable));
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
@ -3,7 +3,6 @@ package com.rusefi.io.serial;
|
|||
import com.devexperts.logging.Logging;
|
||||
import com.rusefi.Callable;
|
||||
import com.rusefi.binaryprotocol.BinaryProtocol;
|
||||
import com.rusefi.core.MessagesCentral;
|
||||
import com.rusefi.io.ConnectionStateListener;
|
||||
import com.opensr5.io.DataListener;
|
||||
import com.rusefi.io.IoStream;
|
||||
|
@ -25,30 +24,23 @@ public class PortHolder {
|
|||
private static final Logging log = getLogging(PortHolder.class);
|
||||
|
||||
private final DataListener dataListener;
|
||||
private final Callable<IoStream> ioStreamCallable;
|
||||
private final Callable<IoStream> ioStreamFactory;
|
||||
private final LinkManager linkManager;
|
||||
|
||||
public ConnectionStateListener listener;
|
||||
private final Object portLock = new Object();
|
||||
private final String port;
|
||||
|
||||
@Nullable
|
||||
private BinaryProtocol bp;
|
||||
|
||||
protected PortHolder(String port, LinkManager linkManager, Callable<IoStream> ioStreamCallable) {
|
||||
this.port = port;
|
||||
protected PortHolder(LinkManager linkManager, Callable<IoStream> ioStreamFactory) {
|
||||
this.linkManager = linkManager;
|
||||
dataListener = freshData -> linkManager.getEngineState().processNewData(new String(freshData), LinkManager.ENCODER);
|
||||
this.ioStreamCallable = ioStreamCallable;
|
||||
this.ioStreamFactory = ioStreamFactory;
|
||||
}
|
||||
|
||||
boolean connectAndReadConfiguration() {
|
||||
if (port == null)
|
||||
return false;
|
||||
|
||||
MessagesCentral.getInstance().postMessage(getClass(), "Opening port: " + port);
|
||||
|
||||
IoStream stream = ioStreamCallable.call();
|
||||
IoStream stream = ioStreamFactory.call();
|
||||
if (stream == null) {
|
||||
// error already reported
|
||||
return false;
|
||||
|
|
|
@ -21,10 +21,10 @@ public class StreamConnector implements LinkConnector {
|
|||
private final PortHolder portHolder;
|
||||
private final LinkManager linkManager;
|
||||
|
||||
public StreamConnector(LinkManager linkManager, String portName, Callable<IoStream> ioStreamCallable) {
|
||||
public StreamConnector(LinkManager linkManager, Callable<IoStream> ioStreamCallable) {
|
||||
this.linkManager = linkManager;
|
||||
|
||||
portHolder = new PortHolder(portName, linkManager, ioStreamCallable);
|
||||
portHolder = new PortHolder(linkManager, ioStreamCallable);
|
||||
}
|
||||
|
||||
@Override
|
||||
|
|
Loading…
Reference in New Issue