Commit Graph

363 Commits

Author SHA1 Message Date
Matthew Kennedy 5f3464b204
Fix prepareEventAngles for symmetrical crank triggers (#2982)
* fix and make code legible

* update test to check every tooth

* symmetrical crank

* simplify findTriggerPosition

* make getAngle intelligable
2021-07-17 23:27:20 -04:00
Andrey 9345e5d2e0 NB2 trigger shape does not seem to match JimStim #2980
only first steps of unit test
2021-07-17 17:47:32 -04:00
rusefillc 6da3310d97 kaiju is asking for vq30de trigger wheel decoder #2974 2021-07-17 02:03:55 -04:00
Andrey 180d7bc899 kaiju is asking for vq30de trigger wheel decoder #2974 2021-07-17 01:10:13 -04:00
Andrey ffe2fe3271 refactoring 2021-07-17 00:56:50 -04:00
Andrey d583c91a7a refactoring 2021-07-17 00:53:51 -04:00
Andrey d16d6dd58d kaiju is asking for vq30de trigger wheel decoder #2974 2021-07-17 00:46:39 -04:00
Andrey f54b3cd1b2 refactoring 2021-07-17 00:46:39 -04:00
Andrey df558303d3 kaiju is asking for vq30de trigger wheel decoder #2974 2021-07-17 00:27:56 -04:00
Matthew Kennedy 2ce7777865
don't require EXTERN_ENGINE in every file (#2969)
* move enginePins

* no more extern engine

* uses

* more

* extern config too

* put this where it belongs

* include correct header

* merge
2021-07-16 18:13:33 -04:00
rusefillc 090725d273 reducing warnings 2021-07-13 14:50:10 -04:00
Andrey 293bf45763 refactoring - reusing magic constant 2021-07-05 23:07:36 -04:00
Andrey 1660a5b3fd Nissan progress 2021-07-02 19:57:26 -04:00
Andrey ab8bb3a5cb Nissan VVT trigger decoder #2887 2021-07-01 23:53:53 -04:00
Andrey ae7937402c Nissan VVT trigger decoder #2887 2021-07-01 22:27:43 -04:00
Andrey fccd13247b Nissan VVT trigger decoder #2887 2021-07-01 21:48:47 -04:00
Matthew Kennedy 025c32de00
Stricter miata sync (#2891)
* strict mazda trigger shape

* this is an even better gap

* sync point moved so things are different now

* fix

* update instantrpm in test

* s

* s

* this is safer

* test

* tests

* instant rpm

* cleanup
2021-07-01 21:29:04 -04:00
Andrey 50e25605b8 Nissan VVT trigger decoder #2887 2021-07-01 17:28:52 -04:00
Andrey 41060a1235 VW warnings on cranking #2861
same resilience for some other triggers
2021-06-27 13:29:09 -04:00
Andrey 2e252022aa VW warnings on cranking #2861 2021-06-27 12:31:18 -04:00
Andrey eaff083377 refactoring - explicit read method 2021-06-26 22:17:07 -04:00
Andrey 1822426d0c refactoring - explicit read method 2021-06-26 22:11:42 -04:00
Andrey a5eeb19c4d refactoring - explicit read method 2021-06-26 22:07:45 -04:00
rusefillc 0af5de0934
Minor change of Miata NA trigger shape #2855 #669 (#2856)
* Minor change of Miata NA trigger shape #2855 #669

* Minor change of Miata NA trigger shape #2855 #669
2021-06-25 14:12:18 -04:00
Andrey 3092164e48 Minor change of Miata NA trigger shape #2855 #669 2021-06-24 22:21:30 -04:00
Andrey 03f18cd0c8 OMG dead code?! 2021-06-24 22:01:57 -04:00
Andrey c13bb8dbe1 looks like this parameter is very well used now? 2021-06-21 02:12:14 -04:00
Andrey G e561836c58
trigger: subaru 7+6: update cranck angles, add comments (#2789) 2021-06-02 19:19:52 +03:00
Andrey G 8ee700bf76
Subaru svx (#2777)
* Revert "hiding 3rd channel for now"

This reverts commit 50682816ac.

* trigger subaru SVX: disable cranck #2 channel

* Board subaru-eg33: fix D10 pin defined twice

* Board subaru-eg33: renumber ignition ouput according cylinder order

* board subaru eg33: use common_make.sh to get dfu files

* board subaru-eg33: update default configuration
2021-05-31 04:25:57 -04:00
Andrey 39bc62ff2e SVX 2021-05-30 19:59:13 -04:00
Andrey 50682816ac hiding 3rd channel for now 2021-05-29 04:09:12 -04:00
Andrey 4216080e49 subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021 2021-05-26 06:07:31 -04:00
Andrey 9f6ed75582 subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021 2021-05-26 05:29:41 -04:00
Andrey 2581a53e0d subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021 2021-05-26 04:46:17 -04:00
Andrey 0ad11168e8 Override trigger gaps feature #2734 2021-05-25 17:19:20 -04:00
rusefillc cc861e1862 Subaru 7+6 trigger refactoring, not changing gap ratio much 2021-05-25 16:31:37 -04:00
Andrey cd5653ff84 Override trigger gaps feature #2734 2021-05-23 20:52:18 -04:00
Andrey 17f07b6b0e Override trigger gaps feature #2734 2021-05-23 19:51:00 -04:00
David Holdeman 6d4060d824
Doxygen titles (#2728)
* move addRow call

* undo submo bump

* add header titles
2021-05-22 22:10:58 +03:00
rusefillc 2575c8beeb Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2021-04-30 01:05:23 -04:00
rusefillc ac2d0b99cd https://rusefi.com/forum/viewtopic.php?f=2&t=1993 2021-04-24 22:54:50 -04:00
Matthew Kennedy a70f113b77
finish it off: remove scheduleMsg (#2575)
* finish it off

* one more logger ptr

* fwd decl

* Revert "one more logger ptr"

This reverts commit a21fb0087ddc748978d716db2710800cf26e437b.

* unused

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 15:33:40 -04:00
Matthew Kennedy c26987b96b
Destroy all shared logger (#2574)
* most of shared logger

* a few more

* one more

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 14:28:48 -04:00
Matthew Kennedy ad71016862
rip the bandaid: find-replace most of scheduleMsg (#2572)
* biiiig find replace

* more trivial find replace

* pwm

* almost all of them

* few more

* gpio

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 12:53:13 -04:00
rusefillc 2b6345070f WOW major scheduling drama on NB2 running with Proteus #2533 2021-04-15 19:12:09 -04:00
rusefillc 2b8ec15071 WOW major scheduling drama on NB2 running with Proteus #2533
totally same numbers for NB1 just simpler code
2021-04-15 18:44:37 -04:00
rusefillc 3c6c4595c2 WOW major scheduling drama on NB2 running with Proteus #2533
removing weird comments
2021-04-15 18:22:23 -04:00
rusefillc 79e0d6ebd4 dead code - same value set by 's->initialize' 2021-04-13 01:11:03 -04:00
rusefillc 01344ec851 Kawasaki KX450F trigger wheel #2538 2021-04-13 00:24:52 -04:00
rusefillc 027a9efdc8 https://rusefi.com/forum/viewtopic.php?p=40383 2021-04-11 18:20:35 -04:00
rusefillc debd15991e Kawasaki KX450F trigger wheel #2538 2021-04-09 12:44:28 -04:00
rusefillc 2032e5fdb8 Kawasaki KX450F trigger wheel #2538 2021-04-08 22:16:14 -04:00
Matthew Kennedy 5e88376e2c
barra vvt cam pattern (#2483)
* barra vvt cam pattern

* two tooth sync

* I think this needs to be here too
2021-03-22 07:48:29 -04:00
Andrey G 89b631a794
Hip9011 and cleanups (#2477)
* hip9011: move hipCs out of EnginePins to hip9011 driver

* hip9011: cleanup debug output, save few RAM bytes

* Supress few signed vs unsigned warnings
2021-03-20 08:40:36 -04:00
Matthew Kennedy be70524ced
harden against various no-boot scenarios (#2468)
* zero length trigger

* validate config

* validate cylinder count

* wrong type on cylinder count

* invalid comment

* invalid SPI
2021-03-17 09:24:13 -04:00
rusefillc 4e35176e81 TDC Trigger Position #2428
any single-tooth primary trigger should automatically run with "useOnlyPrimaryForSync = true;"
2021-03-08 00:00:48 -05:00
rusefillc e4bd0f6815 removing dead code - initialize() sets 'true' already 2021-03-07 23:37:54 -05:00
rusefillc 953990d10b Trigger pattern request Škoda Favorit fix #2302 2021-02-06 20:53:30 -05:00
rusefillc d95ba6b443 Trigger pattern request Škoda Favorit #2302 2021-02-06 20:12:58 -05:00
rusefillc 29db28f077 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-02 11:06:32 -05:00
rusefillc 8ff61e9e68 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-02 09:50:20 -05:00
rusefillc 7eb5816c33 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-01 23:44:14 -05:00
rusefillc 11f9bf16f6 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-01 23:18:11 -05:00
rusefillc 9a2cc6b3c9 GM/Daewoo 60/2/2/2 Trigger Pattern #2264 2021-02-01 22:49:49 -05:00
rusefi 10e980e293 Revert "Save more space in the angle cache (#2228)"
This reverts commit c7ca1b2e
2021-01-18 18:53:00 -05:00
Matthew Kennedy c7ca1b2ef4
Save more space in the angle cache (#2228)
* store event angles in a scaled field

* tests

* comment
2021-01-18 18:31:06 -05:00
Matthew Kennedy 6a1b9db952
save 1440 bytes (#2226) 2021-01-16 21:22:30 -05:00
Matthew Kennedy 60f70a3721
clean up some includes (#2227)
* cleanup

* make c happy
2021-01-16 09:45:45 -05:00
Matthew Kennedy a5266cd6ef
part of 2217 which may fix it alone (#2220) 2021-01-11 08:01:54 -05:00
rusefillc 6c01aedbb0 RAM efficiency of VR crank trigger shapes #2182
Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912
2021-01-04 23:44:31 -05:00
rusefillc 8c38664084 RAM efficiency of VR crank trigger shapes #2182
Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912
2021-01-04 23:34:19 -05:00
rusefillc 9b5d45cb04 Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912 2021-01-04 21:05:16 -05:00
rusefillc b1499d8a7f RAM efficiency of VR crank trigger shapes #2182 2021-01-04 00:26:05 -05:00
rusefillc b3e3248d71 Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912 2021-01-03 14:05:24 -05:00
rusefillc 15665484e5 Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912 2021-01-03 13:52:53 -05:00
rusefillc 8f06008239 Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912 2021-01-03 13:34:00 -05:00
rusefillc 314e9ef580 TT_SUBARU_7_WITHOUT_6 2020-12-13 17:46:48 -05:00
rusefi eae865d4de subi ops 2020-12-13 16:41:53 -05:00
rusefi f8803da107 poke 2020-12-13 16:31:47 -05:00
rusefi 38bcd63e13 maybe this would just work? 2020-12-13 16:22:02 -05:00
rusefillc 64fdfba435 dead code 2020-12-10 21:45:25 -05:00
rusefillc 9400af5452 GM x24 is a well defined trigger needs hard-coded tdcPosition fix #2054 2020-12-10 19:38:33 -05:00
rusefillc e6bfd9a2ed trigger lifecycle 2020-12-09 12:19:25 -05:00
rusefillc 6200569f28 6.1 Hemi V8 decoder fix #2010 2020-12-04 16:50:26 -05:00
rusefillc eaba91e1fd 6.1 Hemi V8 decoder #2010 2020-12-04 16:33:29 -05:00
rusefillc be2a34a956 refactoring: magic constants 2020-12-04 16:24:19 -05:00
rusefillc 2524b7b8c2 6.1 Hemi V8 decoder #2010 2020-12-04 16:03:27 -05:00
rusefillc e730c2c0b1 6.1 Hemi V8 decoder #2010 2020-12-04 15:33:07 -05:00
rusefillc 9221a12d95 6.1 Hemi V8 decoder #2010 2020-12-04 15:22:53 -05:00
rusefillc 61925aad15 all triggers should be documented way nicer #2001 2020-12-04 14:00:49 -05:00
rusefillc 6496fd5a64 all triggers should be documented way nicer #2001 2020-12-04 13:54:16 -05:00
rusefillc 8e13892736 6.1 Hemi V8 decoder #2010 2020-12-04 01:02:09 -05:00
rusefillc 0a23e82baf 6.1 Hemi V8 decoder #2010 2020-12-04 00:30:22 -05:00
rusefillc 4c3eae5676 FORD ST170 CAM TRIGGER PATTERN fix #2009 2020-12-03 23:54:08 -05:00
rusefillc f021c37cc1 DAIHATSU 3CYLINDER TRIGGER WHEEL SUPPORT fix #2008 2020-12-03 23:12:30 -05:00
rusefillc c55120372b DAIHATSU 3CYLINDER TRIGGER WHEEL SUPPORT #2008 2020-12-03 21:31:58 -05:00
rusefillc 745038c4a7 more dead code 2020-12-03 10:49:20 -05:00
rusefillc dd9e431782 dead code matches Mazda SOHC 2020-12-03 01:36:43 -05:00
rusefillc a2036ebc70 dead trigger, this would now be vvt+60/2 2020-12-03 01:22:57 -05:00
rusefillc 0ba97379fb all triggers should be documented way nicer #2001 2020-12-02 22:17:38 -05:00
Matthew Kennedy a9e2a5cd1e
fix (#1863) 2020-10-07 14:59:24 -04:00
Matthew Kennedy 5925a5f4bd
const ref-ify trigger (#1856)
* const ref-ify

* tests
2020-10-05 14:22:59 -04:00
rusefillc 348b387483 Trigger performance: variable gapTrackingLength #1851
cool change but looks to have made zero difference
2020-10-04 13:05:49 -04:00
rusefi 23e0851101 adding 1+16 trigger 2020-09-28 21:18:47 -04:00
rusefi 10a6661fa5 VVT support for VAG trigger #883 2020-08-26 23:35:11 -04:00
rusefi e4386be937 VVT support for VAG trigger #883 2020-08-26 20:57:11 -04:00
rusefi 2ddf6ad717 VVT support for VAG trigger #883 2020-08-25 16:19:23 -04:00
rusefi 639e5be4d9 another attempt at dead code 2020-08-25 15:58:56 -04:00
rusefi b09091774a VVT support for VAG trigger #883 2020-08-25 12:45:18 -04:00
rusefi bfd5fb88d5 oh, here it is 2020-08-25 01:38:56 -04:00
rusefi b5098eb331 VVT support for VAG trigger #883 2020-08-25 01:24:15 -04:00
rusefi 540eef5e0d VVT support for VAG trigger #883 2020-08-25 00:59:07 -04:00
rusefi 5f5a16867a VVT support for VAG trigger #883
a bit of dead code?
2020-08-24 02:31:27 -04:00
rusefi e936c2742c self-stimulation RPM is wrong by 50% if switching from NA6 to NB2 configuration fix #1682 2020-08-08 17:00:14 -04:00
Matthew Kennedy b11c5cd8c8
switch some firmware warnings to errors (#1465)
* warnings as errors

* throw instead of exit

* test massaging

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-23 10:46:28 -04:00
dron0gus a2565b7849
triggers: add Subaru SVX trigger (3 sensors) (#1433) 2020-05-14 20:40:47 -04:00
rusefi 8d91cc65cc 34-2 3 cam Toyota wheel progress 2020-05-09 23:47:51 -04:00
rusefi e451e3c4aa 34-2 3 cam Toyota wheel 2020-05-09 01:51:04 -04:00
rusefi 4ea0a3de26 nicer error messages 2020-05-09 01:49:17 -04:00
rusefi 6661c66e62 34-2 3 cam Toyota wheel progress 2020-05-09 01:15:55 -04:00
rusefi 3575962da6 docs 2020-05-04 22:31:47 -04:00
rusefi e18ee8c097 Bosch vvt shape #1368 2020-04-25 22:23:53 -04:00
rusefi 23e3d05d35 Bosch vvt shape #1368
skeleton
2020-04-25 19:50:43 -04:00
rusefi 387643047f docs 2020-04-20 23:44:59 -04:00
rusefi bae38f03ce docs 2020-04-20 22:42:34 -04:00
rusefi 71e7fb7e50 TT_RENIX_66_2_2_2 2020-04-19 14:54:02 -04:00
rusefi b287b2f339 TT_HONDA_K_12_1 2020-04-19 14:23:01 -04:00
rusefi c665e6b65d progress towards renix 66-2-2-2 2020-04-19 09:59:55 -04:00
rusefi be497685a0 Renix 44-2-2 2020-04-18 22:20:17 -04:00
rusefi 114b34a583 better trigger definition API 2020-04-18 20:28:03 -04:00
rusefi c166ee9d58 Fresh generated - auto 2020-04-18 16:40:59 -04:00
rusefi 907b80efa9 code style 2020-04-01 19:00:56 -04:00
rusefi a33d479683 CLT stops working when using 2-0 custom trigger wheel #1171 2020-03-06 01:31:04 -05:00
Matthew Kennedy 986b80671b
warnings (#1169) 2020-03-03 08:37:02 -05:00
rusefi ed2b7578a5 Merge remote-tracking branch 'remotes/origin/2019.12.25_release_1.19.12_xmas' 2020-02-14 10:50:50 -05:00
rusefi 75d9417131 miata vvt trigger decoding is broken #1145 2020-02-14 00:37:36 -05:00
rusefi 0d1f45422e cam/vvt decoder 2020-02-05 01:49:33 -05:00
rusefi 0c3f73c2b4 code style 2020-01-21 01:47:58 -05:00
rusefi 53433c88a7 trigger shape constraint validation 2020-01-14 03:54:46 -05:00
rusefi 27c44f08f4 reducing complexity? 2020-01-13 22:25:51 -05:00
rusefi 4cc206a393 reducing complexity 2020-01-13 22:23:46 -05:00
rusefi bb217b01dd happy new year unification 2020-01-13 21:57:43 -05:00
rusefi 713ccf76bb header style 2020-01-13 02:30:49 -05:00
rusefi 0bab01369a refactoring: no need to specify parameter manually 2020-01-12 10:43:02 -05:00
rusefi 113fc4be36 refactoring 2020-01-12 05:17:42 -05:00
rusefi b83a5310be happy new year 2020-01-08 00:02:40 -05:00
rusefi 9403b2a8fc fixing build is my most favourite time! 2019-12-13 18:02:24 -05:00
rusefi c5cfd21a70 just a trivial massive rename: TriggerState > TriggerWaveform 2019-12-08 01:09:39 -05:00
rusefi 28a12d9d04 typo 2019-12-06 00:07:27 -05:00
rusefi 813b6aa6ce The Big Refactoring of 2019: folder structure #723 2019-12-04 01:11:10 -05:00