d4c4db9a12
Move phaseCount into MultiChannelStateSequence ( #3520 )
...
We can them drop the field from a bunch of callers, simplifying the code.
2021-11-10 19:47:27 -05:00
1db9a02f1d
Revert "Don't keep a separate MultiChannelStateSequence for the trigger emulator. ( #3513 )"
...
This reverts commit 280dfa94e7
2021-11-09 20:42:23 -05:00
280dfa94e7
Don't keep a separate MultiChannelStateSequence for the trigger emulator. ( #3513 )
...
All it wants is to use the main trigger state, so don't bother copying it. Instead, change
PwmConfig to take a const pointer to a Multi.*Sequence, then make all the users adapt. Worse
fallout is that SimplePwm now has its own Multi.*Sequence, but PwmConfig is downgraded to a
pointer, so that's only a net +4 bytes. And we can make the overhead of Multi.*Sequence much lower
using embedded arrays, which only the caller can do since it knows the maximum size... (for another
day...)
Also remove SimplePwm's 2nd copy of SingleChannelStateSequence. It served no purpose.
Saves 1992 bytes of BSS and 24 bytes of RAM4 (latter probably due to SimplePwm change)
2021-11-09 14:35:07 -05:00
158f719d95
Save ~2800 bytes of RAM by not caching angle->trigger mapping ( #3506 )
...
Memory seems more valuable than CPU; use the O(lg n) lookup by angle. A side effect is that it
seems to fix trigger lookup for the second phase of TRIGGERTYPE 53 544 TT_TRI _TACH 0.00
2021-11-09 07:03:27 -05:00
9ac1575777
reducing complexity
2021-11-07 01:57:32 -05:00
5de6c2a270
typo
2021-11-07 01:51:05 -05:00
20784db801
refactoring - magic constant bad
...
cypress and kinetis both have this macro already
2021-11-07 01:34:16 -04:00
0af09f596c
refactoring - magic constant bad
...
cypress and kinetis both have this macro already
2021-11-07 01:28:28 -04:00
656b8c3429
refactoring - magic constant bad
2021-11-07 00:03:16 -04:00
a6a969390f
Honda K cam wheels #3405
2021-10-28 19:26:59 -04:00
de350131e6
Honda K cam wheels #3405
2021-10-28 11:40:31 -04:00
c72bd07179
enable address sanitizer ( #3217 )
...
* enable asan
* lua
* this is dead and leaky
* leaky nissan
* fix pwm generator use-after-stack
* initializers
* prevent problems in case of invalid trigger shape
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-09-05 05:56:59 -04:00
9345e5d2e0
NB2 trigger shape does not seem to match JimStim #2980
...
only first steps of unit test
2021-07-17 17:47:32 -04:00
f54b3cd1b2
refactoring
2021-07-17 00:46:39 -04:00
090725d273
reducing warnings
2021-07-13 14:50:10 -04:00
eaff083377
refactoring - explicit read method
2021-06-26 22:17:07 -04:00
a5eeb19c4d
refactoring - explicit read method
2021-06-26 22:07:45 -04:00
17f07b6b0e
Override trigger gaps feature #2734
2021-05-23 19:51:00 -04:00
a70f113b77
finish it off: remove scheduleMsg ( #2575 )
...
* finish it off
* one more logger ptr
* fwd decl
* Revert "one more logger ptr"
This reverts commit a21fb0087ddc748978d716db2710800cf26e437b.
* unused
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 15:33:40 -04:00
c26987b96b
Destroy all shared logger ( #2574 )
...
* most of shared logger
* a few more
* one more
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 14:28:48 -04:00
7eb5816c33
GM/Daewoo 60/2/2/2 Trigger Pattern #2264
2021-02-01 23:44:14 -05:00
10e980e293
Revert "Save more space in the angle cache ( #2228 )"
...
This reverts commit c7ca1b2e
2021-01-18 18:53:00 -05:00
c7ca1b2ef4
Save more space in the angle cache ( #2228 )
...
* store event angles in a scaled field
* tests
* comment
2021-01-18 18:31:06 -05:00
6a1b9db952
save 1440 bytes ( #2226 )
2021-01-16 21:22:30 -05:00
60f70a3721
clean up some includes ( #2227 )
...
* cleanup
* make c happy
2021-01-16 09:45:45 -05:00
e6bfd9a2ed
trigger lifecycle
2020-12-09 12:19:25 -05:00
be2a34a956
refactoring: magic constants
2020-12-04 16:24:19 -05:00
2524b7b8c2
6.1 Hemi V8 decoder #2010
2020-12-04 16:03:27 -05:00
e730c2c0b1
6.1 Hemi V8 decoder #2010
2020-12-04 15:33:07 -05:00
9221a12d95
6.1 Hemi V8 decoder #2010
2020-12-04 15:22:53 -05:00
0ba97379fb
all triggers should be documented way nicer #2001
2020-12-02 22:17:38 -05:00
5925a5f4bd
const ref-ify trigger ( #1856 )
...
* const ref-ify
* tests
2020-10-05 14:22:59 -04:00
348b387483
Trigger performance: variable gapTrackingLength #1851
...
cool change but looks to have made zero difference
2020-10-04 13:05:49 -04:00
e4386be937
VVT support for VAG trigger #883
2020-08-26 20:57:11 -04:00
b09091774a
VVT support for VAG trigger #883
2020-08-25 12:45:18 -04:00
540eef5e0d
VVT support for VAG trigger #883
2020-08-25 00:59:07 -04:00
5f5a16867a
VVT support for VAG trigger #883
...
a bit of dead code?
2020-08-24 02:31:27 -04:00
b287b2f339
TT_HONDA_K_12_1
2020-04-19 14:23:01 -04:00
114b34a583
better trigger definition API
2020-04-18 20:28:03 -04:00
986b80671b
warnings ( #1169 )
2020-03-03 08:37:02 -05:00
53433c88a7
trigger shape constraint validation
2020-01-14 03:54:46 -05:00
0bab01369a
refactoring: no need to specify parameter manually
2020-01-12 10:43:02 -05:00
b83a5310be
happy new year
2020-01-08 00:02:40 -05:00
c5cfd21a70
just a trivial massive rename: TriggerState > TriggerWaveform
2019-12-08 01:09:39 -05:00
28a12d9d04
typo
2019-12-06 00:07:27 -05:00
813b6aa6ce
The Big Refactoring of 2019: folder structure #723
2019-12-04 01:11:10 -05:00
6f50cae286
improving API?
2019-11-24 00:15:44 -05:00
f0c4817e1b
'triggerEventAngle' not really needed
2019-11-23 17:44:44 -05:00
ad7e36c228
refactoring
2019-11-20 01:35:08 -05:00
7dfdfc6378
docs & code formatting
2019-11-19 18:17:03 -05:00
Scott Smith
rusefillc
Andrey
Matthew Kennedy