Matthew Kennedy
76f5832db9
resolve VVT phase using every tooth, not just sync point ( #4434 )
...
* resolve VVT phase using every tooth, not just sync point
* fix tests
* comment
* changelog
2022-08-12 08:08:23 -04:00
Matthew Kennedy
e9d092f975
big delete ICU ( #4270 )
...
* big delete
* icu vestiges
* changelog
2022-07-07 15:27:59 -04:00
Matthew Kennedy
c0f290b922
Injector scheduled by angle, not tooth index ( #4208 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
* injection doesn't care about teeth
* fix up existing tests
* oh look, we can actually test this logic now without trying to depend on trigger shape!!!
* fix a real bug
* simplify
2022-06-24 17:43:23 -04:00
Matthew Kennedy
fcd3d991ee
trigger tweaks cleanup ( #4278 )
...
* simplify some math
* we say yes to the todo
* and put back that test
* test
2022-06-23 23:11:29 -04:00
rusefi
dacc43acad
verbose trigger sync should reuse engineSnifferRpmThreshold #4259
...
docs
2022-06-18 14:44:21 -04:00
rusefi
a552d58d42
verbose trigger sync should reuse engineSnifferRpmThreshold #4259
...
reducing complexity
2022-06-18 14:17:36 -04:00
rusefillc
6c1d2a297e
more into "triggerinfo"
2022-06-17 22:10:48 -04:00
Matthew Kennedy
4ada633206
Remove third trigger channel ( #4226 )
...
* remove third trigger
* clean up the honda mess
* there was nothing novel about this engine config
* include
* missed a few
* s
* x
* changelog
* don't set the third trigger input
* don't redefine the same thing 3 times
* only two inputs!
* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy
c0d8cbfef4
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00
Matthew Kennedy
70c2689f1e
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
Matthew Kennedy
d5a4804993
remove dead useOnlyFirstChannel ( #4211 )
...
* This field was ignored.
* move pad out
* gone
2022-05-30 07:03:40 -04:00
Matthew Kennedy
66fffee321
More trigger encapsulation ( #4207 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
Matthew Kennedy
e8be471b46
bail from trigger_central ( #4210 )
2022-05-29 10:42:08 -04:00
Matthew Kennedy
720c463ffb
trigger decoder returns a result ( #4206 )
2022-05-28 09:01:45 -04:00
Matthew Kennedy
fe77f5127e
12 tooth crank mode ( #4179 )
...
* 12 tooth crank
* comment
* s
* rusefi config
2022-05-17 21:38:24 -04:00
Matthew Kennedy
170d574a5d
move logic in to trigger decoder ( #4162 )
...
* move logic in to trigger decoder
* status loop
* minor cleanup
* s
2022-05-10 23:55:28 +03:00
Matthew Kennedy
d4509cab8a
TriggerState -> TriggerDecoder ( #4157 )
2022-05-10 11:41:39 +03:00
Matthew Kennedy
5eb5b7cfbb
phase resolution rpm limit ( #4156 )
2022-05-10 07:22:50 +03:00
Matthew Kennedy
7f5672aaec
encapsulate stuff properly ( #4154 )
2022-05-09 15:46:36 -04:00
rusefillc
bd8459875d
refactoring: bringing method names up to date
2022-05-08 09:04:27 -04:00
rusefillc
bd9639b91d
Remove value copy from controller into outputChannels #4095
2022-05-08 08:50:27 -04:00
Matthew Kennedy
e4a0979dc2
Brain pin is enum class ( #4108 )
...
* change most usages to Gpio::
* board configs
* engine configs etc
* isBrainPinValid, smart gpio
* generator
* generator
* generator
* connector yamls
* kinetis enums
* cypress txt
* kinetis config
* frankenso
* config generator
* actually do it for the others
* disable skips for pr ci
* fix tle8888
* misc
* weird cast from int
* needs this operator too
* this can be an unsigned subtract
* happy tests
* s
* kinetis isConfigurationChanged weirdness
* missed J/K
* cypress efifeatures
* build script mistake (!)
* mistake in smart gpio
* debounce
* eg33
* kinetis, so needy
* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
rusefillc
838e8d8ddb
Remove value copy from controller into outputChannels #4095
2022-04-23 19:53:05 -04:00
rusefillc
71275e841b
m_hasSynchronizedSymmetrical handling improvements #4099 ( #4101 )
2022-04-23 19:45:29 -04:00
rusefillc
b9769f59cc
i will confess: i need to fit a debug build into discovery
2022-04-16 17:24:31 -04:00
Andrey
204ac3961b
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
...
WOW it works?!
2022-04-03 02:30:43 -04:00
Andrey
c2a97343f2
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 01:11:53 -04:00
rusefillc
6b5747d4c8
refactoring: method rename
2022-04-02 21:01:29 -04:00
rusefillc
b1de262520
toothed previous time #4019
2022-03-21 20:41:09 -04:00
Andrey
084a582775
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 22:24:50 -04:00
Andrey
625af513fb
Mitsubishi 3A92 Support - 3 cylinder #4011
2022-03-19 22:11:51 -04:00
rusefillc
1d64929f33
Remove Miata MX5 NB1 trigger fix #3488
2022-01-31 18:20:43 -05:00
rusefillc
21c2a2f7a9
Bosch Quick Start on B6 Passat is confused about phase #3812
...
running engine proved VVT_BOSCH_QUICK_START to match VVT_SECOND_HALF thus hard-coding phase choice
2022-01-19 01:30:16 -05:00
rusefillc
046f26508a
Bosch Quick Start on B6 Passat is confused about phase #3812
...
OMG :( we were totally not using VVT info of VVT_BOSCH_QUICK_START and VVT_NISSAN_MR and etc etc
2022-01-19 00:48:39 -05:00
rusefillc
577b9ccb06
refactoring: reusing existing flag instead of switch which refers to same thing
2022-01-19 00:48:39 -05:00
rusefillc
860f2f96f9
docs
2021-12-29 16:18:21 -05:00
Matthew Kennedy
c3b712aa3b
remove vvtSyncTimeNt ( #3722 )
...
* s
* poke
* poke again for science
* kick for science
* kick
* kick
* comment kick
* s
* don't try to compare the array decay pointer to 0 (!)
* collateral damage
* adjust miata sync
* reset trigger states correctly on engine stop
* s
* check synchronized bit
* now we don't need it at all?!
* and *NOT* synced
* start VVT sync earlier
2021-12-28 00:00:26 -05:00
Matthew Kennedy
95ad75318d
improved noFiringUntilVvtSync logic ( #3696 )
...
* s
* poke
* poke again for science
* kick for science
* kick
* kick
* comment kick
* s
* don't try to compare the array decay pointer to 0 (!)
* collateral damage
* adjust miata sync
* reset trigger states correctly on engine stop
* s
* nissan MR too
2021-12-27 12:09:38 -05:00
Andrey
099f7d5a86
MAP phase sensing #3544
...
limiting to below cranking RPM limit
2021-12-11 02:56:19 -05:00
Matthew Kennedy
6de8364895
maybe more working MAP sampling ( #3689 )
...
* what if we do this
* cleanup
* s
* test
2021-12-11 03:01:28 -04:00
rusefillc
17879ef7de
MAP phase sensing #3544
2021-12-09 22:16:42 -05:00
rusefillc
f44370a5b8
MAP phase sensing #3544
...
gauge name fix
2021-12-08 12:44:43 -05:00
Andrey
3a00fc4767
MAP phase sensing #3544
...
new implementation seems complete? 360 fix
2021-12-07 21:37:33 -05:00
Andrey
50038167d8
MAP phase sensing #3544
...
new implementation seems complete?
2021-12-07 21:08:25 -05:00
Andrey
940b04ab24
Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming
2021-12-07 20:18:47 -05:00
Andrey
e72d57438a
MAP phase sensing #3544
...
new implementation
2021-12-07 20:00:04 -05:00
rusefillc
f826fe13aa
MAP phase sensing #3544
...
trigger sync better gauges/logging
2021-12-06 17:04:05 -05:00
Matthew Kennedy
25beb610b0
log actual tooth angle ( #3646 )
2021-12-02 19:22:33 -05:00
rusefillc
fda7a3a775
Engine phase wrap around in log #3645
...
refactoring & docs
2021-12-02 17:06:20 -05:00
rusefillc
e896afe2f6
Engine phase wrap around in log #3645
...
refactoring & docs
2021-12-02 17:06:20 -05:00