From f2e7db001a1edf244e85b62c1c26dcebbca8124a Mon Sep 17 00:00:00 2001 From: rusefi Date: Sun, 29 Oct 2023 13:31:07 -0400 Subject: [PATCH] testEcuDigitalOutput seems broken around high, low and banks fix #251 --- digital-inputs/firmware/test_logic.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/digital-inputs/firmware/test_logic.cpp b/digital-inputs/firmware/test_logic.cpp index cbd28d4..04e73ed 100644 --- a/digital-inputs/firmware/test_logic.cpp +++ b/digital-inputs/firmware/test_logic.cpp @@ -269,9 +269,11 @@ bool testEcuDigitalOutput(int testLineIndex, bool isLowSide) { // toggle the ECU pin for low side mode sendCanPinState(testLineIndex, isSet ^ isLowSide); - int scenarioIndex = 1; // i % 2; - setScenarioIndex(scenarioIndex); - // wait for the pin to toggle + // at the moment we test both high-side and low-side in pull-up mode only + // effectively we could have just used constant 1111b pullUpDownPinsBitmap + // see also https://github.com/rusefi/rusefi-hardware/issues/252 + int pullUpDownPinsBitmap = 1 << bankIndex; // i % 2 + setScenarioIndex(pullUpDownPinsBitmap); chThdSleepMilliseconds(cycleDurationMs); float voltage = getAdcValue(bankIndex);