From 02a5237942aef75eeec382f0ba2fb3efb9074363 Mon Sep 17 00:00:00 2001 From: rusEFI LLC Date: Tue, 23 Apr 2024 21:00:27 -0400 Subject: [PATCH] only: airTaperRpmRange no UI no usages, looks dead, removing --- .../controllers/actuators/idle_thread.cpp | 2 +- unit_tests/tests/test_idle_controller.cpp | 23 ------------------- 2 files changed, 1 insertion(+), 24 deletions(-) diff --git a/firmware/controllers/actuators/idle_thread.cpp b/firmware/controllers/actuators/idle_thread.cpp index c56a99d27b..ae736a7944 100644 --- a/firmware/controllers/actuators/idle_thread.cpp +++ b/firmware/controllers/actuators/idle_thread.cpp @@ -144,7 +144,7 @@ if (engine->antilagController.isAntilagCondition) { running += iacByTpsTaper; - float airTaperRpmUpperLimit = engineConfiguration->idlePidRpmUpperLimit + engineConfiguration->airTaperRpmRange; + float airTaperRpmUpperLimit = engineConfiguration->idlePidRpmUpperLimit; iacByRpmTaper = interpolateClamped( engineConfiguration->idlePidRpmUpperLimit, 0, airTaperRpmUpperLimit, engineConfiguration->airByRpmTaper, diff --git a/unit_tests/tests/test_idle_controller.cpp b/unit_tests/tests/test_idle_controller.cpp index 2ce1742994..e210f25b37 100644 --- a/unit_tests/tests/test_idle_controller.cpp +++ b/unit_tests/tests/test_idle_controller.cpp @@ -248,29 +248,6 @@ TEST(idle_v2, runningOpenLoopTpsTaperWithDashpot) { EXPECT_FLOAT_EQ(50, dut.getRunningOpenLoop(ICP::Idling, 0, 0, 10)); } -TEST(idle_v2, runningOpenLoopRpmTaper) { - EngineTestHelper eth(engine_type_e::TEST_ENGINE); - IdleController dut; - - // Zero out base tempco table - setArrayValues(config->cltIdleCorr, 0.0f); - - // Add 50% idle position - engineConfiguration->airByRpmTaper = 50; - // At 2000 RPM - engineConfiguration->airTaperRpmRange = 500; - engineConfiguration->idlePidRpmUpperLimit = 1500; - - // Check in-bounds points - EXPECT_FLOAT_EQ(0, dut.getRunningOpenLoop(IIdleController::Phase::Cranking, 1500, 0, 0)); - EXPECT_FLOAT_EQ(25, dut.getRunningOpenLoop(IIdleController::Phase::Cranking, 1750, 0, 0)); - EXPECT_FLOAT_EQ(50, dut.getRunningOpenLoop(IIdleController::Phase::Cranking, 2000, 0, 0)); - - // Check out of bounds - shouldn't leave the interval [1500, 2000] - EXPECT_FLOAT_EQ(0, dut.getRunningOpenLoop(IIdleController::Phase::Cranking, 200, 0, 0)); - EXPECT_FLOAT_EQ(50, dut.getRunningOpenLoop(IIdleController::Phase::Cranking, 3000, 0, 0)); -} - struct MockOpenLoopIdler : public IdleController { MOCK_METHOD(float, getCrankingOpenLoop, (float clt), (const, override)); MOCK_METHOD(float, getRunningOpenLoop, (IIdleController::Phase phase, float rpm, float clt, SensorResult tps), (override));