rusefi
/
rusefi
mirror of https://github.com/rusefi/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Injection/Ignition angle inaccuracy on 60-2? EngineSniffer vs Real Hardware #778

This commit is contained in:
rusefi 2019-05-07 21:39:11 -04:00
parent d7fd0ce6c1
commit 22ec5da4bc
3 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
firmware/controllers/algo/event_registry.h
View File

@ -42,6 +42,7 @@ public:
scheduling_s signalTimerDown;
angle_t advance;
floatms_t sparkDwell;
uint32_t startOfDwell;
event_trigger_position_s dwellPosition;
event_trigger_position_s sparkPosition;
IgnitionEvent *next;

4
firmware/controllers/engine_controller.cpp
View File

@ -786,10 +786,10 @@ void initEngineContoller(Logging *sharedLogger DECLARE_ENGINE_PARAMETER_SUFFIX)
// help to notice when RAM usage goes up - if a code change adds to RAM usage these variables would fail
// linking process which is the way to raise the alarm
#ifndef RAM_UNUSED_SIZE
#define RAM_UNUSED_SIZE 7600
#define RAM_UNUSED_SIZE 7400
#endif
#ifndef CCM_UNUSED_SIZE
#define CCM_UNUSED_SIZE 6800
#define CCM_UNUSED_SIZE 6600
#endif
static char UNUSED_RAM_SIZE[RAM_UNUSED_SIZE];
static char UNUSED_CCM_SIZE[CCM_UNUSED_SIZE] CCM_OPTIONAL;

25
firmware/controllers/trigger/spark_logic.cpp
View File

@ -10,6 +10,11 @@
#include "event_queue.h"
#include "rfiutil.h"
#if EFI_TUNER_STUDIO
#include "tunerstudio_configuration.h"
extern TunerStudioOutputChannels tsOutputChannels;
#endif /* EFI_TUNER_STUDIO */
EXTERN_ENGINE;
static cyclic_buffer<int> ignitionErrorDetection;
@ -119,6 +124,24 @@ void fireSparkAndPrepareNextSchedule(IgnitionEvent *event) {
}
#if !EFI_UNIT_TEST
if (engineConfiguration->debugMode == DBG_DWELL_METRIC) {
uint32_t actualDwellDurationNt = getTimeNowLowerNt() - event->startOfDwell;
/**
* ratio of desired dwell duration to actual dwell duration gives us some idea of how good is input trigger jitter
*/
float ratio = NT2US(actualDwellDurationNt) / 1000.0 / event->sparkDwell;
#if EFI_TUNER_STUDIO
// todo: smarted solution for index to field mapping
if (event->cylinderIndex == 0) {
tsOutputChannels.debugFloatField1 = ratio;
} else if (event->cylinderIndex == 1) {
tsOutputChannels.debugFloatField2 = ratio;
} else if (event->cylinderIndex == 2) {
tsOutputChannels.debugFloatField3 = ratio;
} else if (event->cylinderIndex == 3) {
tsOutputChannels.debugFloatField4 = ratio;
}
#endif
}
#endif /* EFI_UNIT_TEST */
@ -140,6 +163,7 @@ if (engineConfiguration->debugMode == DBG_DWELL_METRIC) {
static void startDwellByTurningSparkPinHigh(IgnitionEvent *event, IgnitionOutputPin *output) {
#if ! EFI_UNIT_TEST
if (GET_RPM_VALUE > 2 * engineConfiguration->cranking.rpm) {
const char *outputName = output->name;
if (prevSparkName == outputName && getCurrentIgnitionMode(PASS_ENGINE_PARAMETER_SIGNATURE) != IM_ONE_COIL) {
@ -172,6 +196,7 @@ static void startDwellByTurningSparkPinHigh(IgnitionEvent *event, IgnitionOutput
}
void turnSparkPinHigh(IgnitionEvent *event) {
event->startOfDwell = getTimeNowLowerNt();
for (int i = 0; i< MAX_OUTPUTS_FOR_IGNITION;i++) {
IgnitionOutputPin *output = event->outputs[i];
if (output != NULL) {