From 3d5338c1de973774400065d797a1e190a5a8f6ae Mon Sep 17 00:00:00 2001 From: rusefi Date: Sun, 21 Apr 2019 12:24:31 -0400 Subject: [PATCH] docs --- firmware/config/engines/custom_engine.cpp | 2 +- .../actuators/electronic_throttle.cpp | 21 ++++++++++--------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/firmware/config/engines/custom_engine.cpp b/firmware/config/engines/custom_engine.cpp index a3c5ac2cae..1ed1eb79ad 100644 --- a/firmware/config/engines/custom_engine.cpp +++ b/firmware/config/engines/custom_engine.cpp @@ -257,7 +257,6 @@ void setEtbTestConfiguration(DECLARE_ENGINE_PARAMETER_SIGNATURE) { // set tps_max 540 engineConfiguration->tpsMax = 540; - boardConfiguration->ignitionPins[0] = GPIO_UNASSIGNED; boardConfiguration->ignitionPins[1] = GPIO_UNASSIGNED; boardConfiguration->ignitionPins[2] = GPIO_UNASSIGNED; @@ -291,6 +290,7 @@ void setEtbTestConfiguration(DECLARE_ENGINE_PARAMETER_SIGNATURE) { engineConfiguration->clt.adcChannel = EFI_ADC_15; set10K_4050K(&engineConfiguration->clt); + // see also setDefaultEtbBiasCurve } // TLE8888_BENCH_ENGINE diff --git a/firmware/controllers/actuators/electronic_throttle.cpp b/firmware/controllers/actuators/electronic_throttle.cpp index f4d8f24a25..70b75632b6 100644 --- a/firmware/controllers/actuators/electronic_throttle.cpp +++ b/firmware/controllers/actuators/electronic_throttle.cpp @@ -414,25 +414,26 @@ void setDefaultEtbBiasCurve(DECLARE_ENGINE_PARAMETER_SIGNATURE) { engineConfiguration->etbBiasBins[0] = 0; engineConfiguration->etbBiasBins[1] = 1; engineConfiguration->etbBiasBins[2] = 2; + /** + * This specific throttle has default position of about 4% open + */ engineConfiguration->etbBiasBins[3] = 4; engineConfiguration->etbBiasBins[4] = 7; engineConfiguration->etbBiasBins[5] = 98; engineConfiguration->etbBiasBins[6] = 99; engineConfiguration->etbBiasBins[7] = 100; -// engineConfiguration->etbBiasValues[0] = -100 / 255.0f * 100; -// engineConfiguration->etbBiasValues[1] = -95 / 255.0f * 100; -// engineConfiguration->etbBiasValues[2] = -80 / 255.0f * 100; -// engineConfiguration->etbBiasValues[3] = 0 / 255.0f * 100; -// engineConfiguration->etbBiasValues[4] = 115 / 255.0f * 100; -// engineConfiguration->etbBiasValues[5] = 142 / 255.0f * 100; -// engineConfiguration->etbBiasValues[6] = 142 / 255.0f * 100; -// engineConfiguration->etbBiasValues[7] = 142 / 255.0f * 100; - + /** + * Some negative bias for below-default position + */ engineConfiguration->etbBiasValues[0] = -20; engineConfiguration->etbBiasValues[1] = -18; engineConfiguration->etbBiasValues[2] = -17; - engineConfiguration->etbBiasValues[3] = 0 / 255.0f * 100; + /** + * Zero bias for index which corresponds to default throttle position, when no current is applied + * This specific throttle has default position of about 4% open + */ + engineConfiguration->etbBiasValues[3] = 0; engineConfiguration->etbBiasValues[4] = 20; engineConfiguration->etbBiasValues[5] = 21; engineConfiguration->etbBiasValues[6] = 22;