diff --git a/firmware/config/engines/bmw_m73.cpp b/firmware/config/engines/bmw_m73.cpp index af8e078765..69a6b322c2 100644 --- a/firmware/config/engines/bmw_m73.cpp +++ b/firmware/config/engines/bmw_m73.cpp @@ -57,6 +57,8 @@ * Manhattan * set engine_type 24 * + * https://raw.githubusercontent.com/wiki/rusefi/rusefi_documentation/oem_docs/VAG/Bosch_0280750009_pinout.jpg + * * @date Nov 1, 2019 * @author Andrey Belomutskiy, (c) 2012-2019 */ @@ -155,6 +157,7 @@ GPIOA_6 // For example TLE7209 - two control wires: // PWM on both wires - one to open, another to close + engineConfiguration->throttlePedalPositionAdcChannel = EFI_ADC_7; // PWM pin boardConfiguration->etb1.controlPin1 = GPIO_UNASSIGNED; // DIR pin diff --git a/firmware/controllers/actuators/electronic_throttle.cpp b/firmware/controllers/actuators/electronic_throttle.cpp index a7c96316ef..8c2cc1bb2a 100644 --- a/firmware/controllers/actuators/electronic_throttle.cpp +++ b/firmware/controllers/actuators/electronic_throttle.cpp @@ -340,7 +340,9 @@ DISPLAY(DISPLAY_IF(hasEtbPedalPositionSensor)) EtbController etbController(&etbHardware[0].dcMotor); /** + * At the moment there are TWO ways to use this * set_etb_duty X + * set etb X * manual duty cycle control without PID. Percent value from 0 to 100 */ void setThrottleDutyCycle(percent_t level) { @@ -358,10 +360,16 @@ void setThrottleDutyCycle(percent_t level) { scheduleMsg(&logger, "duty ETB duty=%f", dc); } +static bool etbOperational = false; + static void showEthInfo(void) { #if EFI_PROD_CODE static char pinNameBuffer[16]; + if (!etbOperational) { + scheduleMsg(&logger, "ETB DISABLED since no PPS"); + } + scheduleMsg(&logger, "etbAutoTune=%d", engine->etbAutoTune); @@ -626,6 +634,7 @@ void initElectronicThrottle(DECLARE_ENGINE_PARAMETER_SIGNATURE) { if (!engine->engineState.hasEtbPedalPositionSensor) { return; } + etbOperational = true; #if 0 // not alive code autoTune.SetOutputStep(0.1);