From 6d2261791d7a99480470768b7910f4f207f92a00 Mon Sep 17 00:00:00 2001
From: rusefillc <48498823+rusefillc@users.noreply.github.com>
Date: Tue, 26 Jul 2022 06:13:36 -0400
Subject: [PATCH] Hellen88bmw (#4378)

* progress

* progress

* progress

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
---
 .github/workflows/build-firmware.yaml                |  5 +++++
 firmware/config/boards/hellen/hellen88bmw/board.mk   |  1 -
 .../boards/hellen/hellen88bmw/compile_hellen88bmw.sh |  5 +++++
 .../hellen/hellen88bmw/compile_hellen88bmw_avr.sh    | 12 ++++++++++++
 4 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 firmware/config/boards/hellen/hellen88bmw/compile_hellen88bmw_avr.sh

diff --git a/.github/workflows/build-firmware.yaml b/.github/workflows/build-firmware.yaml
index 6197ced8b7..dacfeb0e8a 100644
--- a/.github/workflows/build-firmware.yaml
+++ b/.github/workflows/build-firmware.yaml
@@ -23,6 +23,7 @@ jobs:
             hellen72,
             hellen81,
             hellen88bmw,
+            hellen88bmw_avr,
             hellen-nb1,
             hellen-gm-e67,
             hellenNA8_96,
@@ -82,6 +83,10 @@ jobs:
             folder: hellen/hellen88bmw
             ini-file: rusefi_hellen88bmw.ini
 
+          - build-target: hellen88bmw_avr
+            folder: hellen/hellen88bmw
+            ini-file: rusefi_hellen88bmw.ini
+
           - build-target: hellen-nb1
             folder: hellen/hellen-nb1
             ini-file: rusefi_hellen-nb1.ini
diff --git a/firmware/config/boards/hellen/hellen88bmw/board.mk b/firmware/config/boards/hellen/hellen88bmw/board.mk
index d4f2625939..01856e1e06 100644
--- a/firmware/config/boards/hellen/hellen88bmw/board.mk
+++ b/firmware/config/boards/hellen/hellen88bmw/board.mk
@@ -17,7 +17,6 @@ DDEFS += -DTS_NO_PRIMARY=1
 
 # Add them all together
 DDEFS += -DFIRMWARE_ID=\"hellen88bmw\" $(VAR_DEF_ENGINE_TYPE)
-DDEFS += -DEFI_SOFTWARE_KNOCK=TRUE -DSTM32_ADC_USE_ADC3=TRUE
 
 DDEFS += -DSHORT_BOARD_NAME=hellen88bmw
 
diff --git a/firmware/config/boards/hellen/hellen88bmw/compile_hellen88bmw.sh b/firmware/config/boards/hellen/hellen88bmw/compile_hellen88bmw.sh
index 57179cd70c..48d5be0547 100755
--- a/firmware/config/boards/hellen/hellen88bmw/compile_hellen88bmw.sh
+++ b/firmware/config/boards/hellen/hellen88bmw/compile_hellen88bmw.sh
@@ -1,4 +1,9 @@
 #!/bin/bash
 
 cd ..
+
+export EXTRA_PARAMS="-DDUMMY \
+-DEFI_SOFTWARE_KNOCK=TRUE -DSTM32_ADC_USE_ADC3=TRUE \
+"
+
 bash ../common_make.sh hellen/hellen88bmw ARCH_STM32F4
diff --git a/firmware/config/boards/hellen/hellen88bmw/compile_hellen88bmw_avr.sh b/firmware/config/boards/hellen/hellen88bmw/compile_hellen88bmw_avr.sh
new file mode 100644
index 0000000000..151140bc33
--- /dev/null
+++ b/firmware/config/boards/hellen/hellen88bmw/compile_hellen88bmw_avr.sh
@@ -0,0 +1,12 @@
+#!/bin/bash
+
+cd ..
+
+export EXTRA_PARAMS="-DDUMMY \
+-DEFI_SOFTWARE_KNOCK=FALSE \
+-DHAL_TRIGGER_USE_ADC=TRUE \
+-DSTM32_ADC_USE_ADC3=TRUE \
+"
+
+
+bash ../common_make.sh hellen/hellen88bmw ARCH_STM32F4