rusefi
/
rusefi
mirror of https://github.com/rusefi/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Overdwell: explicit unit test for #6373 

only: todo
This commit is contained in:
rusefillc 2024-04-19 16:12:52 -04:00
parent 82734d9691
commit 78345f2a78
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
firmware/controllers/engine_cycle/spark_logic.cpp
View File

@ -455,6 +455,11 @@ static void scheduleSparkEvent(bool limitedSpark, IgnitionEvent *event,
efiPrintf("scheduling overdwell sparkDown revolution=%d [%s] for %d", getRevolutionCounter(), event->getOutputForLoggins()->getName(), fireTime);
#endif /* SPARK_EXTREME_LOGGING */
/**
* todo one: explicit unit test for this mechanism see https://github.com/rusefi/rusefi/issues/6373
* todo two: can we please comprehend/document how this even works? we seem to be reusing 'sparkEvent.scheduling' instance
* and it looks like current (smart?) re-queuing is effectively cancelling out the overdwell? is that the way this was intended to work?
*/
engine->executor.scheduleByTimestampNt("overdwell", &event->sparkEvent.scheduling, fireTime, { overFireSparkAndPrepareNextSchedule, event });
} else {
engine->engineState.overDwellNotScheduledCounter++;