do we have coverage for overdwell?

This commit is contained in:
rusefillc 2024-04-17 10:34:55 -04:00
parent 44e0f14762
commit 9a7b09018e
1 changed files with 3 additions and 0 deletions

View File

@ -448,6 +448,7 @@ static void scheduleSparkEvent(bool limitedSpark, IgnitionEvent *event,
#endif /* SPARK_EXTREME_LOGGING */
if (!limitedSpark && ENABLE_OVERDWELL_PROTECTION) {
/*
// auto fire spark at 1.5x nominal dwell
efitick_t fireTime = chargeTime + MSF2NT(1.5f * dwellMs);
@ -460,7 +461,9 @@ static void scheduleSparkEvent(bool limitedSpark, IgnitionEvent *event,
* todo two: can we please comprehend/document how this even works? we seem to be reusing 'sparkEvent.scheduling' instance
* and it looks like current (smart?) re-queuing is effectively cancelling out the overdwell? is that the way this was intended to work?
*/
/*
engine->executor.scheduleByTimestampNt("overdwell", &event->sparkEvent.scheduling, fireTime, { overFireSparkAndPrepareNextSchedule, event });
*/
} else {
engine->engineState.overDwellNotScheduledCounter++;
}