rusefi
/
rusefi
mirror of https://github.com/rusefi/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

only: overdwell doc update

This commit is contained in:
rusefillc 2024-05-10 22:50:44 -04:00
parent 803b83fa9d
commit aabc64be6d
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
firmware/controllers/engine_cycle/spark_logic.cpp
View File

@ -465,9 +465,9 @@ static void scheduleSparkEvent(bool limitedSpark, IgnitionEvent *event,
#endif /* SPARK_EXTREME_LOGGING */
/**
* todo one: explicit unit test for this mechanism see https://github.com/rusefi/rusefi/issues/6373
* todo two: can we please comprehend/document how this even works? we seem to be reusing 'sparkEvent.scheduling' instance
* todo: can we please comprehend/document how this even works? we seem to be reusing 'sparkEvent.scheduling' instance
* and it looks like current (smart?) re-queuing is effectively cancelling out the overdwell? is that the way this was intended to work?
* [tag:overdwell]
*/
engine->executor.scheduleByTimestampNt("overdwell", &event->sparkEvent.scheduling, fireTime, { overFireSparkAndPrepareNextSchedule, event });

1
firmware/controllers/system/timer/trigger_scheduler.cpp
View File

@ -108,6 +108,7 @@ void TriggerScheduler::scheduleEventsUntilNextTriggerTooth(int rpm,
// In case this event was scheduled by overdwell protection, cancel it so
// we can re-schedule at the correct time
// [tag:overdwell]
engine->executor.cancel(sDown);
scheduleByAngle(