From add3326ef02afe4bafa6acf13038030959eb7eb1 Mon Sep 17 00:00:00 2001
From: rusefillc <48498823+rusefillc@users.noreply.github.com>
Date: Tue, 24 Oct 2023 18:55:29 -0400
Subject: [PATCH] dead warningEnabled global variable (#5636)
---
firmware/console/status_loop.cpp | 11 --
firmware/console/status_loop.h | 1 -
firmware/controllers/core/error_handling.cpp | 2 +-
firmware/rusefi.cpp | 1 -
simulator/simulator/rusEfiFunctionalTest.cpp | 2 -
unit_tests/.cproject | 169 +++++++------------
6 files changed, 58 insertions(+), 128 deletions(-)
diff --git a/firmware/console/status_loop.cpp b/firmware/console/status_loop.cpp
index a7602e18d7..62f9fc50b6 100644
--- a/firmware/console/status_loop.cpp
+++ b/firmware/console/status_loop.cpp
@@ -85,15 +85,9 @@ extern WaveChart waveChart;
#include "sensor_chart.h"
-int warningEnabled = true;
-
extern int maxTriggerReentrant;
extern uint32_t maxLockedDuration;
-static void setWarningEnabled(int value) {
- warningEnabled = value;
-}
-
/**
* This is useful if we are changing engine mode dynamically
* For example http://rusefi.com/forum/viewtopic.php?f=5&t=1085
@@ -215,7 +209,6 @@ void updateDevConsoleState() {
// todo: unify with simulator!
if (hasFirmwareError()) {
efiPrintf("%s error: %s", CRITICAL_PREFIX, getCriticalErrorMessage());
- warningEnabled = false;
return;
}
#endif /* EFI_PROD_CODE */
@@ -765,10 +758,6 @@ DcHardware *getdcHardware();
#endif /* EFI_TUNER_STUDIO */
-void initStatusLoop() {
- addConsoleActionI("warn", setWarningEnabled);
-}
-
void startStatusThreads() {
// todo: refactoring needed, this file should probably be split into pieces
#if EFI_PROD_CODE
diff --git a/firmware/console/status_loop.h b/firmware/console/status_loop.h
index 20bb25445d..2d710c3790 100644
--- a/firmware/console/status_loop.h
+++ b/firmware/console/status_loop.h
@@ -11,6 +11,5 @@
void updateDevConsoleState();
void startStatusThreads();
-void initStatusLoop();
void printOverallStatus();
diff --git a/firmware/controllers/core/error_handling.cpp b/firmware/controllers/core/error_handling.cpp
index cbf3680ed0..90a56a5906 100644
--- a/firmware/controllers/core/error_handling.cpp
+++ b/firmware/controllers/core/error_handling.cpp
@@ -169,7 +169,7 @@ bool warning(ObdCode code, const char *fmt, ...) {
#if EFI_SIMULATOR || EFI_PROD_CODE
// we just had this same warning, let's not spam
- if (engine->engineState.warnings.isWarningNow(code) || !warningEnabled) {
+ if (engine->engineState.warnings.isWarningNow(code)) {
return true;
}
diff --git a/firmware/rusefi.cpp b/firmware/rusefi.cpp
index 34e20e404e..6b8105502a 100644
--- a/firmware/rusefi.cpp
+++ b/firmware/rusefi.cpp
@@ -254,7 +254,6 @@ void runRusEfiWithConfig() {
// Config could be completely bogus - don't start anything else!
if (validateConfig()) {
- initStatusLoop();
/**
* Now let's initialize actual engine control logic
* todo: should we initialize some? most? controllers before hardware?
diff --git a/simulator/simulator/rusEfiFunctionalTest.cpp b/simulator/simulator/rusEfiFunctionalTest.cpp
index 9d9e92fafb..ecd82b0147 100644
--- a/simulator/simulator/rusEfiFunctionalTest.cpp
+++ b/simulator/simulator/rusEfiFunctionalTest.cpp
@@ -163,8 +163,6 @@ void rusEfiFunctionalTest(void) {
enableTriggerStimulator(false);
#endif
- initStatusLoop();
-
writeSimulatorTune();
/**
diff --git a/unit_tests/.cproject b/unit_tests/.cproject
index 18f7f34a8c..77bfd9026c 100644
--- a/unit_tests/.cproject
+++ b/unit_tests/.cproject
@@ -1,114 +1,59 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file