rusefi
/
rusefi
mirror of https://github.com/rusefi/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

only:better method name

This commit is contained in:
rusefillc 2023-06-25 02:08:53 -04:00
parent 638b21f8dc
commit bc2a2b9ab9
14 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
firmware/console/binary/tooth_logger.cpp
View File

@ -240,7 +240,7 @@ static void SetNextCompositeEntry(efitick_t timestamp) {
#endif // EFI_UNIT_TEST
void LogTriggerTooth(trigger_event_e tooth, efitick_t timestamp) {
efiAssertVoid(ObdCode::CUSTOM_ERR_6650, assertRemainingStack(), "l-t-t");
efiAssertVoid(ObdCode::CUSTOM_ERR_6650, hasLotsOfRemainingStack(), "l-t-t");
// bail if we aren't enabled
if (!ToothLoggerEnabled) {
return;

2
firmware/controllers/algo/engine_configuration.cpp
View File

@ -1003,7 +1003,7 @@ void validateConfiguration() {
void applyNonPersistentConfiguration() {
#if EFI_PROD_CODE
efiAssertVoid(ObdCode::CUSTOM_APPLY_STACK, assertRemainingStack(), "apply c");
efiAssertVoid(ObdCode::CUSTOM_APPLY_STACK, hasLotsOfRemainingStack(), "apply c");
efiPrintf("applyNonPersistentConfiguration()");
#endif

2
firmware/controllers/algo/obd_error_codes.h
View File

@ -2125,7 +2125,7 @@ enum class ObdCode : uint16_t {
STACK_USAGE_MIL = 6901,
STACK_USAGE_BENCH = 6902,
STACK_USAGE_STATUS = 6903,
STACK_USAGE_4 = 6904,
STACK_USAGE_MISC = 6904,
// 8000-8050 logging errors
CUSTOM_OBD_MMC_ERROR = 8000,

3
firmware/controllers/core/common_headers.h
View File

@ -42,4 +42,5 @@
#define EXPECTED_REMAINING_STACK 128
#define assertRemainingStack() (getCurrentRemainingStack() > EXPECTED_REMAINING_STACK)
// see also validateStack
#define hasLotsOfRemainingStack() (getCurrentRemainingStack() > EXPECTED_REMAINING_STACK)

2
firmware/controllers/engine_cycle/main_trigger_callback.cpp
View File

@ -197,7 +197,7 @@ void InjectionEvent::onTriggerTooth(int rpm, efitick_t nowNt, float currentPhase
static void handleFuel(int rpm, efitick_t nowNt, float currentPhase, float nextPhase) {
ScopePerf perf(PE::HandleFuel);
efiAssertVoid(ObdCode::CUSTOM_STACK_6627, assertRemainingStack(), "lowstck#3");
efiAssertVoid(ObdCode::CUSTOM_STACK_6627, hasLotsOfRemainingStack(), "lowstck#3");
LimpState limitedFuelState = getLimpManager()->allowInjection();

4
firmware/controllers/engine_cycle/map_averaging.cpp
View File

@ -62,7 +62,7 @@ static void endAveraging(MapAverager* arg);
static size_t currentMapAverager = 0;
static void startAveraging(scheduling_s *endAveragingScheduling) {
efiAssertVoid(ObdCode::CUSTOM_ERR_6649, assertRemainingStack(), "lowstck#9");
efiAssertVoid(ObdCode::CUSTOM_ERR_6649, hasLotsOfRemainingStack(), "lowstck#9");
// TODO: set currentMapAverager based on cylinder bank
auto& averager = getMapAvg(currentMapAverager);
@ -129,7 +129,7 @@ void MapAverager::stop() {
* as fast as possible
*/
void mapAveragingAdcCallback(float instantVoltage) {
efiAssertVoid(ObdCode::CUSTOM_ERR_6650, assertRemainingStack(), "lowstck#9a");
efiAssertVoid(ObdCode::CUSTOM_ERR_6650, hasLotsOfRemainingStack(), "lowstck#9a");
SensorResult mapResult = getMapAvg(currentMapAverager).submit(instantVoltage);

2
firmware/controllers/system/timer/single_timer_executor.cpp
View File

@ -34,7 +34,7 @@
uint32_t hwSetTimerDuration;
void globalTimerCallback() {
efiAssertVoid(ObdCode::CUSTOM_ERR_6624, assertRemainingStack(), "lowstck#2y");
efiAssertVoid(ObdCode::CUSTOM_ERR_6624, hasLotsOfRemainingStack(), "lowstck#2y");
___engine.executor.onTimerCallback();
}

2
firmware/controllers/trigger/decoders/trigger_structure.cpp
View File

@ -413,7 +413,7 @@ void TriggerWaveform::setThirdTriggerSynchronizationGap(float syncRatio) {
void TriggerWaveform::initializeTriggerWaveform(operation_mode_e triggerOperationMode, const trigger_config_s &triggerType) {
#if EFI_PROD_CODE
efiAssertVoid(ObdCode::CUSTOM_ERR_6641, assertRemainingStack(), "init t");
efiAssertVoid(ObdCode::CUSTOM_ERR_6641, hasLotsOfRemainingStack(), "init t");
efiPrintf("initializeTriggerWaveform(%s/%d)", getTrigger_type_e(triggerType.type), (int)triggerType.type);
#endif

2
firmware/controllers/trigger/trigger_central.cpp
View File

@ -1039,7 +1039,7 @@ static void calculateTriggerSynchPoint(
TriggerDecoderBase& initState) {
#if EFI_PROD_CODE
efiAssertVoid(ObdCode::CUSTOM_TRIGGER_STACK, assertRemainingStack(), "calc s");
efiAssertVoid(ObdCode::CUSTOM_TRIGGER_STACK, hasLotsOfRemainingStack(), "calc s");
#endif
shape.initializeSyncPoint(initState, primaryTriggerConfiguration);

2
firmware/controllers/trigger/trigger_decoder.cpp
View File

@ -694,7 +694,7 @@ uint32_t TriggerDecoderBase::findTriggerZeroEventIndex(
TriggerWaveform& shape,
const TriggerConfiguration& triggerConfiguration) {
#if EFI_PROD_CODE
efiAssert(ObdCode::CUSTOM_ERR_ASSERT, assertRemainingStack(), "findPos", -1);
efiAssert(ObdCode::CUSTOM_ERR_ASSERT, hasLotsOfRemainingStack(), "findPos", -1);
#endif

1
firmware/global.h
View File

@ -55,6 +55,7 @@ typedef unsigned int time_t;
#define UTILITY_THREAD_STACK_SIZE 400
#endif /* UTILITY_THREAD_STACK_SIZE */
// see also validateStack
#define getCurrentRemainingStack() getRemainingStack(chThdGetSelfX())
#define EFI_ERROR_CODE 0xffffffff

6
firmware/hw_layer/hardware.cpp
View File

@ -80,7 +80,7 @@ extern bool isSpiInitialized[5];
* Only one consumer can use SPI bus at a given time
*/
void lockSpi(spi_device_e device) {
efiAssertVoid(ObdCode::CUSTOM_STACK_SPI, assertRemainingStack(), "lockSpi");
efiAssertVoid(ObdCode::CUSTOM_STACK_SPI, hasLotsOfRemainingStack(), "lockSpi");
spiAcquireBus(getSpiDevice(device));
}
@ -177,7 +177,7 @@ void onFastAdcComplete(adcsample_t*) {
/**
* this callback is executed 10 000 times a second, it needs to be as fast as possible
*/
efiAssertVoid(ObdCode::CUSTOM_STACK_ADC, assertRemainingStack(), "lowstck#9b");
efiAssertVoid(ObdCode::CUSTOM_STACK_ADC, hasLotsOfRemainingStack(), "lowstck#9b");
#if EFI_SENSOR_CHART && EFI_SHAFT_POSITION_INPUT
if (getEngineState()->sensorChartMode == SC_AUX_FAST1) {
@ -370,7 +370,7 @@ void setBor(int borValue) {
// This function initializes hardware that can do so before configuration is loaded
void initHardwareNoConfig() {
efiAssertVoid(ObdCode::CUSTOM_IH_STACK, assertRemainingStack(), "init h");
efiAssertVoid(ObdCode::CUSTOM_IH_STACK, hasLotsOfRemainingStack(), "init h");
efiPrintf("initHardware()");

2
firmware/util/datalogging.cpp
View File

@ -78,7 +78,7 @@ void Logging::appendFast(const char *text) {
}
void Logging::appendPrintf(const char *fmt, ...) {
efiAssertVoid(ObdCode::CUSTOM_APPEND_STACK, assertRemainingStack(), "lowstck#4");
efiAssertVoid(ObdCode::CUSTOM_APPEND_STACK, hasLotsOfRemainingStack(), "lowstck#4");
size_t available = remainingSize();

2
misc/stm32f1_test_project/timer/single_timer_executor.cpp
View File

@ -34,7 +34,7 @@
uint32_t hwSetTimerDuration;
void globalTimerCallback() {
efiAssertVoid(ObdCode::CUSTOM_ERR_6624, assertRemainingStack(), "lowstck#2y");
efiAssertVoid(ObdCode::CUSTOM_ERR_6624, hasLotsOfRemainingStack(), "lowstck#2y");
___engine.executor.onTimerCallback();
}