From c69e202eafd7479ab4f03d5807c3c81b2c598a9a Mon Sep 17 00:00:00 2001 From: Andrey Date: Sun, 17 Mar 2024 21:05:11 -0400 Subject: [PATCH] Seems that gdi pump angle changes at 2x the rate of cam movement, possible multiplication/division problem? #6245 only:alphax-4chan_f7 --- firmware/controllers/algo/defaults/default_base_engine.cpp | 1 + unit_tests/tests/test_hpfp.cpp | 1 + unit_tests/tests/test_hpfp_integrated.cpp | 1 + 3 files changed, 3 insertions(+) diff --git a/firmware/controllers/algo/defaults/default_base_engine.cpp b/firmware/controllers/algo/defaults/default_base_engine.cpp index 4757436323..8800bb17e9 100644 --- a/firmware/controllers/algo/defaults/default_base_engine.cpp +++ b/firmware/controllers/algo/defaults/default_base_engine.cpp @@ -79,6 +79,7 @@ void setDefaultBaseEngine() { engineConfiguration->fan2ExtraIdle = 2; engineConfiguration->auxSpeed1Multiplier = 1; + engineConfiguration->magicNumberAvailableForDevTricks = 1; engineConfiguration->acrRevolutions = 5; diff --git a/unit_tests/tests/test_hpfp.cpp b/unit_tests/tests/test_hpfp.cpp index 7d7afa45e7..68c807770b 100755 --- a/unit_tests/tests/test_hpfp.cpp +++ b/unit_tests/tests/test_hpfp.cpp @@ -8,6 +8,7 @@ using ::testing::StrictMock; TEST(HPFP, Lobe) { EngineTestHelper eth(engine_type_e::TEST_ENGINE); + engineConfiguration->magicNumberAvailableForDevTricks = 2; engineConfiguration->hpfpCam = HPFP_CAM_NONE; engineConfiguration->hpfpPeakPos = 123; diff --git a/unit_tests/tests/test_hpfp_integrated.cpp b/unit_tests/tests/test_hpfp_integrated.cpp index 7685eb5c13..0e98f75183 100644 --- a/unit_tests/tests/test_hpfp_integrated.cpp +++ b/unit_tests/tests/test_hpfp_integrated.cpp @@ -20,6 +20,7 @@ TEST(HPFP, IntegratedSchedule) { EngineTestHelper eth(engine_type_e::TEST_ENGINE, [](engine_configuration_s* engineConfiguration) { engineConfiguration->hpfpValvePin = Gpio::A2; // arbitrary }); + engineConfiguration->magicNumberAvailableForDevTricks = 2; engineConfiguration->cylindersCount = 4; engineConfiguration->hpfpCamLobes = 3;