fix simulator build (via MinGW) (#4799)

* firmware: kill -9 dead hipLastExecutionCount

* firmware: pin_repository C includes efi_gpio.h

* firmware: controllers: tidy #endif comments

* firmware: primary_pins logic depends EFI_GPIO_HARDWARE

* firmware: only print ADC info if HAL_USE_ADC

* firmware: digital_input: tidy #endif comments

* firmware: digital_input logic depends on e.g. HAL_USE_ADC

* firmware: digital_input logic depends !EFI_SIMULATOR

* firmware: digital_input logic depends e.g. HAL_USE_ADC

* simulator: Makefile includes RUSEFI_LIB_C as CSRC

* Revert "GHA/build-firmware: pin agents to Ubuntu 20.04 (#4793)"

This reverts commit cb2477be6c.

.github/workflows/build-firmware.yaml

@@ -4,7 +4,7 @@ on: [push, pull_request, workflow_dispatch]
 
 jobs:
   build-firmware:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
 
     strategy:
       # Let all builds finish even if one fails early
@@ -406,7 +406,7 @@ jobs:
 
   # here we build f407-discovery
   build-primary-bundle:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v3
       with:

firmware/hw_layer/hardware.cpp

@@ -403,10 +403,12 @@ void initHardwareNoConfig() {
 	initHistogramsModule();
 #endif /* EFI_HISTOGRAMS */
 
+#if EFI_GPIO_HARDWARE
 	/**
 	 * We need the LED_ERROR pin even before we read configuration
 	 */
 	initPrimaryPins();
+#endif // EFI_GPIO_HARDWARE
 
 #if EFI_PROD_CODE
 	// it's important to initialize this pretty early in the game before any scheduling usages

firmware/hw_layer/pin_repository.h

@@ -12,9 +12,9 @@
 
 #include "global.h"
 #include "io_pins.h"
+#include "efi_gpio.h"
 
 #ifdef __cplusplus
-#include "efi_gpio.h"
 
 class PinRepository {
 	public:

simulator/Makefile

@@ -162,6 +162,7 @@ include $(PROJECT_DIR)/common.mk
 # C sources that can be compiled in ARM or THUMB mode depending on the global
 # setting.
 CSRC =  $(ALLCSRC) \
+  $(RUSEFI_LIB_C)
 
 
 # C++ sources that can be compiled in ARM or THUMB mode depending on the global