trigger layer start-up is a mess #5241

reducing the mess: moving logic out of strange method

firmware/hw_layer/digital_input/trigger/trigger_input.cpp

@@ -193,9 +193,6 @@ void onEcuStartDoSomethingTriggerInputPins() {
 		// if we do not have primary input channel maybe it's BCM mode and we inject RPM value via Lua?
 		engine->rpmCalculator.unregister();
 	}
-
-	// then we will enable all the changed pins
-	startTriggerInputPins();
 #endif /* EFI_PROD_CODE */
 }
 

firmware/hw_layer/hardware.cpp

@@ -571,6 +571,7 @@ void initHardware() {
 #if EFI_PROD_CODE && EFI_SHAFT_POSITION_INPUT
 	onEcuStartTriggerImplementation();
 	onEcuStartDoSomethingTriggerInputPins();
+   	startTriggerInputPins();
 #endif /* EFI_SHAFT_POSITION_INPUT */
 
 #if EFI_HIP_9011