rusefi
/
rusefi
mirror of https://github.com/rusefi/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove 898 (#4634) 

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
This commit is contained in:
Matthew Kennedy 2022-10-04 17:12:57 -07:00 committed by GitHub
parent 771b907156
commit ec5d48fb5b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 1 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
firmware/config/engines/custom_engine.cpp
View File

@ -293,12 +293,6 @@ void setEtbTestConfiguration() {
// see also setDefaultEtbBiasCurve
}
#if EFI_UNIT_TEST
void setIssue898() {
engineConfiguration->trigger.type = TT_MAZDA_MIATA_NA;
}
#endif /* EFI_UNIT_TEST */
#if HW_FRANKENSO && EFI_PROD_CODE

1
firmware/config/engines/custom_engine.h
View File

@ -19,7 +19,6 @@ void setL9779TestConfiguration();
void setEepromTestConfiguration();
void setIssue898();
void setTestQuadCam();
void mreBoardNewTest();

3
firmware/controllers/algo/engine_configuration.cpp
View File

@ -826,9 +826,6 @@ void resetConfigurationExt(configuration_callback_t boardCallback, engine_type_e
case TEST_ISSUE_366_RISE:
setTestEngineIssue366rise();
break;
case TEST_ISSUE_898:
setIssue898();
break;
#endif // EFI_UNIT_TEST
#if HW_MICRO_RUSEFI
case MRE_VW_B6:

5
firmware/controllers/algo/engine_types.h
View File

@ -82,10 +82,7 @@ typedef enum __attribute__ ((__packed__)) {
TEST_ENGINE = 26,
// used by unit test
// see https://github.com/rusefi/rusefi/issues/898
// see TriggerWaveform::bothFrontsRequired
TEST_ISSUE_898 = 27,
UNUSED_27 = 27,
TEST_CRANK_ENGINE = 28,

1
unit_tests/tests/tests.mk
View File

@ -55,7 +55,6 @@ TESTS_SRC_CPP = \
tests/test_fasterEngineSpinningUp.cpp \
tests/test_dwell_corner_case_issue_796.cpp \
tests/test_idle_controller.cpp \
tests/test_issue_898.cpp \
tests/test_launch.cpp \
tests/test_fuel_map.cpp \
tests/test_gear_detector.cpp \

24
unit_tests/tests/trigger/test_issue_898.cpp
View File

@ -1,24 +0,0 @@
/*
* @file test_issue_898.cpp
*
* @date Aug 8, 2019
* @author Andrey Belomutskiy, (c) 2012-2020
*/
#include "pch.h"
static void boardConfigurationForIssue898(engine_configuration_s *engineConfiguration) {
setCrankOperationMode();
engineConfiguration->trigger.type = TT_TOOTHED_WHEEL_60_2;
engineConfiguration->useOnlyRisingEdgeForTrigger = true;
}
TEST(issues, issue898) {
EngineTestHelper eth(TEST_ISSUE_898, &boardConfigurationForIssue898);
ASSERT_EQ(TRUE, engine->triggerCentral.triggerShape.shapeDefinitionError) << "MRE_MIATA_NA6 shapeDefinitionError";
ASSERT_EQ( 2, eth.recentWarnings()->getCount()) << "warningCounter#testFuelSchedulerBug299smallAndMedium";
ASSERT_EQ(CUSTOM_ERR_BOTH_FRONTS_REQUIRED, eth.recentWarnings()->get(0).Code);
ASSERT_EQ(CUSTOM_ERR_TRIGGER_SYNC, eth.recentWarnings()->get(1).Code);
}