Commit Graph

149 Commits

Author SHA1 Message Date
rusefillc 9c33854653 Overdwell at times around syncloss while cranking
#6349

only: test data
2024-04-12 08:52:17 -04:00
rusefi 9c77bc709a only: better method name 2024-04-10 00:02:39 -04:00
rusefillc 143170d60c odd fire timing_offset_cylinder not accounted by injection revert #6095
revert of revert, we have timing accounted by fuel again!
2024-04-09 16:54:53 -04:00
Andrey 4c0bf9c070 only: nope, not needed 2024-04-09 09:38:24 -04:00
Andrey e18a3b5e64 odd fire timing_offset_cylinder not accounted by injection #6095
flipping adjustment direction
2024-04-08 22:44:52 -04:00
Andrey 3441417b24 odd fire timing_offset_cylinder not accounted by injection #6095
only:flipping test numbers
2024-04-08 22:39:31 -04:00
rusefi 4312338f4e only: making test more readable 2024-04-08 21:09:25 -04:00
Andrey 9397521d0b only:docs 2024-04-04 12:09:17 -04:00
rusefillc fb66699cd8 odd fire angles are not right during cranking
#6281

only:docs
2024-03-25 10:09:02 -04:00
Andrey 5642d412de odd fire timing_offset_cylinder not accounted by injection revert #6095
odd fire angles are not right during cranking #6281

only:proteus_f7
2024-03-24 13:18:14 -04:00
Matthew Kennedy a50fdf34d4 avoid UB in tests 2024-03-23 07:54:27 -04:00
Andrey 5d46bb1074 Negative timing is not displayed correctly fix #5250 2024-03-20 14:43:50 -04:00
Andrey ef2fe9e33c Timing showing crazy negative values like -595 #5250
only:tdd
2024-03-20 14:24:20 -04:00
Andrey d3461e3905 odd fire timing_offset_cylinder not accounted by injection fix #6095 2024-02-29 12:29:46 -05:00
Andrey df6ec17a64 odd fire timing_offset_cylinder not accounted by injection #6095
only: TDD to the win
2024-02-29 09:49:03 -05:00
Andrey f487065e75 maximumIgnitionTiming does not account timing_offset_cylinder #5894
only: TDD progress
2024-02-29 08:08:31 -05:00
Andrey 12db01c948 first spark out of order coilIndex logic in prepareCylinderIgnitionSchedule fix #6094 2024-02-29 01:47:43 -05:00
Andrey 4347c5c82e maximumIgnitionTiming does not account timing_offset_cylinder #5894
only: TDD progress
2024-02-29 01:33:42 -05:00
Andrey d2b6ae4d11 only: last rename for now 2024-02-29 00:41:12 -05:00
Andrey 98dcca20b1 maximumIgnitionTiming does not account timing_offset_cylinder #5894
only: TDD first steps
2024-02-29 00:16:41 -05:00
Andrey b04b6a9251 only: NICE! these values actually mean something! 2024-02-28 22:53:44 -05:00
Andrey 928f6f2866 only: reducing magic numbers in unit tests 2024-02-28 21:05:48 -05:00
Andrey 73298d21ad maximumIgnitionTiming does not account timing_offset_cylinder #5894
only: nothing
2024-02-28 19:34:13 -05:00
Matthew Kennedy e718489774 Actually separate injector model for second stage 2024-01-17 08:46:21 -05:00
Matthew Kennedy 1f64950e33 Staged injection support; use two sets of injectors on the same engine #5247
two injection models for two stages
2024-01-07 22:36:20 -05:00
rusefi 3db5c6e3f7 only:minor encapsulation 2023-10-12 23:15:54 -04:00
rusefillc d77fb3bf24 "Single Tooth" renamed to "Half Moon", more proper "Single Tooth" crank trigger as a new trigger fix #5488 2023-08-06 00:46:33 -04:00
Matthew Kennedy 10c5c4ec94 #23 and fix https://github.com/rusefi/rusefi/issues/5353
(cherry picked from commit b0c3357cba)
2023-06-25 00:25:07 -04:00
rusefi 633274055b Technical debt: ENUM_32_BITS #3874
poking the bear
2023-06-01 10:29:05 -04:00
rusefi 415b3d55df Technical debt: ENUM_32_BITS #3874
poking the bear
2023-06-01 01:45:53 -04:00
Matthew Kennedy 06cda6cfa4 add postState flag to airmass model calls #107
(cherry picked from commit b1b1ec7fdf)
2023-05-16 13:02:45 -04:00
Matthew Kennedy 3d1dc5a442 table-only map fallback (#46)
* table-only map fallback

* InSequence

(cherry picked from commit 4cd08fbc4b)
2023-05-04 11:02:39 -04:00
Matthew Kennedy 769718771c better idle VE table transition
(cherry picked from commit bdeeb82f93)
2023-04-30 00:21:52 -04:00
Matthew Kennedy a19baddd47 support abs+gauge+diff fuel pressure #32
(cherry picked from commit cb0e81b062)
2023-04-30 00:20:11 -04:00
Matthew Kennedy 2857e9527d remove specs_s struct, flatten config
(cherry picked from commit f090a97b0b)
2023-04-28 20:59:11 -04:00
Matthew Kennedy 994ee2f22f
Combine angle based event (#4884)
* Remove AngleBasedEventOld/New, only AngleBasedEvent now

* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
Matthew Kennedy 151416b005
default fuel cleanup and injection phase change (#4836)
* default fuel cleanup and injection phase change

* happy tests

* changelog

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-29 23:41:49 -05:00
rusefillc 23698be5f8
without ValueProvider3D interface how do we mock? (#4829)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 11:23:54 -05:00
Andrey 6ca9b6eda7 refactoring: default parameter, global replace 2022-11-16 14:28:43 -05:00
Matthew Kennedy 5c50ad2db4
infer useOnlyRisingEdge by trigger type (#4621)
* most of the plumbing

* easy tests

* trigger types that are rise only

* configs

* change mode of various triggers

* vvt

* 898 test is now impossible 🥳

* s

* instant rpm test

* actually remove useOnlyRisingEdgeForTrigger

* remove vvtCamSensorUseRise

* s

* print

* one happy test

* another test

* happy testSomethingWeird

* happy testCamInput

* maybe fix it a different way

* better

* quad cam

* nb2 happy

* bad merge

* vvt test

* trigger.test1995FordInline6TriggerDecoder

* hellen gm e67

* changelog
2022-11-08 21:48:39 -05:00
rusefillc 36d5b1fbb6 minor trigger refactoring 2022-11-06 00:59:29 -04:00
Matthew Kennedy f4f5f69ee6
duplicate log field names (#4730)
* remove duplicate target lambda/afr

* names on fuel computer

* remove more copies

* sensor.java

* everybody loves hard dependencies on generated fields

* target afr gauge fix

* test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-05 20:23:09 -04:00
Matthew Kennedy 24650f6460
implement "ford mode" injector correction (#4686)
* implement "ford mode"

* missed the enum value
2022-10-20 22:25:39 -04:00
Matthew Kennedy ca623eb6ee
plumbing parts of 4621 (#4622)
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy 7139ddcda2
explicitly pass which edges we sync trigger on (#4607)
* require sync edge type

* s

* fix neon

* info printing

* put enums back

* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
Matthew Kennedy dfe1b47b4d
remove ignitionPin (#4608)
* remove ignitionPin

* now that's gone

* BMW test
2022-09-23 17:30:10 -04:00
rusefillc 2a05a31550 refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc 851e8e48d3 refactoring: type safety 2022-09-11 02:57:35 -04:00
Andrey 4934d76d88 tear down Engine god object #4511
just trying different things
2022-09-05 04:24:17 -04:00
Andrey feb386a54b refactoring: moving field 2022-09-05 01:15:45 -04:00