Commit Graph

134 Commits

Author SHA1 Message Date
Matthew Kennedy a50fdf34d4 avoid UB in tests 2024-03-23 07:54:27 -04:00
rusefillc a05c0ef730 engine type clean-up 2024-03-06 00:13:11 -05:00
rusefillc f4b1a7bae0 engine type clean-up 2024-03-06 00:13:11 -05:00
Andrey b335244601 only: reducing magic numbers in unit tests 2024-02-28 20:44:22 -05:00
Andrey 8fe5c4a1c9 only: wow hello 2013 2024-02-28 20:28:38 -05:00
Andrey 389c6e64e9 only: reducing magic numbers in unit tests 2024-02-28 20:20:41 -05:00
Andrey 17275e4f4b maximumIgnitionTiming does not account timing_offset_cylinder #5894
only: renaming field so that we do not have two entities with same name and different meaning
2024-02-28 19:34:13 -05:00
rusefillc 81c050a75b only: dead ET camaro 2024-01-16 11:53:22 -05:00
rusefillc fb899cdefb only: inline method & dead code 2024-01-16 11:02:26 -05:00
Matthew Kennedy 1f64950e33 Staged injection support; use two sets of injectors on the same engine #5247
two injection models for two stages
2024-01-07 22:36:20 -05:00
Matthew Kennedy 26b351ba40 Remove/make injector duty limit configurable fix #4798 2024-01-07 22:36:18 -05:00
Andrey 391b5947e8 only: actually using msg in assertions 2024-01-07 13:43:30 -05:00
Andrey d2f899e737 reducing/moving technical debt 2023-08-29 16:46:04 -04:00
rusefillc d77fb3bf24 "Single Tooth" renamed to "Half Moon", more proper "Single Tooth" crank trigger as a new trigger fix #5488 2023-08-06 00:46:33 -04:00
rusefi 0099de49af ignition timing clamping settings 2023-07-22 00:07:15 -04:00
rusefi 2a5772374c ignition timing clamping settings
only:status quo
2023-07-21 23:45:03 -04:00
Matthew Kennedy 7f67ecd02d simplify adjustCrankPhase
(cherry picked from commit 7ae11160d9)
2023-06-28 21:49:51 -04:00
Matthew Kennedy e03bbd00aa explicit tests for batch and single point 2023-06-26 10:41:16 -04:00
Matthew Kennedy ae3ae86e75 fix (honestly gross) tests to work in two wire batch
(cherry picked from commit 01b4f1191a)
2023-06-25 00:25:11 -04:00
Matthew Kennedy 10c5c4ec94 #23 and fix https://github.com/rusefi/rusefi/issues/5353
(cherry picked from commit b0c3357cba)
2023-06-25 00:25:07 -04:00
rusefi 633274055b Technical debt: ENUM_32_BITS #3874
poking the bear
2023-06-01 10:29:05 -04:00
rusefi 415b3d55df Technical debt: ENUM_32_BITS #3874
poking the bear
2023-06-01 01:45:53 -04:00
Matthew Kennedy 06cda6cfa4 add postState flag to airmass model calls #107
(cherry picked from commit b1b1ec7fdf)
2023-05-16 13:02:45 -04:00
Matthew Kennedy 61e5b4b1ad change ObdCode to enum class builds firmware 2023-04-29 00:44:00 -04:00
Matthew Kennedy c5abc06429 nobody should use NA6 VAF
(cherry picked from commit 0072e8f33c)
2023-04-28 21:52:48 -04:00
Matthew Kennedy 2857e9527d remove specs_s struct, flatten config
(cherry picked from commit f090a97b0b)
2023-04-28 20:59:11 -04:00
Andrey 0098a3d4b9 Clean-up all the 4g drama #5213 2023-04-01 15:40:24 -04:00
Matthew Kennedy 827dc22757
rewrite neon trigger (#5003)
* rewrite neon trigger

* we were testing the same thing four times, maybe test it once
2023-01-24 18:33:15 +05:30
Andrey 6588e813ae totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-15 08:26:38 -05:00
Andrey 9abdab795d totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-14 23:21:23 -05:00
Andrey 0c1859b77e totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-14 15:33:17 -05:00
Andrey 0f1d46238f Mitsubishi 4G93 Trigger issues #4918 2023-01-07 16:28:57 -05:00
Matthew Kennedy e5d199272d
improve iat ignition table (#4948)
* iat ignition table

* changelog
2023-01-06 21:59:34 -05:00
Andrey c9d88d2605 a bit of dead code 2023-01-03 13:59:25 -05:00
Andrey d0f6fa8ea3 let's try again 2023-01-03 08:38:42 -05:00
Andrey 603f188b55 a bit of dead code 2023-01-03 07:49:17 -05:00
Matthew Kennedy 994ee2f22f
Combine angle based event (#4884)
* Remove AngleBasedEventOld/New, only AngleBasedEvent now

* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
Matthew Kennedy 151416b005
default fuel cleanup and injection phase change (#4836)
* default fuel cleanup and injection phase change

* happy tests

* changelog

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-29 23:41:49 -05:00
Matthew Kennedy 5c50ad2db4
infer useOnlyRisingEdge by trigger type (#4621)
* most of the plumbing

* easy tests

* trigger types that are rise only

* configs

* change mode of various triggers

* vvt

* 898 test is now impossible 🥳

* s

* instant rpm test

* actually remove useOnlyRisingEdgeForTrigger

* remove vvtCamSensorUseRise

* s

* print

* one happy test

* another test

* happy testSomethingWeird

* happy testCamInput

* maybe fix it a different way

* better

* quad cam

* nb2 happy

* bad merge

* vvt test

* trigger.test1995FordInline6TriggerDecoder

* hellen gm e67

* changelog
2022-11-08 21:48:39 -05:00
rusefi 1f3ab0cf24 reducing ugly 2022-11-06 21:28:38 -05:00
Andrey a5136a0eae trigger refactoring: instance RPM #4740 2022-11-06 11:05:57 -05:00
rusefillc 36d5b1fbb6 minor trigger refactoring 2022-11-06 00:59:29 -04:00
Matthew Kennedy f760ae11c1
simplify initializeSkippedToothTrigger (#4674) 2022-10-17 16:05:27 -04:00
Matthew Kennedy ca623eb6ee
plumbing parts of 4621 (#4622)
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy b089825a4a
schedule ignition charge by angle instead of tooth (#4513)
* schedule ignition charge by angle

* same mistake as #4536

* s

* wrap sparkAngle too

* AngleBasedEventNew

* function moved

* implement scheduleOrQueue

* prints
2022-09-25 11:00:55 -04:00
Andrey 6cdb0dc0af deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey 6b0941b8ed inline method to reduce confusion 2022-09-14 01:24:19 -04:00
Andrey 4934d76d88 tear down Engine god object #4511
just trying different things
2022-09-05 04:24:17 -04:00
Andrey feb386a54b refactoring: moving field 2022-09-05 01:15:45 -04:00
Andrey 7e340cceb3 refactoring: reducing outputChannels copy 2022-09-01 10:58:16 -04:00