port: GetConfiguration() return reference, not copy (#161)

firmware/boards/f0_module/port.cpp

@@ -95,12 +95,12 @@ int InitConfiguration()
     return 0;
 }
 
-Configuration GetConfiguration()
+static Configuration c;
+
+Configuration& GetConfiguration()
 {
     const auto& cfg = __configflash__start__;
 
-    Configuration c;
-
     // If config has been written before, use the stored configuration
     if (cfg.IsValid())
     {

firmware/boards/f1_dual/port.cpp

@@ -117,10 +117,12 @@ static struct {
     uint8_t        pad[128];
 } config;
 
-Configuration GetConfiguration()
+static Configuration c;
+
+Configuration& GetConfiguration()
 {
     // TODO: implement me!
-    return {};
+    return c;
 }
 
 void SetConfiguration(const Configuration& newConfig)

firmware/boards/f1_rev2/port.cpp

@@ -81,10 +81,12 @@ static struct {
     uint8_t        pad[128];
 } config;
 
-Configuration GetConfiguration()
+static Configuration c;
+
+Configuration& GetConfiguration()
 {
     // TODO: implement me!
-    return {};
+    return c;
 }
 
 void SetConfiguration(const Configuration& newConfig)

firmware/boards/f1_rev3/port.cpp

@@ -108,10 +108,12 @@ int InitConfiguration()
     return 0;
 }
 
-Configuration GetConfiguration()
+static Configuration c;
+
+Configuration& GetConfiguration()
 {
     // TODO: implement me!
-    return {};
+    return c;
 }
 
 void SetConfiguration(const Configuration& newConfig)

firmware/boards/port.h

@@ -38,7 +38,7 @@ public:
     uint8_t pad[128 - 1 - 4];
 };
 
-Configuration GetConfiguration();
+Configuration& GetConfiguration();
 void SetConfiguration(const Configuration& newConfig);
 
 /* TS stuff */

firmware/can.cpp

@@ -100,7 +100,7 @@ void CanRxThread(void*)
         // Check if it's an "index set" message
         else if (frame.DLC == 1 && frame.EID == WB_MSG_SET_INDEX)
         {
-            auto newCfg = GetConfiguration();
+            auto &newCfg = GetConfiguration();
             newCfg.CanIndexOffset = frame.data8[0];
             SetConfiguration(newCfg);
             configuration = GetConfiguration();